Commit b6dc6c9c authored by Peter Kotwicz's avatar Peter Kotwicz Committed by Commit Bot

[Webapps] Remove no longer needed --aggressively-prewarm-renderers flag

This CL removes the --aggressively-prewarm-renderers command line flag.
I am deleting it because there are no plans on turning on the flag
behaviour by default.

BUG=1022819

Change-Id: I6fcfe9be782ed5a1f20831b89b356b28e1671045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906310Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713902}
parent f4bdd3aa
...@@ -7,10 +7,6 @@ package org.chromium.chrome.browser; ...@@ -7,10 +7,6 @@ package org.chromium.chrome.browser;
import android.os.Bundle; import android.os.Bundle;
import android.util.Pair; import android.util.Pair;
import org.chromium.base.ActivityState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.CommandLine;
import org.chromium.base.task.PostTask;
import org.chromium.chrome.browser.dependency_injection.ChromeActivityComponent; import org.chromium.chrome.browser.dependency_injection.ChromeActivityComponent;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabBuilder; import org.chromium.chrome.browser.tab.TabBuilder;
...@@ -21,7 +17,6 @@ import org.chromium.chrome.browser.tabmodel.TabLaunchType; ...@@ -21,7 +17,6 @@ import org.chromium.chrome.browser.tabmodel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModelSelector; import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabSelectionType; import org.chromium.chrome.browser.tabmodel.TabSelectionType;
import org.chromium.chrome.browser.tabmodel.document.TabDelegate; import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
import org.chromium.content_public.browser.UiThreadTaskTraits;
/** /**
* Base class for task-focused activities that need to display a single tab. * Base class for task-focused activities that need to display a single tab.
...@@ -32,8 +27,6 @@ import org.chromium.content_public.browser.UiThreadTaskTraits; ...@@ -32,8 +27,6 @@ import org.chromium.content_public.browser.UiThreadTaskTraits;
*/ */
public abstract class SingleTabActivity<C extends ChromeActivityComponent> public abstract class SingleTabActivity<C extends ChromeActivityComponent>
extends ChromeActivity<C> { extends ChromeActivity<C> {
private static final int PREWARM_RENDERER_DELAY_MS = 500;
protected static final String BUNDLE_TAB_ID = "tabId"; protected static final String BUNDLE_TAB_ID = "tabId";
@Override @Override
...@@ -136,31 +129,4 @@ public abstract class SingleTabActivity<C extends ChromeActivityComponent> ...@@ -136,31 +129,4 @@ public abstract class SingleTabActivity<C extends ChromeActivityComponent>
@Override @Override
public void onUpdateStateChanged() {} public void onUpdateStateChanged() {}
@Override
public void onStopWithNative() {
super.onStopWithNative();
if (CommandLine.getInstance().hasSwitch(ChromeSwitches.AGGRESSIVELY_PREWARM_RENDERERS)) {
PostTask.postDelayedTask(UiThreadTaskTraits.DEFAULT, new Runnable() {
@Override
public void run() {
// If we're not still stopped, we don't need the spare WebContents.
if (ApplicationStatus.getStateForActivity(SingleTabActivity.this)
== ActivityState.STOPPED) {
WarmupManager.getInstance().createSpareWebContents(!WarmupManager.FOR_CCT);
}
}
}, PREWARM_RENDERER_DELAY_MS);
}
}
@Override
public void onTrimMemory(int level) {
super.onTrimMemory(level);
if (CommandLine.getInstance().hasSwitch(ChromeSwitches.AGGRESSIVELY_PREWARM_RENDERERS)) {
if (ChromeApplication.isSevereMemorySignal(level)) {
WarmupManager.getInstance().destroySpareWebContents();
}
}
}
} }
...@@ -78,12 +78,6 @@ public abstract class ChromeSwitches {{ ...@@ -78,12 +78,6 @@ public abstract class ChromeSwitches {{
*/ */
public static final String DISABLE_TAB_MERGING_FOR_TESTING = "disable-tab-merging"; public static final String DISABLE_TAB_MERGING_FOR_TESTING = "disable-tab-merging";
/**
* Aggressively pre-warms renderers when Chrome is backgrounded. Currently only works for
* SingleTabActivity-derived Activities.
*/
public static final String AGGRESSIVELY_PREWARM_RENDERERS = "aggressively-prewarm-renderers";
/////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////
// Native Switches // Native Switches
/////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment