Commit b7828210 authored by hans@chromium.org's avatar hans@chromium.org

Disable exceptions on Windows in all builds (take 3)

They were previously enabled in shared_library builds for historical reasons.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Previous attemps failed due to:
- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/420593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285458 0039d316-1c4b-4281-b951-d872f2087c98
parent 6790ebc2
......@@ -5139,6 +5139,8 @@
'CERT_CHAIN_PARA_HAS_EXTRA_FIELDS',
'WIN32_LEAN_AND_MEAN',
'_ATL_NO_OPENGL',
# _HAS_EXCEPTIONS must match ExceptionHandling in msvs_settings.
'_HAS_EXCEPTIONS=0',
],
'conditions': [
['buildtype=="Official"', {
......@@ -5206,11 +5208,6 @@
],
},
],
['component=="static_library"', {
'defines': [
'_HAS_EXCEPTIONS=0',
],
}],
['secure_atl', {
'defines': [
'_SECURE_ATL',
......@@ -5293,13 +5290,8 @@
'WarningLevel': '4',
'WarnAsError': 'true',
'DebugInformationFormat': '3',
'conditions': [
['component=="shared_library"', {
'ExceptionHandling': '1', # /EHsc
}, {
# ExceptionHandling must match _HAS_EXCEPTIONS above.
'ExceptionHandling': '0',
}],
],
},
'VCLibrarianTool': {
'AdditionalOptions': ['/ignore:4221'],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment