Commit b7e03360 authored by Yuta Kitamura's avatar Yuta Kitamura Committed by Commit Bot

Rename MockRendererScheduler to WebMockThreadScheduler.

This CL renames the class MockRendererScheduler which is the mock of
WebThreadScheduler, formerly named RendererScheduler, so it would match
the current name of its parent class and follow the naming convention
for Blink public classes (starting with "Web").

Bug: 826203
Change-Id: Ibda5282749e1379b053ff27bb03b9140fa124f37
Reviewed-on: https://chromium-review.googlesource.com/c/1328547Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607160}
parent 115dc0aa
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
#include "content/renderer/input/main_thread_event_queue.h" #include "content/renderer/input/main_thread_event_queue.h"
#include "content/renderer/render_thread_impl.h" #include "content/renderer/render_thread_impl.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h" #include "third_party/blink/public/platform/scheduler/test/web_mock_thread_scheduler.h"
using blink::WebInputEvent; using blink::WebInputEvent;
using blink::WebMouseEvent; using blink::WebMouseEvent;
...@@ -158,7 +158,7 @@ class MainThreadEventQueueTest : public testing::Test, ...@@ -158,7 +158,7 @@ class MainThreadEventQueueTest : public testing::Test,
void SetUp() override { void SetUp() override {
queue_ = new MainThreadEventQueue(this, main_task_runner_, queue_ = new MainThreadEventQueue(this, main_task_runner_,
&renderer_scheduler_, true); &thread_scheduler_, true);
queue_->set_use_raf_fallback_timer(false); queue_->set_use_raf_fallback_timer(false);
} }
...@@ -234,7 +234,7 @@ class MainThreadEventQueueTest : public testing::Test, ...@@ -234,7 +234,7 @@ class MainThreadEventQueueTest : public testing::Test,
protected: protected:
scoped_refptr<base::TestSimpleTaskRunner> main_task_runner_; scoped_refptr<base::TestSimpleTaskRunner> main_task_runner_;
blink::scheduler::MockRendererScheduler renderer_scheduler_; blink::scheduler::WebMockThreadScheduler thread_scheduler_;
scoped_refptr<MainThreadEventQueue> queue_; scoped_refptr<MainThreadEventQueue> queue_;
std::vector<std::unique_ptr<HandledTask>> handled_tasks_; std::vector<std::unique_ptr<HandledTask>> handled_tasks_;
std::unique_ptr<HandledEventCallbackTracker> handler_callback_; std::unique_ptr<HandledEventCallbackTracker> handler_callback_;
...@@ -256,7 +256,7 @@ TEST_F(MainThreadEventQueueTest, NonBlockingWheel) { ...@@ -256,7 +256,7 @@ TEST_F(MainThreadEventQueueTest, NonBlockingWheel) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -342,7 +342,7 @@ TEST_F(MainThreadEventQueueTest, NonBlockingWheel) { ...@@ -342,7 +342,7 @@ TEST_F(MainThreadEventQueueTest, NonBlockingWheel) {
} }
TEST_F(MainThreadEventQueueTest, NonBlockingTouch) { TEST_F(MainThreadEventQueueTest, NonBlockingTouch) {
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -447,7 +447,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouch) { ...@@ -447,7 +447,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouch) {
kEvents[3].PressPoint(10, 10); kEvents[3].PressPoint(10, 10);
kEvents[3].MovePoint(0, 35, 35); kEvents[3].MovePoint(0, 35, 35);
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
{ {
...@@ -501,7 +501,7 @@ TEST_F(MainThreadEventQueueTest, InterleavedEvents) { ...@@ -501,7 +501,7 @@ TEST_F(MainThreadEventQueueTest, InterleavedEvents) {
kTouchEvents[1].PressPoint(10, 10); kTouchEvents[1].PressPoint(10, 10);
kTouchEvents[1].MovePoint(0, 30, 30); kTouchEvents[1].MovePoint(0, 30, 30);
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -572,7 +572,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedMouseInput) { ...@@ -572,7 +572,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedMouseInput) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -644,7 +644,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInput) { ...@@ -644,7 +644,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInput) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
...@@ -718,7 +718,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputCoalescedMoves) { ...@@ -718,7 +718,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputCoalescedMoves) {
kEvents[1].MovePoint(0, 20, 20); kEvents[1].MovePoint(0, 20, 20);
kEvents[0].dispatch_type = WebInputEvent::kEventNonBlocking; kEvents[0].dispatch_type = WebInputEvent::kEventNonBlocking;
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(4); .Times(4);
...@@ -781,7 +781,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputCoalescedMoves) { ...@@ -781,7 +781,7 @@ TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputCoalescedMoves) {
} }
TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputThrottlingMoves) { TEST_F(MainThreadEventQueueTest, RafAlignedTouchInputThrottlingMoves) {
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
...@@ -836,7 +836,7 @@ TEST_F(MainThreadEventQueueTest, LowLatency) { ...@@ -836,7 +836,7 @@ TEST_F(MainThreadEventQueueTest, LowLatency) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -904,7 +904,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchesDuringFling) { ...@@ -904,7 +904,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchesDuringFling) {
kEvents.touch_start_or_first_touch_move = true; kEvents.touch_start_or_first_touch_move = true;
set_enable_fling_passive_listener_flag(true); set_enable_fling_passive_listener_flag(true);
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(4); .Times(4);
...@@ -992,7 +992,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchesOutsideFling) { ...@@ -992,7 +992,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchesOutsideFling) {
kEvents.touch_start_or_first_touch_move = true; kEvents.touch_start_or_first_touch_move = true;
set_enable_fling_passive_listener_flag(false); set_enable_fling_passive_listener_flag(false);
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(4); .Times(4);
...@@ -1089,7 +1089,7 @@ class MainThreadEventQueueInitializationTest ...@@ -1089,7 +1089,7 @@ class MainThreadEventQueueInitializationTest
protected: protected:
scoped_refptr<MainThreadEventQueue> queue_; scoped_refptr<MainThreadEventQueue> queue_;
blink::scheduler::MockRendererScheduler renderer_scheduler_; blink::scheduler::WebMockThreadScheduler thread_scheduler_;
scoped_refptr<base::TestSimpleTaskRunner> main_task_runner_; scoped_refptr<base::TestSimpleTaskRunner> main_task_runner_;
}; };
...@@ -1121,7 +1121,7 @@ TEST_F(MainThreadEventQueueTest, QueuingClosureWithRafEvent) { ...@@ -1121,7 +1121,7 @@ TEST_F(MainThreadEventQueueTest, QueuingClosureWithRafEvent) {
EXPECT_TRUE(main_task_runner_->HasPendingTask()); EXPECT_TRUE(main_task_runner_->HasPendingTask());
EXPECT_FALSE(needs_main_frame_); EXPECT_FALSE(needs_main_frame_);
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(2); .Times(2);
...@@ -1165,7 +1165,7 @@ TEST_F(MainThreadEventQueueTest, QueuingClosuresBetweenEvents) { ...@@ -1165,7 +1165,7 @@ TEST_F(MainThreadEventQueueTest, QueuingClosuresBetweenEvents) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(2); .Times(2);
...@@ -1206,7 +1206,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchMoveBecomesNonBlocking) { ...@@ -1206,7 +1206,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchMoveBecomesNonBlocking) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
EXPECT_EQ(WebInputEvent::kBlocking, kEvents[0].dispatch_type); EXPECT_EQ(WebInputEvent::kBlocking, kEvents[0].dispatch_type);
...@@ -1251,7 +1251,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchMoveWithTouchEnd) { ...@@ -1251,7 +1251,7 @@ TEST_F(MainThreadEventQueueTest, BlockingTouchMoveWithTouchEnd) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
EXPECT_EQ(WebInputEvent::kBlocking, kEvents[0].dispatch_type); EXPECT_EQ(WebInputEvent::kBlocking, kEvents[0].dispatch_type);
...@@ -1289,7 +1289,7 @@ TEST_F(MainThreadEventQueueTest, UnbufferedDispatchTouchEvent) { ...@@ -1289,7 +1289,7 @@ TEST_F(MainThreadEventQueueTest, UnbufferedDispatchTouchEvent) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(3); .Times(3);
...@@ -1351,7 +1351,7 @@ TEST_F(MainThreadEventQueueTest, PointerRawMoveEvents) { ...@@ -1351,7 +1351,7 @@ TEST_F(MainThreadEventQueueTest, PointerRawMoveEvents) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
...@@ -1397,7 +1397,7 @@ TEST_F(MainThreadEventQueueTest, UnbufferedDispatchMouseEvent) { ...@@ -1397,7 +1397,7 @@ TEST_F(MainThreadEventQueueTest, UnbufferedDispatchMouseEvent) {
EXPECT_FALSE(main_task_runner_->HasPendingTask()); EXPECT_FALSE(main_task_runner_->HasPendingTask());
EXPECT_EQ(0u, event_queue().size()); EXPECT_EQ(0u, event_queue().size());
EXPECT_CALL(renderer_scheduler_, EXPECT_CALL(thread_scheduler_,
DidHandleInputEventOnMainThread(testing::_, testing::_)) DidHandleInputEventOnMainThread(testing::_, testing::_))
.Times(0); .Times(0);
......
...@@ -99,9 +99,9 @@ if (is_android) { ...@@ -99,9 +99,9 @@ if (is_android) {
source_set("test_headers") { source_set("test_headers") {
testonly = true testonly = true
sources = [ sources = [
"platform/scheduler/test/mock_renderer_scheduler.h",
"platform/scheduler/test/renderer_scheduler_test_support.h", "platform/scheduler/test/renderer_scheduler_test_support.h",
"platform/scheduler/test/web_fake_thread_scheduler.h", "platform/scheduler/test/web_fake_thread_scheduler.h",
"platform/scheduler/test/web_mock_thread_scheduler.h",
] ]
deps = [ deps = [
":blink_headers", ":blink_headers",
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_MOCK_RENDERER_SCHEDULER_H_ #ifndef THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_WEB_MOCK_THREAD_SCHEDULER_H_
#define THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_MOCK_RENDERER_SCHEDULER_H_ #define THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_WEB_MOCK_THREAD_SCHEDULER_H_
#include "base/macros.h" #include "base/macros.h"
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
...@@ -16,10 +16,10 @@ ...@@ -16,10 +16,10 @@
namespace blink { namespace blink {
namespace scheduler { namespace scheduler {
class MockRendererScheduler : public WebThreadScheduler { class WebMockThreadScheduler : public WebThreadScheduler {
public: public:
MockRendererScheduler() = default; WebMockThreadScheduler() = default;
~MockRendererScheduler() override = default; ~WebMockThreadScheduler() override = default;
MOCK_METHOD0(DefaultTaskRunner, MOCK_METHOD0(DefaultTaskRunner,
scoped_refptr<base::SingleThreadTaskRunner>()); scoped_refptr<base::SingleThreadTaskRunner>());
...@@ -65,10 +65,10 @@ class MockRendererScheduler : public WebThreadScheduler { ...@@ -65,10 +65,10 @@ class MockRendererScheduler : public WebThreadScheduler {
MOCK_METHOD0(OnMainFrameRequestedForInput, void()); MOCK_METHOD0(OnMainFrameRequestedForInput, void());
private: private:
DISALLOW_COPY_AND_ASSIGN(MockRendererScheduler); DISALLOW_COPY_AND_ASSIGN(WebMockThreadScheduler);
}; };
} // namespace scheduler } // namespace scheduler
} // namespace blink } // namespace blink
#endif // THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_MOCK_RENDERER_SCHEDULER_H_ #endif // THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_TEST_WEB_MOCK_THREAD_SCHEDULER_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment