Commit b89dd522 authored by Anand K. Mistry's avatar Anand K. Mistry Committed by Commit Bot

[Extensions Functions] Migrate downloads API to ExtensionFunction

Bug: 634140
Change-Id: I01af9fec6cdce911b2111bdebcb6a8ac1269d272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066460Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743398}
parent 91e8d762
...@@ -14,18 +14,19 @@ ...@@ -14,18 +14,19 @@
#include "base/scoped_observer.h" #include "base/scoped_observer.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "chrome/browser/download/download_danger_prompt.h" #include "chrome/browser/download/download_danger_prompt.h"
#include "chrome/browser/extensions/chrome_extension_function.h"
#include "chrome/common/extensions/api/downloads.h" #include "chrome/common/extensions/api/downloads.h"
#include "components/download/content/public/all_download_item_notifier.h" #include "components/download/content/public/all_download_item_notifier.h"
#include "components/download/public/common/download_path_reservation_tracker.h" #include "components/download/public/common/download_path_reservation_tracker.h"
#include "content/public/browser/download_manager.h" #include "content/public/browser/download_manager.h"
#include "extensions/browser/event_router.h" #include "extensions/browser/event_router.h"
#include "extensions/browser/extension_function.h"
#include "extensions/browser/extension_registry.h" #include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_registry_observer.h" #include "extensions/browser/extension_registry_observer.h"
#include "extensions/browser/warning_set.h" #include "extensions/browser/warning_set.h"
class DownloadFileIconExtractor; class DownloadFileIconExtractor;
class DownloadOpenPrompt; class DownloadOpenPrompt;
class Profile;
// Functions in the chrome.downloads namespace facilitate // Functions in the chrome.downloads namespace facilitate
// controlling downloads from extensions. See the full API doc at // controlling downloads from extensions. See the full API doc at
...@@ -85,11 +86,11 @@ class DownloadedByExtension : public base::SupportsUserData::Data { ...@@ -85,11 +86,11 @@ class DownloadedByExtension : public base::SupportsUserData::Data {
DISALLOW_COPY_AND_ASSIGN(DownloadedByExtension); DISALLOW_COPY_AND_ASSIGN(DownloadedByExtension);
}; };
class DownloadsDownloadFunction : public ChromeAsyncExtensionFunction { class DownloadsDownloadFunction : public ExtensionFunction {
public: public:
DECLARE_EXTENSION_FUNCTION("downloads.download", DOWNLOADS_DOWNLOAD) DECLARE_EXTENSION_FUNCTION("downloads.download", DOWNLOADS_DOWNLOAD)
DownloadsDownloadFunction(); DownloadsDownloadFunction();
bool RunAsync() override; ResponseAction Run() override;
protected: protected:
~DownloadsDownloadFunction() override; ~DownloadsDownloadFunction() override;
...@@ -169,11 +170,11 @@ class DownloadsEraseFunction : public ExtensionFunction { ...@@ -169,11 +170,11 @@ class DownloadsEraseFunction : public ExtensionFunction {
DISALLOW_COPY_AND_ASSIGN(DownloadsEraseFunction); DISALLOW_COPY_AND_ASSIGN(DownloadsEraseFunction);
}; };
class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction { class DownloadsRemoveFileFunction : public ExtensionFunction {
public: public:
DECLARE_EXTENSION_FUNCTION("downloads.removeFile", DOWNLOADS_REMOVEFILE) DECLARE_EXTENSION_FUNCTION("downloads.removeFile", DOWNLOADS_REMOVEFILE)
DownloadsRemoveFileFunction(); DownloadsRemoveFileFunction();
bool RunAsync() override; ResponseAction Run() override;
protected: protected:
~DownloadsRemoveFileFunction() override; ~DownloadsRemoveFileFunction() override;
...@@ -184,7 +185,7 @@ class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction { ...@@ -184,7 +185,7 @@ class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction {
DISALLOW_COPY_AND_ASSIGN(DownloadsRemoveFileFunction); DISALLOW_COPY_AND_ASSIGN(DownloadsRemoveFileFunction);
}; };
class DownloadsAcceptDangerFunction : public ChromeAsyncExtensionFunction { class DownloadsAcceptDangerFunction : public ExtensionFunction {
public: public:
typedef base::Callback<void(DownloadDangerPrompt*)> OnPromptCreatedCallback; typedef base::Callback<void(DownloadDangerPrompt*)> OnPromptCreatedCallback;
static void OnPromptCreatedForTesting( static void OnPromptCreatedForTesting(
...@@ -194,7 +195,7 @@ class DownloadsAcceptDangerFunction : public ChromeAsyncExtensionFunction { ...@@ -194,7 +195,7 @@ class DownloadsAcceptDangerFunction : public ChromeAsyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("downloads.acceptDanger", DOWNLOADS_ACCEPTDANGER) DECLARE_EXTENSION_FUNCTION("downloads.acceptDanger", DOWNLOADS_ACCEPTDANGER)
DownloadsAcceptDangerFunction(); DownloadsAcceptDangerFunction();
bool RunAsync() override; ResponseAction Run() override;
protected: protected:
~DownloadsAcceptDangerFunction() override; ~DownloadsAcceptDangerFunction() override;
...@@ -272,11 +273,11 @@ class DownloadsSetShelfEnabledFunction : public ExtensionFunction { ...@@ -272,11 +273,11 @@ class DownloadsSetShelfEnabledFunction : public ExtensionFunction {
DISALLOW_COPY_AND_ASSIGN(DownloadsSetShelfEnabledFunction); DISALLOW_COPY_AND_ASSIGN(DownloadsSetShelfEnabledFunction);
}; };
class DownloadsGetFileIconFunction : public ChromeAsyncExtensionFunction { class DownloadsGetFileIconFunction : public ExtensionFunction {
public: public:
DECLARE_EXTENSION_FUNCTION("downloads.getFileIcon", DOWNLOADS_GETFILEICON) DECLARE_EXTENSION_FUNCTION("downloads.getFileIcon", DOWNLOADS_GETFILEICON)
DownloadsGetFileIconFunction(); DownloadsGetFileIconFunction();
bool RunAsync() override; ResponseAction Run() override;
void SetIconExtractorForTesting(DownloadFileIconExtractor* extractor); void SetIconExtractorForTesting(DownloadFileIconExtractor* extractor);
protected: protected:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment