GitLab

Improve captive portal test stability

Tests expecting a new popup window (just secure DNS tests) were
expecting the new window to always be the "last active" Browser window,
but that is apparently not the case despite everything appearing to work
correctly with creation of the new popup. Remove checks against
GetLastActive().

Also fix cases where it was assumed GetLastActive() could be used as a
shortcut to retrieve the popup window. Instead the code for validating
creation of the popup window can optionally return a pointer to the
created window.

Bug: 11139282
Change-Id: Ic900d0deb881eacc53099de07c5e8cdd68b39be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606525
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840215}