Skip to content

GitLab

T
tangled
Commit b99c852b authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot
Browse files
Options

[css-grid] Migrate flex-and-minmax-content-resolution-rows to WPT 

Migrate this test out of blink/web_tests/fast/css-grid-layout
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Additionally, migrate this test from being a testRunner-based reftest
with plain text expectation into a testharness.js-based test that uses
check-layout-th.js instead of the utils from the Chromium-specific
check-layout.js file, and drop the expectations file.

Bug: 767015, 1063749
Change-Id: I3a056716ec99f979b9171aaa2a1e053f9f782e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144188
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: default avatarManuel Rego <rego@igalia.com>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758790}
parent bcc921ca
Show whitespace changes
Inline Side-by-side
Showing with 18 additions and 61 deletions
third_party/blink/web_tests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html → third_party/blink/web_tests/external/wpt/css/css-grid/grid-definition/flex-and-minmax-content-resolution-rows-001.html
View file @ b99c852b
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<link href="resources/grid.css" rel="stylesheet"> <title>CSS Grid Layout Test: Auto repeat tracks, grid-template-rows and minmax sizes.</title>
<link rel="author" title="Julien Chaffraix" href="mailto:jchaffraix@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#track-sizes">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#fr-unit">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=235258">
<link rel="stylesheet" href="/fonts/ahem.css">
<link rel="stylesheet" href="/css/support/grid.css">
<meta name="assert" content="Test that resolving auto tracks on grid items inside containers using minmax() with grid-template-rows works properly." />
<style> <style>
.gridMaxMaxContent { .gridMaxMaxContent {
grid-template-columns: 50px; grid-template-columns: 50px;
...@@ -36,8 +44,15 @@ ...@@ -36,8 +44,15 @@
grid-row: 4; grid-row: 4;
} }
</style> </style>
<script src="../../resources/check-layout.js"></script>
<body onload="checkLayout('.grid');"> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/check-layout-th.js"></script>
<script type="text/javascript">
setup({ explicit_done: true });
</script>
<body onload="document.fonts.ready.then(() => { checkLayout('.grid'); })">
<p>Test that resolving auto tracks on grid items works properly.</p> <p>Test that resolving auto tracks on grid items works properly.</p>
......
third_party/blink/web_tests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt deleted 100644 → 0
View file @ bcc921ca
Test that resolving auto tracks on grid items works properly.
XXXXX
PASS
XXXXX
PASS
XXXXX
PASS
XXXXX
PASS
XXXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXX
XXXXX XXXX
PASS
XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
XXXXX XXXXX XXXXX XXXXX
XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX
PASS
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment