arc: Start arc-host-clock-service for ARCVM

BUG=b:166087457
TEST=Login

Change-Id: Ic135bf97543c755686fe40ad7219cd02aaa8f9bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392187Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805617}

components/arc/session/arc_vm_client_adapter.cc

@@ -59,6 +59,8 @@ namespace {
 // that aren't valid in D-Bus object paths with underscore followed by its
 // ascii code in hex. So "arc_2dcreate_2ddata" becomes "arc-create-data".
 constexpr const char kArcCreateDataJobName[] = "arc_2dcreate_2ddata";
+constexpr const char kArcHostClockServiceJobName[] =
+    "arc_2dhost_2dclock_2dservice";
 constexpr const char kArcKeymasterJobName[] = "arc_2dkeymasterd";
 constexpr const char kArcSensorServiceJobName[] = "arc_2dsensor_2dservice";
 constexpr const char kArcVmMountMyFilesJobName[] = "arcvm_2dmount_2dmyfiles";
@@ -604,6 +606,9 @@ class ArcVmClientAdapter : public ArcClientAdapter,
         JobDesc{kArcKeymasterJobName, UpstartOperation::JOB_STOP_AND_START, {}},
         JobDesc{
             kArcSensorServiceJobName, UpstartOperation::JOB_STOP_AND_START, {}},
+        JobDesc{kArcHostClockServiceJobName,
+                UpstartOperation::JOB_STOP_AND_START,
+                {}},
         JobDesc{kArcVmBootNotificationServerJobName,
                 UpstartOperation::JOB_STOP_AND_START,
                 {}},

components/arc/session/arc_vm_client_adapter_unittest.cc

@@ -43,6 +43,8 @@ namespace arc {
 namespace {
 
 constexpr const char kArcCreateDataJobName[] = "arc_2dcreate_2ddata";
+constexpr const char kArcHostClockServiceJobName[] =
+    "arc_2dhost_2dclock_2dservice";
 constexpr const char kArcKeymasterJobName[] = "arc_2dkeymasterd";
 constexpr const char kArcSensorServiceJobName[] = "arc_2dsensor_2dservice";
 constexpr const char kArcVmMountMyFilesJobName[] = "arcvm_2dmount_2dmyfiles";
@@ -531,6 +533,28 @@ TEST_F(ArcVmClientAdapterTest, StartMiniArc_StopArcVmServerProxyJobFail) {
   // for other StartMiniArc_...Fail tests.
 }
 
+// Tests that StartMiniArc() fails if Upstart fails to start
+// arc-host-clock-service.
+TEST_F(ArcVmClientAdapterTest, StartMiniArc_StartArcHostClockServiceJobFail) {
+  // Inject failure to FakeUpstartClient.
+  InjectUpstartStartJobFailure(kArcHostClockServiceJobName);
+
+  StartMiniArcWithParams(false, {});
+  // Confirm that no VM is started. ARCVM doesn't support mini ARC yet.
+  EXPECT_FALSE(GetTestConciergeClient()->start_arc_vm_called());
+}
+
+// Tests that StartMiniArc() succeeds if Upstart fails to stop
+// arc-host-clock-service.
+TEST_F(ArcVmClientAdapterTest, StartMiniArc_StopArcHostClockServiceJobFail) {
+  // Inject failure to FakeUpstartClient.
+  InjectUpstartStopJobFailure(kArcHostClockServiceJobName);
+
+  StartMiniArc();
+  // Confirm that no VM is started. ARCVM doesn't support mini ARC yet.
+  EXPECT_FALSE(GetTestConciergeClient()->start_arc_vm_called());
+}
+
 // Tests that StartMiniArc() fails if Upstart fails to start arc-keymasterd.
 TEST_F(ArcVmClientAdapterTest, StartMiniArc_StartArcKeymasterJobFail) {
   // Inject failure to FakeUpstartClient.