Commit ba6240bf authored by Melissa Zhang's avatar Melissa Zhang Committed by Commit Bot

[Sharesheet] Add flag for sharesheet.

This CL adds a feature flag for enabling the sharesheet on desktop
platforms.

Bug: 1097623
Change-Id: I5a99db0ed041b3669046a900ad3bedfbbb3f57fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256941Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781673}
parent 3f6cd172
...@@ -5733,6 +5733,12 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -5733,6 +5733,12 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAutofillEnableOffersInDownstreamDescription, kOsAll, flag_descriptions::kAutofillEnableOffersInDownstreamDescription, kOsAll,
FEATURE_VALUE_TYPE(autofill::features::kAutofillEnableOffersInDownstream)}, FEATURE_VALUE_TYPE(autofill::features::kAutofillEnableOffersInDownstream)},
#if defined(OS_CHROMEOS)
{"enable-sharesheet", flag_descriptions::kSharesheetName,
flag_descriptions::kSharesheetDescription, kOsAll,
FEATURE_VALUE_TYPE(features::kSharesheet)},
#endif // OS_CHROMEOS
// NOTE: Adding a new flag requires adding a corresponding entry to enum // NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the // Histograms" in tools/metrics/histograms/README.md (run the
......
...@@ -2122,6 +2122,11 @@ ...@@ -2122,6 +2122,11 @@
"owners": [ "falken", "shimazu", "//content/browser/service_worker/OWNERS" ], "owners": [ "falken", "shimazu", "//content/browser/service_worker/OWNERS" ],
"expiry_milestone": 87 "expiry_milestone": 87
}, },
{
"name": "enable-sharesheet",
"owners": [ "chromeos-apps-foundation-team@google.com" ],
"expiry_milestone": 89
},
{ {
"name": "enable-sharing-device-registration", "name": "enable-sharing-device-registration",
"owners": [ "//chrome/browser/sharing/OWNERS" ], "owners": [ "//chrome/browser/sharing/OWNERS" ],
......
...@@ -3864,6 +3864,9 @@ const char kSchedulerConfigurationConservative[] = ...@@ -3864,6 +3864,9 @@ const char kSchedulerConfigurationConservative[] =
const char kSchedulerConfigurationPerformance[] = const char kSchedulerConfigurationPerformance[] =
"Enables Hyper-Threading on relevant CPUs."; "Enables Hyper-Threading on relevant CPUs.";
const char kSharesheetName[] = "Sharesheet";
const char kSharesheetDescription[] = "Chrome OS sharesheet.";
const char kShowBluetoothDebugLogToggleName[] = const char kShowBluetoothDebugLogToggleName[] =
"Show Bluetooth debug log toggle"; "Show Bluetooth debug log toggle";
const char kShowBluetoothDebugLogToggleDescription[] = const char kShowBluetoothDebugLogToggleDescription[] =
......
...@@ -2269,6 +2269,9 @@ extern const char kSchedulerConfigurationDescription[]; ...@@ -2269,6 +2269,9 @@ extern const char kSchedulerConfigurationDescription[];
extern const char kSchedulerConfigurationConservative[]; extern const char kSchedulerConfigurationConservative[];
extern const char kSchedulerConfigurationPerformance[]; extern const char kSchedulerConfigurationPerformance[];
extern const char kSharesheetName[];
extern const char kSharesheetDescription[];
extern const char kShowBluetoothDebugLogToggleName[]; extern const char kShowBluetoothDebugLogToggleName[];
extern const char kShowBluetoothDebugLogToggleDescription[]; extern const char kShowBluetoothDebugLogToggleDescription[];
......
...@@ -606,6 +606,11 @@ const base::Feature kRemoveSupervisedUsersOnStartup{ ...@@ -606,6 +606,11 @@ const base::Feature kRemoveSupervisedUsersOnStartup{
const base::Feature kSecurityKeyAttestationPrompt{ const base::Feature kSecurityKeyAttestationPrompt{
"SecurityKeyAttestationPrompt", base::FEATURE_ENABLED_BY_DEFAULT}; "SecurityKeyAttestationPrompt", base::FEATURE_ENABLED_BY_DEFAULT};
#if defined(OS_CHROMEOS)
const base::Feature kSharesheet{"Sharesheet",
base::FEATURE_DISABLED_BY_DEFAULT};
#endif
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
const base::Feature kShowTrustedPublisherURL{"ShowTrustedPublisherURL", const base::Feature kShowTrustedPublisherURL{"ShowTrustedPublisherURL",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
......
...@@ -385,6 +385,11 @@ extern const base::Feature kRemoveSupervisedUsersOnStartup; ...@@ -385,6 +385,11 @@ extern const base::Feature kRemoveSupervisedUsersOnStartup;
COMPONENT_EXPORT(CHROME_FEATURES) COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kSecurityKeyAttestationPrompt; extern const base::Feature kSecurityKeyAttestationPrompt;
#if defined(OS_CHROMEOS)
COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kSharesheet;
#endif
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
COMPONENT_EXPORT(CHROME_FEATURES) COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kShowTrustedPublisherURL; extern const base::Feature kShowTrustedPublisherURL;
......
...@@ -40198,6 +40198,7 @@ from previous Chrome versions. ...@@ -40198,6 +40198,7 @@ from previous Chrome versions.
<int value="-1045882995" label="UseNewDoodleApi:enabled"/> <int value="-1045882995" label="UseNewDoodleApi:enabled"/>
<int value="-1044244605" <int value="-1044244605"
label="UpdateNotificationSchedulingIntegration:enabled"/> label="UpdateNotificationSchedulingIntegration:enabled"/>
<int value="-1043883835" label="Sharesheet:enabled"/>
<int value="-1042723808" <int value="-1042723808"
label="HappinessTrackingSurveysForDesktopSettingsPrivacy:enabled"/> label="HappinessTrackingSurveysForDesktopSettingsPrivacy:enabled"/>
<int value="-1042579955" label="ChromeOSParentalControlsSettings:enabled"/> <int value="-1042579955" label="ChromeOSParentalControlsSettings:enabled"/>
...@@ -40720,6 +40721,7 @@ from previous Chrome versions. ...@@ -40720,6 +40721,7 @@ from previous Chrome versions.
label="AutofillUpstreamEditableExpirationDate:enabled"/> label="AutofillUpstreamEditableExpirationDate:enabled"/>
<int value="-468697885" label="ArcInputMethod:enabled"/> <int value="-468697885" label="ArcInputMethod:enabled"/>
<int value="-466704882" label="webview-log-js-console-messages"/> <int value="-466704882" label="webview-log-js-console-messages"/>
<int value="-465381408" label="Sharesheet:disabled"/>
<int value="-462554210" <int value="-462554210"
label="OminboxUIExperimentUseGenericSearchEngineIcon:enabled"/> label="OminboxUIExperimentUseGenericSearchEngineIcon:enabled"/>
<int value="-462404204" label="CryptAuthV2DeviceSync:disabled"/> <int value="-462404204" label="CryptAuthV2DeviceSync:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment