Skip to content

GitLab

T
tangled
Commit ba6debf8 authored by Alexandre Frechette's avatar Alexandre Frechette Committed by Commit Bot
Browse files
Options

Disabling flaky installer_util_unittests. 

TBR=ganesh@chromium.org

Bug: 1058506
Change-Id: I3f10b57b4ae355714514bfef225536316ec408e8
Tbr: ganesh@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088019
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: default avatarAlexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746944}
parent 9b94c2c0
Show whitespace changes
Inline Side-by-side
Showing with 10 additions and 9 deletions
chrome/installer/util/install_service_work_item_unittest.cc
View file @ ba6debf8
...@@ -64,8 +64,8 @@ TEST_F(InstallServiceWorkItemTest, Do_MultiSzToVector) { ...@@ -64,8 +64,8 @@ TEST_F(InstallServiceWorkItemTest, Do_MultiSzToVector) {
EXPECT_EQ(vec.size(), base::size(kMultiSz)); EXPECT_EQ(vec.size(), base::size(kMultiSz));
} }
// This test is flaky, see https://crbug.com/1055470 // This test is flaky, see https://crbug.com/1058506
TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) { TEST_F(InstallServiceWorkItemTest, DISABLED_Do_FreshInstall) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -78,8 +78,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) { ...@@ -78,8 +78,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstall) {
EXPECT_FALSE(GetImpl(item.get())->OpenService()); EXPECT_FALSE(GetImpl(item.get())->OpenService());
} }
// This test is flaky, see https://crbug.com/1055470 // This test is flaky, see https://crbug.com/1058506
TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) { TEST_F(InstallServiceWorkItemTest, DISABLED_Do_FreshInstallThenDeleteService) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -91,8 +91,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) { ...@@ -91,8 +91,8 @@ TEST_F(InstallServiceWorkItemTest, Do_FreshInstallThenDeleteService) {
EXPECT_TRUE(InstallServiceWorkItem::DeleteService(kServiceName)); EXPECT_TRUE(InstallServiceWorkItem::DeleteService(kServiceName));
} }
// This test is flaky, see https://crbug.com/1055470 // This test is flaky, see https://crbug.com/1058506
TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) { TEST_F(InstallServiceWorkItemTest, DISABLED_Do_UpgradeNoChanges) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -112,8 +112,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) { ...@@ -112,8 +112,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeNoChanges) {
EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService()); EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService());
} }
// This test is flaky, see https://crbug.com/1055470 // This test is flaky, see https://crbug.com/1058506
TEST_F(InstallServiceWorkItemTest, Do_UpgradeChangedCmdLine) { TEST_F(InstallServiceWorkItemTest, DISABLED_Do_UpgradeChangedCmdLine) {
auto item = std::make_unique<InstallServiceWorkItem>( auto item = std::make_unique<InstallServiceWorkItem>(
kServiceName, kServiceDisplayName, kServiceName, kServiceDisplayName,
base::CommandLine(base::FilePath(kServiceProgramPath))); base::CommandLine(base::FilePath(kServiceProgramPath)));
...@@ -136,7 +136,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeChangedCmdLine) { ...@@ -136,7 +136,8 @@ TEST_F(InstallServiceWorkItemTest, Do_UpgradeChangedCmdLine) {
EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService()); EXPECT_TRUE(GetImpl(item_upgrade.get())->DeleteCurrentService());
} }
TEST_F(InstallServiceWorkItemTest, Do_ServiceName) { // This test is flaky, see https://crbug.com/1058506
TEST_F(InstallServiceWorkItemTest, DISABLED_Do_ServiceName) {
base::win::RegKey key; base::win::RegKey key;
ASSERT_EQ(ERROR_SUCCESS, ASSERT_EQ(ERROR_SUCCESS,
key.Create(HKEY_LOCAL_MACHINE, key.Create(HKEY_LOCAL_MACHINE,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment