Modernize SyncNotificationController

This CL attempts to make the implementation of this class clearer via
some renames, added comments and other minor changes. Some related code
in SyncSettingsUtils is also touched:
- Rename SyncSettingsUtils.getMessageId() to make it clear the
returned value is the same as the sync status summary used in settings,
only restricted to the special case of auth errors. The signature is
also made more consistent with other methods in the same file.
- Use Context.getString() consistently in getSyncStatusSummary(), rather
than alternate between this and Resources.getString().
- Add more protective code to getSyncStatusSummaryForAuthError(). The
method now guards against the case of no error, or an unknown auth error
being passed. This doesn't influence any of the existing callsites.

Bug: None
Change-Id: I30dd52d2a3af66cc62e2037bc94bd1738f109766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632751
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846036}

chrome/android/java/src/org/chromium/chrome/browser/sync/settings/SyncSettingsUtils.java

@@ -7,14 +7,12 @@ import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentSender;
-import android.content.res.Resources;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;
 import android.provider.Browser;
 
 import androidx.annotation.IntDef;
 import androidx.annotation.Nullable;
-import androidx.annotation.StringRes;
 import androidx.appcompat.content.res.AppCompatResources;
 import androidx.browser.customtabs.CustomTabsIntent;
 import androidx.fragment.app.Fragment;
@@ -182,87 +180,65 @@ public class SyncSettingsUtils {
         }
     }
 
-    /**
-     * Gets the corresponding message id of a given {@link GoogleServiceAuthError.State}.
-     */
-    public static @StringRes int getMessageID(@GoogleServiceAuthError.State int state) {
-        switch (state) {
-            case GoogleServiceAuthError.State.INVALID_GAIA_CREDENTIALS:
-                return R.string.sync_error_ga;
-            case GoogleServiceAuthError.State.CONNECTION_FAILED:
-                return R.string.sync_error_connection;
-            case GoogleServiceAuthError.State.SERVICE_UNAVAILABLE:
-                return R.string.sync_error_service_unavailable;
-            // case State.NONE:
-            // case State.REQUEST_CANCELED:
-            // case State.UNEXPECTED_SERVICE_RESPONSE:
-            // case State.SERVICE_ERROR:
-            default:
-                return R.string.sync_error_generic;
-        }
-    }
-
     /**
      * Return a short summary of the current sync status.
      * TODO(https://crbug.com/1129930): Refactor this method
      */
     public static String getSyncStatusSummary(Context context) {
-        Resources res = context.getResources();
-
         if (!IdentityServicesProvider.get()
                         .getIdentityManager(Profile.getLastUsedRegularProfile())
                         .hasPrimaryAccount()) {
             if (ChromeFeatureList.isEnabled(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)) {
                 // There is no account with sync consent available.
-                return res.getString(R.string.sync_is_disabled);
+                return context.getString(R.string.sync_is_disabled);
             }
             return "";
         }
 
         ProfileSyncService profileSyncService = ProfileSyncService.get();
         if (profileSyncService == null) {
-            return res.getString(R.string.sync_is_disabled);
+            return context.getString(R.string.sync_is_disabled);
         }
 
         if (!profileSyncService.isSyncAllowedByPlatform()) {
-            return res.getString(R.string.sync_android_system_sync_disabled);
+            return context.getString(R.string.sync_android_system_sync_disabled);
         }
 
         if (profileSyncService.isSyncDisabledByEnterprisePolicy()) {
-            return res.getString(R.string.sync_is_disabled_by_administrator);
+            return context.getString(R.string.sync_is_disabled_by_administrator);
         }
 
         if (!profileSyncService.isFirstSetupComplete()) {
             return ChromeFeatureList.isEnabled(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
-                    ? res.getString(R.string.sync_settings_not_confirmed)
-                    : res.getString(R.string.sync_settings_not_confirmed_legacy);
+                    ? context.getString(R.string.sync_settings_not_confirmed)
+                    : context.getString(R.string.sync_settings_not_confirmed_legacy);
         }
 
         if (profileSyncService.getAuthError() != GoogleServiceAuthError.State.NONE) {
-            return res.getString(getMessageID(profileSyncService.getAuthError()));
+            return getSyncStatusSummaryForAuthError(context, profileSyncService.getAuthError());
         }
 
         if (profileSyncService.requiresClientUpgrade()) {
-            return res.getString(
+            return context.getString(
                     R.string.sync_error_upgrade_client, BuildInfo.getInstance().hostPackageLabel);
         }
 
         if (profileSyncService.hasUnrecoverableError()) {
-            return res.getString(R.string.sync_error_generic);
+            return context.getString(R.string.sync_error_generic);
         }
 
         if (!profileSyncService.isSyncRequested()) {
             return ChromeFeatureList.isEnabled(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
-                    ? res.getString(R.string.sync_data_types_off)
+                    ? context.getString(R.string.sync_data_types_off)
                     : context.getString(R.string.sync_is_disabled);
         }
 
         if (!profileSyncService.isSyncActive()) {
-            return res.getString(R.string.sync_setup_progress);
+            return context.getString(R.string.sync_setup_progress);
         }
 
         if (profileSyncService.isPassphraseRequiredForPreferredDataTypes()) {
-            return res.getString(R.string.sync_need_passphrase);
+            return context.getString(R.string.sync_need_passphrase);
         }
 
         if (profileSyncService.isTrustedVaultKeyRequiredForPreferredDataTypes()) {
@@ -274,6 +250,33 @@ public class SyncSettingsUtils {
         return context.getString(R.string.sync_and_services_summary_sync_on);
     }
 
+    /**
+     * Gets the sync status summary for a given {@link GoogleServiceAuthError.State}.
+     * @param context The application context, used by the method to get string resources.
+     * @param state Must not be GoogleServiceAuthError.State.None.
+     */
+    public static String getSyncStatusSummaryForAuthError(
+            Context context, @GoogleServiceAuthError.State int state) {
+        switch (state) {
+            case GoogleServiceAuthError.State.INVALID_GAIA_CREDENTIALS:
+                return context.getString(R.string.sync_error_ga);
+            case GoogleServiceAuthError.State.CONNECTION_FAILED:
+                return context.getString(R.string.sync_error_connection);
+            case GoogleServiceAuthError.State.SERVICE_UNAVAILABLE:
+                return context.getString(R.string.sync_error_service_unavailable);
+            case GoogleServiceAuthError.State.REQUEST_CANCELED:
+            case GoogleServiceAuthError.State.UNEXPECTED_SERVICE_RESPONSE:
+            case GoogleServiceAuthError.State.SERVICE_ERROR:
+                return context.getString(R.string.sync_error_generic);
+            case GoogleServiceAuthError.State.NONE:
+                assert false : "No summary if there's no auth error";
+                return "";
+            default:
+                assert false : "Unknown auth error state";
+                return "";
+        }
+    }
+
     /**
      * Returns an icon that represents the current sync state.
      */