Commit bb3da314 authored by Vaclav Brozek's avatar Vaclav Brozek Committed by Commit Bot

Output AutofillField::server_type() in password internals

Currently, chrome://password-manager-internals shows
AutofillField::Type() as server predictions. This is not completely
accurate, because Type() comes from multiple sources, and actually, it
is AutofillField::server_type() which is passed to the password form
parser as server predictions.

Therefore this CL changes the internals page to output server_type()
instead.

Bug: 855987
Change-Id: Ib4bf8cdcbca21ee38450d6d0a0026dd2da71b2e5
Reviewed-on: https://chromium-review.googlesource.com/1114850Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570784}
parent da716cb0
...@@ -139,8 +139,11 @@ std::string BrowserSavePasswordProgressLogger::FormStructureToFieldsLogString( ...@@ -139,8 +139,11 @@ std::string BrowserSavePasswordProgressLogger::FormStructureToFieldsLogString(
field_info += field_info +=
", autocomplete=" + ScrubElementID(field->autocomplete_attribute); ", autocomplete=" + ScrubElementID(field->autocomplete_attribute);
if (!field->Type().IsUnknown()) if (field->server_type() != autofill::NO_SERVER_DATA) {
field_info += ", SERVER_PREDICTION: " + field->Type().ToString(); field_info +=
", SERVER_PREDICTION: " +
autofill::AutofillType::ServerFieldTypeToString(field->server_type());
}
for (autofill::ServerFieldType type : field->possible_types()) for (autofill::ServerFieldType type : field->possible_types())
field_info += field_info +=
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment