Commit bbb00164 authored by Alexey Kozyatinskiy's avatar Alexey Kozyatinskiy Committed by Commit Bot

[DevTools] unskip couple tests

The related CLs on V8 side were not landed.

TBR=lushnikov@chromium.org

Bug: chromium:595206,v8:7753,v8:7858
Change-Id: I8e5bbf2f2e9d59a20ff79917671e910e76148700
Reviewed-on: https://chromium-review.googlesource.com/1162310Reviewed-by: default avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580580}
parent 22333d92
...@@ -2335,23 +2335,6 @@ crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-height-flex-items-007 ...@@ -2335,23 +2335,6 @@ crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-height-flex-items-007
crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-width-flex-items-005.xht [ Failure ] crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-width-flex-items-005.xht [ Failure ]
crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-width-flex-items-007.xht [ Failure ] crbug.com/249112 external/wpt/css/css-flexbox/flex-minimum-width-flex-items-007.xht [ Failure ]
crbug.com/595206 http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion.js [ Skip ]
crbug.com/595206 http/tests/inspector-protocol/terminate-execution-with-fetch-callbacks.js [ Skip ]
crbug.com/595206 inspector-protocol/console/console-let-const-with-api.js [ Skip ]
crbug.com/595206 inspector-protocol/debugger/debugger-scope-skip-variables-with-empty-name.js [ Skip ]
crbug.com/595206 inspector-protocol/debugger/setScriptSource.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-await-promise.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-callFunctionOn-async.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-clear-of-command-line-api.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-console-line-and-column.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-evaluate-async.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-evaluate-in-default-context.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-get-properties-on-proxy.js [ Skip ]
crbug.com/595206 inspector-protocol/runtime/runtime-property-on-console-proto.js [ Skip ]
crbug.com/595206 inspector-protocol/sessions/runtime-evaluate.js [ Skip ]
crbug.com/595206 inspector-protocol/target/target-send-message.js [ Skip ]
# Not implemented yet # Not implemented yet
crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse-line-wrapping.html [ Failure ] crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse-line-wrapping.html [ Failure ]
crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse.html [ Failure ] crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse.html [ Failure ]
...@@ -2483,14 +2466,6 @@ crbug.com/591500 [ Win10 ] virtual/threaded/printing/standards-percentage-height ...@@ -2483,14 +2466,6 @@ crbug.com/591500 [ Win10 ] virtual/threaded/printing/standards-percentage-height
crbug.com/591500 [ Win10 ] virtual/threaded/printing/subframes-percentage-height.html [ Failure ] crbug.com/591500 [ Win10 ] virtual/threaded/printing/subframes-percentage-height.html [ Failure ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-step/step-through-event-listeners.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/debugger/message-channel-async-stack.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/worker/worker-on-message-async-stacks.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/worker/worker-post-message-async-stacks.js [ Skip ]
# TODO(ftang,jshin) Remove once v8 is rolled to include a fix for v8/7958. # TODO(ftang,jshin) Remove once v8 is rolled to include a fix for v8/7958.
crbug.com/v8/7958 fast/js/string-prototype-properties.html [ Skip ] crbug.com/v8/7958 fast/js/string-prototype-properties.html [ Skip ]
...@@ -2615,14 +2590,6 @@ crbug.com/694525 external/wpt/content-security-policy/style-src/inline-style-all ...@@ -2615,14 +2590,6 @@ crbug.com/694525 external/wpt/content-security-policy/style-src/inline-style-all
crbug.com/694525 external/wpt/content-security-policy/style-src/style-blocked.sub.html [ Skip ] crbug.com/694525 external/wpt/content-security-policy/style-src/style-blocked.sub.html [ Skip ]
crbug.com/694525 external/wpt/content-security-policy/unsafe-eval/eval-blocked-in-about-blank-iframe.sub.html [ Skip ] crbug.com/694525 external/wpt/content-security-policy/unsafe-eval/eval-blocked-in-about-blank-iframe.sub.html [ Skip ]
crbug.com/v8/7858 http/tests/devtools/persistence/persistence-external-change-breakpoints.js [ Skip ]
crbug.com/v8/7858 http/tests/devtools/sources/debugger-step/debugger-step-into-document-write.js [ Skip ]
crbug.com/v8/7858 http/tests/devtools/sources/debugger-step/debugger-step-into-inlined-scripts.js [ Skip ]
crbug.com/v8/7858 http/tests/devtools/sources/debugger-step/debugger-step-out-document-write.js [ Skip ]
crbug.com/v8/7858 http/tests/devtools/sources/debugger-step/debugger-step-over-document-write.js [ Skip ]
crbug.com/v8/7858 http/tests/devtools/sources/debugger-step/debugger-step-over-inlined-scripts.js [ Skip ]
crbug.com/v8/7858 inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.js [ Skip ]
# These tests will be added back soon: # These tests will be added back soon:
crbug.com/706350 external/wpt/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-aux-frame-navigation.sub.html [ Skip ] crbug.com/706350 external/wpt/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-aux-frame-navigation.sub.html [ Skip ]
crbug.com/706350 external/wpt/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-main-frame-navigation.sub.html [ Skip ] crbug.com/706350 external/wpt/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-main-frame-navigation.sub.html [ Skip ]
......
...@@ -128,7 +128,7 @@ func: function() {return a + b;} ...@@ -128,7 +128,7 @@ func: function() {return a + b;}
name: name:
prototype: Object prototype: Object
__proto__: function () { [native code] } __proto__: function () { [native code] }
[[FunctionLocation]]: undefined [[FunctionLocation]]: Object
[[Scopes]]: Scopes[2] [[Scopes]]: Scopes[2]
0: Closure 0: Closure
a: 10 a: 10
...@@ -255,7 +255,7 @@ func: function() {return a + b;} ...@@ -255,7 +255,7 @@ func: function() {return a + b;}
name: name:
prototype: Object prototype: Object
__proto__: function () { [native code] } __proto__: function () { [native code] }
[[FunctionLocation]]: undefined [[FunctionLocation]]: Object
[[Scopes]]: Scopes[2] [[Scopes]]: Scopes[2]
0: Closure 0: Closure
a: 10 a: 10
......
Tests terminate execution. Tests terminate execution.
{ {
description : 1
type : number type : number
value : 1 value : 1
} }
...@@ -7,6 +8,7 @@ Tests terminate execution. ...@@ -7,6 +8,7 @@ Tests terminate execution.
id : <number> id : <number>
result : { result : {
} }
sessionId : <string>
} }
{ {
id : <number> id : <number>
...@@ -16,5 +18,6 @@ Tests terminate execution. ...@@ -16,5 +18,6 @@ Tests terminate execution.
value : evaluated after value : evaluated after
} }
} }
sessionId : <string>
} }
...@@ -3,7 +3,7 @@ first 'let a = 1;' result: wasThrown = false ...@@ -3,7 +3,7 @@ first 'let a = 1;' result: wasThrown = false
second 'let a = 1;' result: wasThrown = true second 'let a = 1;' result: wasThrown = true
exception message: Uncaught SyntaxError: Identifier 'a' has already been declared exception message: Uncaught SyntaxError: Identifier 'a' has already been declared
at <anonymous>:1:1 at <anonymous>:1:1
{"result":{"type":"number","value":42}} {"result":{"type":"number","value":42,"description":"42"}}
function $(selector, [startNode]) { [Command Line API] } function $(selector, [startNode]) { [Command Line API] }
function $$(selector, [startNode]) { [Command Line API] } function $$(selector, [startNode]) { [Command Line API] }
function $x(xpath, [startNode]) { [Command Line API] } function $x(xpath, [startNode]) { [Command Line API] }
......
...@@ -7,6 +7,7 @@ Tests that we do not report scope variables with empty names. ...@@ -7,6 +7,7 @@ Tests that we do not report scope variables with empty names.
isOwn : true isOwn : true
name : a name : a
value : { value : {
description : 2
type : number type : number
value : 2 value : 2
} }
......
Tests setScriptSource functionality. Tests setScriptSource functionality.
Function evaluate: {"type":"number","value":6} Function evaluate: {"type":"number","value":6,"description":"6"}
PASS, result value: 6 PASS, result value: 6
Function evaluate: {"type":"number","value":8} Function evaluate: {"type":"number","value":8,"description":"8"}
PASS, result value: 8 PASS, result value: 8
Has error reported: PASS Has error reported: PASS
Reported error is a compile error: PASS Reported error is a compile error: PASS
......
...@@ -3,6 +3,7 @@ Tests that Runtime.awaitPromise works. ...@@ -3,6 +3,7 @@ Tests that Runtime.awaitPromise works.
Running test: testResolvedPromise Running test: testResolvedPromise
{ {
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
...@@ -36,6 +37,7 @@ Running test: testRejectedPromiseWithStack ...@@ -36,6 +37,7 @@ Running test: testRejectedPromiseWithStack
exceptionDetails : { exceptionDetails : {
columnNumber : 0 columnNumber : 0
exception : { exception : {
description : 239
objectId : <number> objectId : <number>
type : number type : number
value : 239 value : 239
...@@ -45,6 +47,7 @@ Running test: testRejectedPromiseWithStack ...@@ -45,6 +47,7 @@ Running test: testRejectedPromiseWithStack
text : Uncaught (in promise) text : Uncaught (in promise)
} }
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
...@@ -53,6 +56,7 @@ Running test: testRejectedPromiseWithStack ...@@ -53,6 +56,7 @@ Running test: testRejectedPromiseWithStack
Running test: testPendingPromise Running test: testPendingPromise
{ {
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
......
...@@ -61,6 +61,7 @@ Running test: testExceptionInFunctionExpression ...@@ -61,6 +61,7 @@ Running test: testExceptionInFunctionExpression
Running test: testFunctionReturnNotPromise Running test: testFunctionReturnNotPromise
{ {
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
......
...@@ -2,12 +2,14 @@ Tests that CommandLineAPI is presented only while evaluation. ...@@ -2,12 +2,14 @@ Tests that CommandLineAPI is presented only while evaluation.
{ {
result : { result : {
description : 15
type : number type : number
value : 15 value : 15
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
...@@ -15,18 +17,21 @@ Tests that CommandLineAPI is presented only while evaluation. ...@@ -15,18 +17,21 @@ Tests that CommandLineAPI is presented only while evaluation.
setPropertyForMethod() setPropertyForMethod()
{ {
result : { result : {
description : 14
type : number type : number
value : 14 value : 14
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
{ {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
...@@ -34,18 +39,21 @@ setPropertyForMethod() ...@@ -34,18 +39,21 @@ setPropertyForMethod()
defineValuePropertyForMethod() defineValuePropertyForMethod()
{ {
result : { result : {
description : 14
type : number type : number
value : 14 value : 14
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
{ {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
...@@ -53,18 +61,21 @@ defineValuePropertyForMethod() ...@@ -53,18 +61,21 @@ defineValuePropertyForMethod()
definePropertiesForMethod() definePropertiesForMethod()
{ {
result : { result : {
description : 14
type : number type : number
value : 14 value : 14
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
{ {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
...@@ -72,18 +83,21 @@ definePropertiesForMethod() ...@@ -72,18 +83,21 @@ definePropertiesForMethod()
defineAccessorPropertyForMethod() defineAccessorPropertyForMethod()
{ {
result : { result : {
description : 14
type : number type : number
value : 14 value : 14
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
{ {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
...@@ -91,18 +105,21 @@ defineAccessorPropertyForMethod() ...@@ -91,18 +105,21 @@ defineAccessorPropertyForMethod()
redefineGetOwnPropertyDescriptors() redefineGetOwnPropertyDescriptors()
{ {
result : { result : {
description : 14
type : number type : number
value : 14 value : 14
} }
} }
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
{ {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
......
...@@ -4,11 +4,12 @@ Tests line and column numbers in reported console messages. ...@@ -4,11 +4,12 @@ Tests line and column numbers in reported console messages.
params : { params : {
args : [ args : [
[0] : { [0] : {
description : 239
type : number type : number
value : 239 value : 239
} }
] ]
executionContextId : 3 executionContextId : <number>
stackTrace : { stackTrace : {
callFrames : [ callFrames : [
[0] : { [0] : {
...@@ -23,17 +24,19 @@ Tests line and column numbers in reported console messages. ...@@ -23,17 +24,19 @@ Tests line and column numbers in reported console messages.
timestamp : <number> timestamp : <number>
type : log type : log
} }
sessionId : <string>
} }
{ {
method : Runtime.consoleAPICalled method : Runtime.consoleAPICalled
params : { params : {
args : [ args : [
[0] : { [0] : {
description : 239
type : number type : number
value : 239 value : 239
} }
] ]
executionContextId : 3 executionContextId : <number>
stackTrace : { stackTrace : {
callFrames : [ callFrames : [
[0] : { [0] : {
...@@ -48,5 +51,6 @@ Tests line and column numbers in reported console messages. ...@@ -48,5 +51,6 @@ Tests line and column numbers in reported console messages.
timestamp : <number> timestamp : <number>
type : log type : log
} }
sessionId : <string>
} }
Check that console.log doesn't run microtasks. Check that console.log doesn't run microtasks.
{ {
description : 42
type : number type : number
value : 42 value : 42
} }
{ {
description : 43
type : number type : number
value : 43 value : 43
} }
{ {
description : 239
type : number type : number
value : 239 value : 239
} }
......
...@@ -3,6 +3,7 @@ Tests that Runtime.evaluate works with awaitPromise flag. ...@@ -3,6 +3,7 @@ Tests that Runtime.evaluate works with awaitPromise flag.
Running test: testResolvedPromise Running test: testResolvedPromise
{ {
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
...@@ -13,6 +14,7 @@ Running test: testRejectedPromise ...@@ -13,6 +14,7 @@ Running test: testRejectedPromise
exceptionDetails : { exceptionDetails : {
columnNumber : 0 columnNumber : 0
exception : { exception : {
description : 239
objectId : <number> objectId : <number>
type : number type : number
value : 239 value : 239
...@@ -23,6 +25,7 @@ Running test: testRejectedPromise ...@@ -23,6 +25,7 @@ Running test: testRejectedPromise
text : Uncaught (in promise) text : Uncaught (in promise)
} }
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
...@@ -60,6 +63,7 @@ Running test: testExceptionInEvaluate ...@@ -60,6 +63,7 @@ Running test: testExceptionInEvaluate
exceptionDetails : { exceptionDetails : {
columnNumber : 0 columnNumber : 0
exception : { exception : {
description : 239
objectId : <number> objectId : <number>
type : number type : number
value : 239 value : 239
...@@ -70,6 +74,7 @@ Running test: testExceptionInEvaluate ...@@ -70,6 +74,7 @@ Running test: testExceptionInEvaluate
text : Uncaught text : Uncaught
} }
result : { result : {
description : 239
type : number type : number
value : 239 value : 239
} }
......
...@@ -3,9 +3,11 @@ Tests that default execution context is selected correctly. ...@@ -3,9 +3,11 @@ Tests that default execution context is selected correctly.
id : <number> id : <number>
result : { result : {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
} }
sessionId : <string>
} }
Check that while Runtime.getProperties call on proxy object no user defined trap will be executed. Check that while Runtime.getProperties call on proxy object no user defined trap will be executed.
{ {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
......
...@@ -3,9 +3,11 @@ Tests that property defined on console.__proto__ doesn't observable on other Obj ...@@ -3,9 +3,11 @@ Tests that property defined on console.__proto__ doesn't observable on other Obj
id : <number> id : <number>
result : { result : {
result : { result : {
description : 0
type : number type : number
value : 0 value : 0
} }
} }
sessionId : <string>
} }
...@@ -4,29 +4,35 @@ window.foo=42 in session1 ...@@ -4,29 +4,35 @@ window.foo=42 in session1
id : <number> id : <number>
result : { result : {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
} }
sessionId : <string>
} }
window.foo in session2 window.foo in session2
{ {
id : <number> id : <number>
result : { result : {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
} }
sessionId : <string>
} }
window.foo in session3 window.foo in session3
{ {
id : <number> id : <number>
result : { result : {
result : { result : {
description : 42
type : number type : number
value : 42 value : 42
} }
} }
sessionId : <string>
} }
...@@ -4,9 +4,9 @@ JSON syntax error.. ...@@ -4,9 +4,9 @@ JSON syntax error..
JSON with primitive value.. JSON with primitive value..
{"error":{"code":-32600,"message":"Message must be an object"}} {"error":{"code":-32600,"message":"Message must be an object"}}
JSON without method property.. JSON without method property..
{"error":{"code":-32600,"message":"Message must have string 'method' property"}} {"error":{"code":-32600,"message":"Message must have integer 'id' property"}}
JSON without id property.. JSON without id property..
{"error":{"code":-32600,"message":"Message must have integer 'id' property"}} {"error":{"code":-32600,"message":"Message must have integer 'id' property"}}
Valid JSON.. Valid JSON..
{"id":1,"result":{"result":{"type":"number","value":42}}} {"id":1,"result":{"result":{"type":"number","value":42,"description":"42"}}}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment