Commit bf05f2bd authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Fix chrome/ dependencies for //tools/v8_context_snapshot.

Exposing //tools/v8_context_snapshot as a public dependency for the
"chrome" target does not do anything useful when one is building the
"chrome" target.

BUG=764327

Change-Id: Ia1b6bc6cf643a4981085cf58c72be7c1f3dd44b4
Reviewed-on: https://chromium-review.googlesource.com/683469Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504493}
parent 60ef03d4
...@@ -117,7 +117,6 @@ if (!is_android && !is_mac) { ...@@ -117,7 +117,6 @@ if (!is_android && !is_mac) {
group("chrome") { group("chrome") {
public_deps = [ public_deps = [
":chrome_initial", ":chrome_initial",
"//tools/v8_context_snapshot:v8_context_snapshot",
] ]
data_deps = [ data_deps = [
":chrome_initial", ":chrome_initial",
...@@ -444,6 +443,7 @@ if (is_win) { ...@@ -444,6 +443,7 @@ if (is_win) {
# The browser DLL may not depend on blink or v8. # The browser DLL may not depend on blink or v8.
"//third_party/WebKit/public:blink", "//third_party/WebKit/public:blink",
"//gin", "//gin",
"//tools/v8_context_snapshot",
"//v8", "//v8",
] ]
} else { } else {
...@@ -882,7 +882,7 @@ if (is_win) { ...@@ -882,7 +882,7 @@ if (is_win) {
public_deps = [ public_deps = [
":packed_resources", ":packed_resources",
"//chrome/app_shim:app_mode_loader", "//chrome/app_shim:app_mode_loader",
"//tools/v8_context_snapshot:v8_context_snapshot", "//tools/v8_context_snapshot",
] ]
if (is_chrome_branded) { if (is_chrome_branded) {
...@@ -1443,6 +1443,7 @@ group("browser_dependencies") { ...@@ -1443,6 +1443,7 @@ group("browser_dependencies") {
assert_no_deps += [ assert_no_deps += [
# V8/Gin should not be used in the browser DLL on Windows. # V8/Gin should not be used in the browser DLL on Windows.
"//gin", "//gin",
"//tools/v8_context_snapshot",
"//v8", "//v8",
] ]
} }
......
...@@ -18,6 +18,7 @@ static_library("child") { ...@@ -18,6 +18,7 @@ static_library("child") {
"//base", "//base",
"//content/public/child", "//content/public/child",
"//gin", "//gin",
"//tools/v8_context_snapshot",
"//v8", "//v8",
] ]
......
...@@ -176,7 +176,7 @@ template("generate_mini_installer") { ...@@ -176,7 +176,7 @@ template("generate_mini_installer") {
"//chrome/browser/extensions/default_extensions", "//chrome/browser/extensions/default_extensions",
"//chrome/installer/setup", "//chrome/installer/setup",
"//third_party/icu:icudata", "//third_party/icu:icudata",
"//tools/v8_context_snapshot:v8_context_snapshot", "//tools/v8_context_snapshot",
chrome_dll_target, chrome_dll_target,
] ]
......
...@@ -159,6 +159,7 @@ static_library("renderer") { ...@@ -159,6 +159,7 @@ static_library("renderer") {
"//third_party/icu", "//third_party/icu",
"//third_party/re2", "//third_party/re2",
"//third_party/widevine/cdm:headers", "//third_party/widevine/cdm:headers",
"//tools/v8_context_snapshot",
"//ui/surface", "//ui/surface",
"//v8:v8", "//v8:v8",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment