Commit bf19b777 authored by Doug Arnett's avatar Doug Arnett Committed by Commit Bot

Re-enable DeferAllScriptClientRedirectLoopStopped test

Attempting a closer histogram to wait on. Was able to run locally 2000
times without failure whereas previous histogram did fail locally after
a couple hundred attempts.

Bug: 997697
Change-Id: I1f826945091f6e2fce035755fe62ba781f219adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771045Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690781}
parent a1c6c1a6
...@@ -312,8 +312,6 @@ IN_PROC_BROWSER_TEST_F( ...@@ -312,8 +312,6 @@ IN_PROC_BROWSER_TEST_F(
true); true);
} }
// Disable flake on Linux too (via only Android) until crbug/997697 resolved.
#if defined(OS_ANDROID)
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
DeferAllScriptBrowserTest, DeferAllScriptBrowserTest,
DISABLE_ON_WIN_MAC_CHROMESOS(DeferAllScriptClientRedirectLoopStopped)) { DISABLE_ON_WIN_MAC_CHROMESOS(DeferAllScriptClientRedirectLoopStopped)) {
...@@ -333,8 +331,8 @@ IN_PROC_BROWSER_TEST_F( ...@@ -333,8 +331,8 @@ IN_PROC_BROWSER_TEST_F(
ui_test_utils::NavigateToURL(browser(), client_redirect_url()); ui_test_utils::NavigateToURL(browser(), client_redirect_url());
RetryForHistogramUntilCountReached( RetryForHistogramUntilCountReached(
&histogram_tester, "PageLoad.DocumentTiming.NavigationToLoadEventFired", &histogram_tester, "Navigation.ClientRedirectCycle.RedirectToReferrer",
1); 2);
// Client redirect loop is broken on 2nd pass around the loop so expect 3 // Client redirect loop is broken on 2nd pass around the loop so expect 3
// previews before previews turned off to stop loop. // previews before previews turned off to stop loop.
...@@ -342,4 +340,3 @@ IN_PROC_BROWSER_TEST_F( ...@@ -342,4 +340,3 @@ IN_PROC_BROWSER_TEST_F(
"Navigation.ClientRedirectCycle.RedirectToReferrer", 2); "Navigation.ClientRedirectCycle.RedirectToReferrer", 2);
histogram_tester.ExpectTotalCount("Previews.PageEndReason.DeferAllScript", 3); histogram_tester.ExpectTotalCount("Previews.PageEndReason.DeferAllScript", 3);
} }
#endif // defined(OS_ANDROID)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment