Commit bfa8dd87 authored by Nohemi Fernandez's avatar Nohemi Fernandez Committed by Commit Bot

[iOS] Clean up method names in UserSigninViewController.

Bug: 971989
Change-Id: I406a94c3b6918f401e74e109afd6e98df2fc5803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095115
Auto-Submit: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748205}
parent f1ff8e90
...@@ -115,7 +115,7 @@ enum AuthenticationButtonType { ...@@ -115,7 +115,7 @@ enum AuthenticationButtonType {
#pragma mark - MDCActivityIndicator #pragma mark - MDCActivityIndicator
- (void)startAnimatingActivityIndicator { - (void)startAnimatingActivityIndicator {
[self addActivityIndicatorToView]; [self addActivityIndicator];
[self.activityIndicator startAnimating]; [self.activityIndicator startAnimating];
} }
...@@ -131,9 +131,9 @@ enum AuthenticationButtonType { ...@@ -131,9 +131,9 @@ enum AuthenticationButtonType {
[super viewDidLoad]; [super viewDidLoad];
self.view.backgroundColor = self.systemBackgroundColor; self.view.backgroundColor = self.systemBackgroundColor;
[self addConfirmationButtonToView]; [self addConfirmationButton];
[self embedUserConsentView]; [self embedUserConsentView];
[self addSkipSigninButtonToView]; [self addSkipSigninButton];
[self.view addSubview:self.gradientView]; [self.view addSubview:self.gradientView];
...@@ -229,8 +229,8 @@ enum AuthenticationButtonType { ...@@ -229,8 +229,8 @@ enum AuthenticationButtonType {
#pragma mark - Subviews #pragma mark - Subviews
// Sets up activity indicator properties and adds it to the view. // Sets up activity indicator properties and adds it to the user sign-in view.
- (void)addActivityIndicatorToView { - (void)addActivityIndicator {
DCHECK(!self.activityIndicator); DCHECK(!self.activityIndicator);
self.activityIndicator = self.activityIndicator =
[[MDCActivityIndicator alloc] initWithFrame:CGRectZero]; [[MDCActivityIndicator alloc] initWithFrame:CGRectZero];
...@@ -256,8 +256,8 @@ enum AuthenticationButtonType { ...@@ -256,8 +256,8 @@ enum AuthenticationButtonType {
[self.unifiedConsentViewController didMoveToParentViewController:self]; [self.unifiedConsentViewController didMoveToParentViewController:self];
} }
// Sets up confirmation button properties and adds it to the view. // Sets up confirmation button properties and adds it to the user sign-in view.
- (void)addConfirmationButtonToView { - (void)addConfirmationButton {
DCHECK(self.unifiedConsentViewController); DCHECK(self.unifiedConsentViewController);
self.confirmationButton = [[UIButton alloc] init]; self.confirmationButton = [[UIButton alloc] init];
self.confirmationButton.accessibilityIdentifier = @"ic_close"; self.confirmationButton.accessibilityIdentifier = @"ic_close";
...@@ -270,8 +270,8 @@ enum AuthenticationButtonType { ...@@ -270,8 +270,8 @@ enum AuthenticationButtonType {
kButtonTitleContentInset, kButtonTitleContentInset); kButtonTitleContentInset, kButtonTitleContentInset);
} }
// Sets up skip sign-in button properties and adds it to the view. // Sets up skip sign-in button properties and adds it to the user sign-in view.
- (void)addSkipSigninButtonToView { - (void)addSkipSigninButton {
DCHECK(!self.skipSigninButton); DCHECK(!self.skipSigninButton);
DCHECK(self.unifiedConsentViewController); DCHECK(self.unifiedConsentViewController);
self.skipSigninButton = [[UIButton alloc] init]; self.skipSigninButton = [[UIButton alloc] init];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment