Commit c0a51714 authored by Robert Liao's avatar Robert Liao Committed by Commit Bot

Reenable ui_base_unittests ResourceBundleImageTest.FallbackToNone

This test now presents a consistent set of supported scale factors
invariant of the running platform, avoiding any surprises in
expectations.

BUG=298406

Change-Id: Ibcfa08f42f4e97ce7cf6244fa2a50ccab309c1c9
Reviewed-on: https://chromium-review.googlesource.com/c/1351769Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611750}
parent 19d24af1
......@@ -578,13 +578,16 @@ TEST_F(ResourceBundleImageTest, GetImageNamedFallback1xRounding) {
}
#endif
#if defined(OS_IOS)
// Fails on devices that have non-100P scaling. See crbug.com/298406
#define MAYBE_FallbackToNone DISABLED_FallbackToNone
#else
#define MAYBE_FallbackToNone FallbackToNone
#endif
TEST_F(ResourceBundleImageTest, MAYBE_FallbackToNone) {
TEST_F(ResourceBundleImageTest, FallbackToNone) {
std::vector<ScaleFactor> supported_factors;
supported_factors.push_back(SCALE_FACTOR_100P);
supported_factors.push_back(SCALE_FACTOR_200P);
supported_factors.push_back(SCALE_FACTOR_300P);
// Presents a consistent set of supported scale factors for all platforms.
// iOS does not include SCALE_FACTOR_100P, which breaks the test below.
test::ScopedSetSupportedScaleFactors scoped_supported(supported_factors);
base::FilePath data_default_path = dir_path().AppendASCII("sample.pak");
// Create the pak files.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment