MD Site Settings: Implement the third-party checkbox for Cookies.

BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2031833003
Cr-Commit-Position: refs/heads/master@{#397842}

chrome/app/settings_strings.grdp

@@ -1081,6 +1081,12 @@
   <message name="IDS_SETTINGS_SITE_SETTINGS_DELETE" desc="Label for the trashcan icon used to delete storage on the Site Details page.">
     Delete
   </message>
+  <message name="IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE" desc="Label for the Block 3rd-party cookie checkbox on the Cookies category.">
+    Block third-party cookies.
+  </message>
+  <message name="IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE_SUBLABEL" desc="A sub-label below the Block 3rd-party cookie checkbox.">
+    Prevent third-party websites from saving and reading cookie data.
+  </message>
 
   <!-- Sync / People Page -->
   <message name="IDS_SETTINGS_PEOPLE" desc="Name of the settings page which manages Chrome's signed-in Google profile.">

chrome/browser/extensions/api/settings_private/prefs_util.cc

@@ -130,6 +130,10 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetWhitelistedKeys() {
   (*s_whitelist)["translate_blocked_languages"] =
       settings_private::PrefType::PREF_TYPE_LIST;
 
+  // Site Settings prefs.
+  (*s_whitelist)["profile.block_third_party_cookies"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+
   // Clear browsing data settings.
   (*s_whitelist)["browser.clear_data.browsing_history"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;

chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -155,6 +155,7 @@
       <template is="dom-if" name="site-settings-category-cookies">
         <settings-subpage page-title="$i18n{siteSettingsCategoryCookies}">
           <site-settings-category
+              prefs="{{prefs}}"
               selected-site="{{selectedSite}}"
               current-route="{{currentRoute}}"
               category="{{ContentSettingsTypes.COOKIES}}">

chrome/browser/resources/settings/site_settings/site_settings_category.html

@@ -50,6 +50,17 @@
       <paper-toggle-button id="toggle" checked="{{categoryEnabled}}"
           on-change="onToggleChange_"></paper-toggle-button>
     </div>
+
+    <div id="cookieControls" hidden>
+      <div class="settings-box">
+        <settings-checkbox class="start"
+            label="$i18n{thirdPartyCookie}"
+            sub-label="$i18n{thirdPartyCookieSublabel}"
+            pref="{{prefs.profile.block_third_party_cookies}}">
+        </settings-checkbox>
+      </div>
+    </div>
+
     <settings-site-list id="blockList"
         category="[[category]]"
         current-route="{{currentRoute}}"

chrome/browser/resources/settings/site_settings/site_settings_category.js

@@ -21,6 +21,14 @@ Polymer({
       notify: true,
     },
 
+    /**
+     * Preferences state.
+     */
+    prefs: {
+      type: Object,
+      notify: true,
+    },
+
     /**
      * Represents the state of the main toggle shown for the category. For
      * example, the Location category can be set to Block/Ask so false, in that
@@ -56,6 +64,9 @@ Polymer({
 
     this.addWebUIListener('contentSettingCategoryChanged',
         this.defaultValueForCategoryChanged_.bind(this));
+
+    if (this.category == settings.ContentSettingsTypes.COOKIES)
+      this.$.cookieControls.hidden = false;
   },
 
   /**

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -977,6 +977,9 @@ void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {
       {"siteSettingsPermissions", IDS_SETTINGS_SITE_SETTINGS_PERMISSIONS},
       {"siteSettingsClearAndReset", IDS_SETTINGS_SITE_SETTINGS_CLEAR_BUTTON},
       {"siteSettingsDelete", IDS_SETTINGS_SITE_SETTINGS_DELETE},
+      {"thirdPartyCookie", IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE},
+      {"thirdPartyCookieSublabel",
+       IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE_SUBLABEL},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));