Commit c20eda8d authored by yukishiino's avatar yukishiino Committed by Commit bot

binding: Removes dead code in WindowProxy::createContext().

Per https://crrev.com/2536173002, it seems no need to keep
the check at head of WindowProxy::createContext().
http/tests/xsl/xslt-transform-with-javascript-disabled.html
passes with this CL.

BUG=

Review-Url: https://codereview.chromium.org/2586883002
Cr-Commit-Position: refs/heads/master@{#439435}
parent ccf646e5
...@@ -291,21 +291,6 @@ bool WindowProxy::initialize() { ...@@ -291,21 +291,6 @@ bool WindowProxy::initialize() {
} }
void WindowProxy::createContext() { void WindowProxy::createContext() {
// FIXME: This should be a null check of m_frame->client(), but there are
// still some edge cases
// that this fails to catch during frame detach.
if (m_frame->isLocalFrame() &&
!toLocalFrame(m_frame)->loader().documentLoader()) {
// TODO(yukishiino): Remove this if-clause entirely once we are sure that
// it's safe. There seems no case that we hit this if-clause. Plus,
// createContext() is responsible just to create a new v8::Context, and it's
// technically possible to create it without a document loader.
// If we really want to limit the context creation under some condition,
// it must come with the right reason described in a comment.
NOTREACHED();
return;
}
// Create a new v8::Context with the window object as the global object // Create a new v8::Context with the window object as the global object
// (aka the inner global). Reuse the global proxy object (aka the outer // (aka the inner global). Reuse the global proxy object (aka the outer
// global) if it already exists. See the comments in // global) if it already exists. See the comments in
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment