Commit c2bf744a authored by jonross's avatar jonross Committed by Commit Bot

Update GpuIntegrationTest minidump handling

GpuIntegrationTest will catch errors from test runs, then nicely format the
exception. As well as symbolize minidumps.

However it is possible for this to lead to a second nested exception. If startup
failed, there won't be a browser object to attempt to find minidumps from.

This updates the handling to only attempt to symbolize the minidump if the
browser exists, and therefore succeeded at startup.

TEST=pixel_tests

Bug: 993379
Change-Id: I79f575556c5785b4aa6e6c6c031067cb1c5f993a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761773Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688777}
parent 4fe2e44d
...@@ -206,6 +206,8 @@ class GpuIntegrationTest( ...@@ -206,6 +206,8 @@ class GpuIntegrationTest(
# expectations, and since minidump symbolization is slow # expectations, and since minidump symbolization is slow
# (upwards of one minute on a fast laptop), symbolizing all the # (upwards of one minute on a fast laptop), symbolizing all the
# stacks could slow down the tests' running time unacceptably. # stacks could slow down the tests' running time unacceptably.
# We also don't do this if the browser failed to startup.
if self.browser is not None:
self.browser.LogSymbolizedUnsymbolizedMinidumps(logging.ERROR) self.browser.LogSymbolizedUnsymbolizedMinidumps(logging.ERROR)
# This failure might have been caused by a browser or renderer # This failure might have been caused by a browser or renderer
# crash, so restart the browser to make sure any state doesn't # crash, so restart the browser to make sure any state doesn't
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment