Commit c3722831 authored by Kenton Lam's avatar Kenton Lam Committed by Chromium LUCI CQ

Split event definitions from types.js into events.js

The types.js file now just contains typedefs for Closure.
There are some constants defined in events.js which are actually used at runtime.

Change-Id: Ibe12b78de463785e1a27f613ff6cad54facaa90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626614Reviewed-by: default avatarJohn Palmer <jopalmer@chromium.org>
Reviewed-by: default avatarKeith Lee <keithlee@chromium.org>
Commit-Queue: Kenton Lam <kentonlam@google.com>
Cr-Commit-Position: refs/heads/master@{#843389}
parent 775ad8fb
...@@ -28,6 +28,7 @@ generate_grd("build_grd") { ...@@ -28,6 +28,7 @@ generate_grd("build_grd") {
input_files = [ input_files = [
"index.html", "index.html",
"types.js", "types.js",
"events.js",
] ]
grdp_files = [ grdp_files = [
components_grdp_file, components_grdp_file,
...@@ -69,6 +70,7 @@ js_library("emoji_picker") { ...@@ -69,6 +70,7 @@ js_library("emoji_picker") {
deps = [ deps = [
":emoji_group", ":emoji_group",
":emoji_group_button", ":emoji_group_button",
":events",
":types", ":types",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled", "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
"//ui/webui/resources/js:assert.m", "//ui/webui/resources/js:assert.m",
...@@ -84,6 +86,7 @@ js_library("emoji_group") { ...@@ -84,6 +86,7 @@ js_library("emoji_group") {
js_library("emoji_group_button") { js_library("emoji_group_button") {
deps = [ deps = [
":events",
":icons", ":icons",
"//third_party/polymer/v3_0/components-chromium/iron-icon", "//third_party/polymer/v3_0/components-chromium/iron-icon",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled", "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
...@@ -100,12 +103,16 @@ js_library("icons") { ...@@ -100,12 +103,16 @@ js_library("icons") {
js_library("types") { js_library("types") {
} }
js_library("events") {
}
js_type_check("closure_compile") { js_type_check("closure_compile") {
is_polymer3 = true is_polymer3 = true
deps = [ deps = [
":emoji_group", ":emoji_group",
":emoji_group_button", ":emoji_group_button",
":emoji_picker", ":emoji_picker",
":events",
":icons", ":icons",
":types", ":types",
] ]
......
...@@ -7,7 +7,7 @@ import 'chrome://resources/polymer/v3_0/iron-icon/iron-icon.js'; ...@@ -7,7 +7,7 @@ import 'chrome://resources/polymer/v3_0/iron-icon/iron-icon.js';
import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
import {GROUP_BUTTON_EVENT, GroupButtonEvent} from './types.js'; import {GROUP_BUTTON_EVENT, GroupButtonEvent} from './events.js';
class EmojiGroupButton extends PolymerElement { class EmojiGroupButton extends PolymerElement {
static get is() { static get is() {
......
...@@ -9,7 +9,8 @@ import './emoji_group_button.js'; ...@@ -9,7 +9,8 @@ import './emoji_group_button.js';
import {assert} from 'chrome://resources/js/assert.m.js'; import {assert} from 'chrome://resources/js/assert.m.js';
import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
import {EmojiData, EmojiGroup, GROUP_BUTTON_EVENT} from './types.js'; import {GROUP_BUTTON_EVENT} from './events.js';
import {EmojiData, EmojiGroup} from './types.js';
const EMOJI_ORDERING_JSON = '/emoji_13_1_ordering.json'; const EMOJI_ORDERING_JSON = '/emoji_13_1_ordering.json';
......
// Copyright 2021 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/**
* @typedef {!CustomEvent<{group: string}>}
*/
export let GroupButtonEvent;
export const GROUP_BUTTON_EVENT = 'group-button';
/**
* @typedef {!CustomEvent<{emoji: string}>}
*/
export let EmojiButtonEvent;
export const EMOJI_BUTTON_EVENT = 'emoji-button';
\ No newline at end of file
...@@ -16,10 +16,3 @@ export let EmojiGroup; ...@@ -16,10 +16,3 @@ export let EmojiGroup;
* @typedef {Array<EmojiGroup>} EmojiData * @typedef {Array<EmojiGroup>} EmojiData
*/ */
export let EmojiData; export let EmojiData;
/**
* @typedef {!CustomEvent<{group: string}>} GroupButtonEvent
*/
export let GroupButtonEvent;
export const GROUP_BUTTON_EVENT = 'group-button';
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment