Commit c38bba2d authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

mac, ios: Unconfuse lldb after thin_archive change.

We accidentally passed -T to the static archive tool on mac and ios.
The static archive tool on mac and ios is not ar but a mac-specific
tool called libtool, and its -T flag means something completely different.

Bug: 801925
Change-Id: I44dacbb8696cceb26ac7a5de86a2e8a0de638c00
Reviewed-on: https://chromium-review.googlesource.com/1010513
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550479}
parent ad1c9d9f
...@@ -1569,7 +1569,10 @@ config("no_rtti") { ...@@ -1569,7 +1569,10 @@ config("no_rtti") {
# 2. Remove the thin_archive config, so that the .a file actually contains all # 2. Remove the thin_archive config, so that the .a file actually contains all
# .o files, instead of just references to .o files in the build directoy # .o files, instead of just references to .o files in the build directoy
config("thin_archive") { config("thin_archive") {
if ((is_posix && !is_nacl) || is_fuchsia) { # Mac and iOS use the mac-specific "libtool" command, not ar, which doesn't
# have a "thin archive" mode (it does accept -T, but it means truncating
# archive names to 16 characters, which is not what we want).
if ((is_posix && !is_nacl && !is_mac && !is_ios) || is_fuchsia) {
# TODO(thomasanderson): Enable on ChromeOS builds once # TODO(thomasanderson): Enable on ChromeOS builds once
# https://crbug.com/829956 is fixed. # https://crbug.com/829956 is fixed.
if (default_toolchain != "//build/toolchain/cros:target") { if (default_toolchain != "//build/toolchain/cros:target") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment