Add smart suggestion for large downloads flag

This CL adds the flag for handling smart suggestion for large downloads

Bug: 1118207
Change-Id: I695757bef4119d97fc594d08945406a14a36723c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368154
Commit-Queue: Hung Vu <vuhung@google.com>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800737}

chrome/browser/about_flags.cc

@@ -6338,6 +6338,14 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(blink::features::kCrOSAutoSelect)},
 #endif  // defined(OS_CHROMEOS)
 
+#if defined(OS_ANDROID)
+    {"smart-suggestion-for-large-downloads",
+     flag_descriptions::kSmartSuggestionForLargeDownloadsName,
+     flag_descriptions::kSmartSuggestionForLargeDownloadsDescription,
+     kOsAndroid,
+     FEATURE_VALUE_TYPE(download::features::kSmartSuggestionForLargeDownloads)},
+#endif  // defined(OS_ANDROID)
+
 #if BUILDFLAG(ENABLE_AV1_DECODER)
     {"enable-avif", flag_descriptions::kEnableAVIFName,
      flag_descriptions::kEnableAVIFDescription, kOsDesktop,

chrome/browser/flag-metadata.json

@@ -4138,6 +4138,11 @@
     "owners": [ "alanlxl", "amoylan" ],
     "expiry_milestone": 88
   },
+  {
+    "name": "smart-suggestion-for-large-downloads",
+    "owners": [ "vuhung", "shaktisahu"],
+    "expiry_milestone": 89
+  },
   {
     "name": "smart-text-selection",
     "owners": [ "djacobo", "linben" ],

chrome/browser/flag_descriptions.cc

@@ -3096,6 +3096,11 @@ const char kSiteIsolationForPasswordSitesDescription[] =
     "Security mode that enables site isolation for sites based on "
     "password-oriented heuristics, such as a user typing in a password.";
 
+const char kSmartSuggestionForLargeDownloadsName[] =
+    "Smart suggestion for large downloads";
+const char kSmartSuggestionForLargeDownloadsDescription[] =
+    "Smart suggestion that offers download locations for large files.";
+
 const char kStartSurfaceAndroidName[] = "Start Surface";
 const char kStartSurfaceAndroidDescription[] =
     "Enable showing the start surface when launching Chrome via the "

chrome/browser/flag_descriptions.h

@@ -1785,6 +1785,9 @@ extern const char kShoppingAssistDescription[];
 extern const char kSiteIsolationForPasswordSitesName[];
 extern const char kSiteIsolationForPasswordSitesDescription[];
 
+extern const char kSmartSuggestionForLargeDownloadsName[];
+extern const char kSmartSuggestionForLargeDownloadsDescription[];
+
 extern const char kStartSurfaceAndroidName[];
 extern const char kStartSurfaceAndroidDescription[];
 

components/download/public/common/download_features.cc

@@ -34,6 +34,9 @@ const base::Feature kDownloadLater{"DownloadLater",
                                    base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if defined(OS_ANDROID)
+const base::Feature kSmartSuggestionForLargeDownloads{
+    "SmartSuggestionForLargeDownloads", base::FEATURE_DISABLED_BY_DEFAULT};
+
 const base::Feature kRefreshExpirationDate{"RefreshExpirationDate",
                                            base::FEATURE_ENABLED_BY_DEFAULT};
 #endif

components/download/public/common/download_features.h

@@ -33,6 +33,10 @@ COMPONENTS_DOWNLOAD_EXPORT extern const base::Feature kDownloadLater;
 #if defined(OS_ANDROID)
 // Whether download expiration date will be refreshed on resumption.
 COMPONENTS_DOWNLOAD_EXPORT extern const base::Feature kRefreshExpirationDate;
+
+// Whether to enable smart suggestion for large downloads
+COMPONENTS_DOWNLOAD_EXPORT extern const base::Feature
+    kSmartSuggestionForLargeDownloads;
 #endif
 
 // Whether in-progress download manager will be used to initialize download

tools/metrics/histograms/enums.xml

@@ -40238,6 +40238,7 @@ from previous Chrome versions.
   <int value="-2044001553"
       label="disable-experimental-accessibility-chromevox-language-switching"/>
   <int value="-2043128632" label="enable-tab-switcher-in-document-mode"/>
+  <int value="-2042278511" label="SmartSuggestionForLargeDownloads:disabled"/>
   <int value="-2041281386" label="MultiPaste:disabled"/>
   <int value="-2040471724" label="CrOSComponent:disabled"/>
   <int value="-2040115518" label="load-media-router-component-extension"/>
@@ -43949,6 +43950,7 @@ from previous Chrome versions.
   <int value="1831593339" label="stop-in-background:disabled"/>
   <int value="1831835753" label="MaterialDesignIncognitoNTP:enabled"/>
   <int value="1832552562" label="EnableVirtualKeyboardUkm:enabled"/>
+  <int value="1833340282" label="SmartSuggestionForLargeDownloads:enabled"/>
   <int value="1834968807" label="OmniboxAutocompleteTitles:enabled"/>
   <int value="1835075399" label="PostQuantumCECPQ2:disabled"/>
   <int value="1835523483" label="OmniboxUIExperimentSwapTitleAndUrl:enabled"/>