Commit c3dd13e9 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

FileManagerBrowserTest: directly mark CopyBetweenWindows DISABLED

This test fails on bots. Mark is DISABLED directly, rather than by the
DISABLE_SLOW_FILESAPP_TESTS macro used to control DEBUG/MSAN/ASAN (the
CopyBetweenWindows test is the only remaining test using this macro).

Add comment (conjecture about why this test is failing) and retain the
reference to issue 500966.

Tbr: fukino
No-Presubmit: true
Bug: 836254
Change-Id: I79aaac465b0fdd255a10d251cd474940c6692eb5
Reviewed-on: https://chromium-review.googlesource.com/1057548Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558288}
parent da3f8fd8
...@@ -365,14 +365,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P( ...@@ -365,14 +365,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(IN_INCOGNITO, "openFileDialogDrive"), TestParameter(IN_INCOGNITO, "openFileDialogDrive"),
TestParameter(NOT_IN_GUEST_MODE, "openFileDialogUnload"))); TestParameter(NOT_IN_GUEST_MODE, "openFileDialogUnload")));
#if defined(DISABLE_SLOW_FILESAPP_TESTS) // Test does too much? Flaky on all bots: http://crbug.com/500966
#define MAYBE_CopyBetweenWindows DISABLED_CopyBetweenWindows
#else
// flaky: http://crbug.com/500966
#define MAYBE_CopyBetweenWindows DISABLED_CopyBetweenWindows
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P( WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_CopyBetweenWindows, DISABLED_CopyBetweenWindows,
FileManagerBrowserTest, FileManagerBrowserTest,
::testing::Values( ::testing::Values(
TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToDrive"), TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToDrive"),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment