Commit c4320b10 authored by Simon La Macchia's avatar Simon La Macchia Committed by Commit Bot

Add button highlighting to saved passwords settings

Problem: Cannot see highlighting of currently selected Saved Password
when navigating Saved Password Settings for the following scenarios:
- with Bluetooth keyboard
- Accessibility (Explore by touch).
- Touch/click event highlighting.

Solution: Change background of affected buttons to
selectableItemBackground. This enables visible highlighting for the
above scenarios. See bug for screenshots.

Note: Also fixed presubmit errors for textAppearance.

R=melandory@chromium.org

Bug: 873239
Change-Id: I0422529308c7898afc6a315a8369082b8db7af99
Reviewed-on: https://chromium-review.googlesource.com/1171115
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584776}
parent 6bdec7f4
...@@ -11,16 +11,15 @@ ...@@ -11,16 +11,15 @@
<TextView <TextView
android:id="@+id/password_entry_editor_row_data" android:id="@+id/password_entry_editor_row_data"
android:textColor="@color/default_text_color"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="15dp" android:layout_marginTop="15dp"
android:layout_weight="1" android:layout_weight="1"
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="@style/TextAppearance.PreferenceMediumText" />
<org.chromium.chrome.browser.widget.TintedImageButton <org.chromium.chrome.browser.widget.TintedImageButton
android:id="@+id/password_entry_editor_copy" android:id="@+id/password_entry_editor_copy"
android:background="@null" android:background="?attr/selectableItemBackground"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="end" android:layout_gravity="end"
......
...@@ -53,16 +53,15 @@ ...@@ -53,16 +53,15 @@
<TextView <TextView
android:id="@+id/password_entry_editor_password" android:id="@+id/password_entry_editor_password"
android:textColor="@color/default_text_color"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="15dp" android:layout_marginTop="15dp"
android:layout_weight="1" android:layout_weight="1"
android:textAppearance="?android:attr/textAppearanceMedium" /> android:textAppearance="@style/TextAppearance.PreferenceMediumText" />
<org.chromium.chrome.browser.widget.TintedImageButton <org.chromium.chrome.browser.widget.TintedImageButton
android:id="@+id/password_entry_editor_view_password" android:id="@+id/password_entry_editor_view_password"
android:background="@null" android:background="?attr/selectableItemBackground"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="end" android:layout_gravity="end"
...@@ -75,7 +74,7 @@ ...@@ -75,7 +74,7 @@
<org.chromium.chrome.browser.widget.TintedImageButton <org.chromium.chrome.browser.widget.TintedImageButton
android:id="@+id/password_entry_editor_copy_password" android:id="@+id/password_entry_editor_copy_password"
android:background="@null" android:background="?attr/selectableItemBackground"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="end" android:layout_gravity="end"
...@@ -88,8 +87,7 @@ ...@@ -88,8 +87,7 @@
<TextView <TextView
android:id="@+id/passwords_link" android:id="@+id/passwords_link"
android:textAppearance="?android:attr/textAppearanceMedium" android:textAppearance="@style/TextAppearance.PreferenceMediumText"
android:textColor="@color/default_text_color"
android:layout_width="fill_parent" android:layout_width="fill_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="15dp" android:layout_marginTop="15dp"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment