Commit c465a3ee authored by Nnamdi Theodore Johnson-Kanu's avatar Nnamdi Theodore Johnson-Kanu Committed by Commit Bot

[CrOS settings] Fix polymer_modulizer for os_settings_main/

This CL is in preparation for enabling Polymer3 in ChromeOS settings
pages. It uncomments polymer_modulizer build target and makes sure
Polymer3 modules can be generated from js files.

Bug: 1045266
Change-Id: I8570053b3aa043b180078dd69286f4db51acd898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153305
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760328}
parent 3e692fc9
...@@ -29,14 +29,13 @@ js_library("os_settings_main") { ...@@ -29,14 +29,13 @@ js_library("os_settings_main") {
# ] # ]
#} #}
# TODO: Fix and re-enable js_library("os_settings_main.m") {
#js_library("os_settings_main.m") { sources = [ "$root_gen_dir/chrome/browser/resources/settings/chromeos/os_settings_main/os_settings_main.m.js" ]
# sources = [ "$root_gen_dir/chrome/browser/resources/settings/chromeos/os_settings_main/os_settings_main.m.js" ] deps = [
# deps = [ # TODO: Fill those in.
# # TODO: Fill those in. ]
# ] extra_deps = [ ":os_settings_main_module" ]
# extra_deps = [ ":os_settings_main_module" ] }
#}
import("//tools/polymer/polymer.gni") import("//tools/polymer/polymer.gni")
...@@ -46,9 +45,9 @@ group("polymer3_elements") { ...@@ -46,9 +45,9 @@ group("polymer3_elements") {
#":os_settings_main_module" #":os_settings_main_module"
] ]
} }
# TODO: Fix and re-enable
#polymer_modulizer("os_settings_main") { polymer_modulizer("os_settings_main") {
# js_file = "os_settings_main.js" js_file = "os_settings_main.js"
# html_file = "os_settings_main.html" html_file = "os_settings_main.html"
# html_type = "dom-module" html_type = "dom-module"
#} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment