Commit c4a34955 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /components/password_manager.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug: 925652
Change-Id: If24a3cab76df609b0452d6bf785d4c42f4ff67c9
Reviewed-on: https://chromium-review.googlesource.com/c/1437823
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626483}
parent 647772eb
...@@ -243,7 +243,7 @@ TEST_F(ContentPasswordManagerDriverTest, NotInformAboutBlacklistedForm) { ...@@ -243,7 +243,7 @@ TEST_F(ContentPasswordManagerDriverTest, NotInformAboutBlacklistedForm) {
driver->FillPasswordForm(fill_data); driver->FillPasswordForm(fill_data);
} }
INSTANTIATE_TEST_CASE_P(, INSTANTIATE_TEST_SUITE_P(,
ContentPasswordManagerDriverTest, ContentPasswordManagerDriverTest,
testing::Values(true, false)); testing::Values(true, false));
......
...@@ -239,7 +239,7 @@ TEST_P(HttpCredentialCleanerTest, ReportHttpMigrationMetrics) { ...@@ -239,7 +239,7 @@ TEST_P(HttpCredentialCleanerTest, ReportHttpMigrationMetrics) {
scoped_task_environment.RunUntilIdle(); scoped_task_environment.RunUntilIdle();
} }
INSTANTIATE_TEST_CASE_P(, INSTANTIATE_TEST_SUITE_P(,
HttpCredentialCleanerTest, HttpCredentialCleanerTest,
::testing::ValuesIn(kCases)); ::testing::ValuesIn(kCases));
......
...@@ -2192,13 +2192,13 @@ TEST_P(LoginDatabaseMigrationTestBroken, Broken) { ...@@ -2192,13 +2192,13 @@ TEST_P(LoginDatabaseMigrationTestBroken, Broken) {
MigrationToVCurrent(base::StringPrintf("login_db_v%d_broken.sql", version())); MigrationToVCurrent(base::StringPrintf("login_db_v%d_broken.sql", version()));
} }
INSTANTIATE_TEST_CASE_P(MigrationToVCurrent, INSTANTIATE_TEST_SUITE_P(MigrationToVCurrent,
LoginDatabaseMigrationTest, LoginDatabaseMigrationTest,
testing::Range(1, kCurrentVersionNumber + 1)); testing::Range(1, kCurrentVersionNumber + 1));
INSTANTIATE_TEST_CASE_P(MigrationToVCurrent, INSTANTIATE_TEST_SUITE_P(MigrationToVCurrent,
LoginDatabaseMigrationTestV9, LoginDatabaseMigrationTestV9,
testing::Values(9)); testing::Values(9));
INSTANTIATE_TEST_CASE_P(MigrationToVCurrent, INSTANTIATE_TEST_SUITE_P(MigrationToVCurrent,
LoginDatabaseMigrationTestBroken, LoginDatabaseMigrationTestBroken,
testing::Range(1, 4)); testing::Range(1, 4));
......
...@@ -158,7 +158,7 @@ base::FilePath PasswordStoreDefaultTestDelegate::test_login_db_file_path() ...@@ -158,7 +158,7 @@ base::FilePath PasswordStoreDefaultTestDelegate::test_login_db_file_path()
} // anonymous namespace } // anonymous namespace
INSTANTIATE_TYPED_TEST_CASE_P(Default, INSTANTIATE_TYPED_TEST_SUITE_P(Default,
PasswordStoreOriginTest, PasswordStoreOriginTest,
PasswordStoreDefaultTestDelegate); PasswordStoreDefaultTestDelegate);
......
...@@ -59,7 +59,7 @@ class PasswordStoreOriginTest : public testing::Test { ...@@ -59,7 +59,7 @@ class PasswordStoreOriginTest : public testing::Test {
T delegate_; T delegate_;
}; };
TYPED_TEST_CASE_P(PasswordStoreOriginTest); TYPED_TEST_SUITE_P(PasswordStoreOriginTest);
TYPED_TEST_P(PasswordStoreOriginTest, TYPED_TEST_P(PasswordStoreOriginTest,
RemoveLoginsByURLAndTimeImpl_AllFittingOriginAndTime) { RemoveLoginsByURLAndTimeImpl_AllFittingOriginAndTime) {
...@@ -162,7 +162,7 @@ TYPED_TEST_P(PasswordStoreOriginTest, ...@@ -162,7 +162,7 @@ TYPED_TEST_P(PasswordStoreOriginTest,
this->delegate_.store()->RemoveObserver(&observer); this->delegate_.store()->RemoveObserver(&observer);
} }
REGISTER_TYPED_TEST_CASE_P( REGISTER_TYPED_TEST_SUITE_P(
PasswordStoreOriginTest, PasswordStoreOriginTest,
RemoveLoginsByURLAndTimeImpl_AllFittingOriginAndTime, RemoveLoginsByURLAndTimeImpl_AllFittingOriginAndTime,
RemoveLoginsByURLAndTimeImpl_SomeFittingOriginAndTime, RemoveLoginsByURLAndTimeImpl_SomeFittingOriginAndTime,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment