Commit c512a2c3 authored by ggaren@apple.com's avatar ggaren@apple.com

2011-03-13 Geoffrey Garen <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed another case of DeprecatedPtr (PutPropertySlot)
        https://bugs.webkit.org/show_bug.cgi?id=56278

        * runtime/PutPropertySlot.h:
        (JSC::PutPropertySlot::setExistingProperty):
        (JSC::PutPropertySlot::setNewProperty):
        (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
        since it's a stack-allocated temporary.


git-svn-id: svn://svn.chromium.org/blink/trunk@80980 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent dd32eb6e
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another case of DeprecatedPtr (PutPropertySlot)
https://bugs.webkit.org/show_bug.cgi?id=56278
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
since it's a stack-allocated temporary.
2011-03-13 Geoffrey Garen <ggaren@apple.com> 2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt. Reviewed by Oliver Hunt.
......
...@@ -45,14 +45,14 @@ namespace JSC { ...@@ -45,14 +45,14 @@ namespace JSC {
{ {
} }
void setExistingProperty(DeprecatedPtr<JSObject> base, size_t offset) void setExistingProperty(JSObject* base, size_t offset)
{ {
m_type = ExistingProperty; m_type = ExistingProperty;
m_base = base; m_base = base;
m_offset = offset; m_offset = offset;
} }
void setNewProperty(DeprecatedPtr<JSObject> base, size_t offset) void setNewProperty(JSObject* base, size_t offset)
{ {
m_type = NewProperty; m_type = NewProperty;
m_base = base; m_base = base;
...@@ -60,7 +60,7 @@ namespace JSC { ...@@ -60,7 +60,7 @@ namespace JSC {
} }
Type type() const { return m_type; } Type type() const { return m_type; }
JSObject* base() const { return m_base.get(); } JSObject* base() const { return m_base; }
bool isStrictMode() const { return m_isStrictMode; } bool isStrictMode() const { return m_isStrictMode; }
bool isCacheable() const { return m_type != Uncachable; } bool isCacheable() const { return m_type != Uncachable; }
...@@ -68,9 +68,10 @@ namespace JSC { ...@@ -68,9 +68,10 @@ namespace JSC {
ASSERT(isCacheable()); ASSERT(isCacheable());
return m_offset; return m_offset;
} }
private: private:
Type m_type; Type m_type;
DeprecatedPtr<JSObject> m_base; JSObject* m_base;
size_t m_offset; size_t m_offset;
bool m_isStrictMode; bool m_isStrictMode;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment