Add NotAllowed and InsufficientData metrics for assistive features.

Bug: 1156385
Test: passed unit tests and browser tests.
Change-Id: Iae354b3c46757441ff1cf7f52cd715f831a0213e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577113Reviewed-by: John Palmer <jopalmer@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835879}

chrome/browser/chromeos/input_method/assistive_suggester.cc

@@ -130,6 +130,10 @@ void RecordAssistiveUserPrefForEmoji(bool value) {
   base::UmaHistogramBoolean("InputMethod.Assistive.UserPref.Emoji", value);
 }
 
+void RecordAssistiveNotAllowed(AssistiveType type) {
+  base::UmaHistogramEnumeration("InputMethod.Assistive.NotAllowed", type);
+}
+
 void RecordAssistiveCoverage(AssistiveType type) {
   base::UmaHistogramEnumeration("InputMethod.Assistive.Coverage", type);
 }
@@ -338,8 +342,11 @@ bool AssistiveSuggester::OnKeyEvent(const ui::KeyEvent& event) {
 void AssistiveSuggester::RecordAssistiveMatchMetricsForAction(
     AssistiveType action) {
   RecordAssistiveMatch(action);
-  if (!IsActionEnabled(action))
+  if (!IsActionEnabled(action)) {
     RecordAssistiveDisabled(action);
+  } else if (!IsAllowedUrlOrAppForEmojiSuggestion()) {
+    RecordAssistiveNotAllowed(action);
+  }
 }
 
 void AssistiveSuggester::RecordAssistiveMatchMetrics(const base::string16& text,

chrome/browser/chromeos/input_method/native_input_method_engine_browsertest.cc

@@ -493,12 +493,22 @@ IN_PROC_BROWSER_TEST_F(NativeInputMethodEngineTest,
                        PersonalInfoDisabledReasonkUrlOrAppNotAllowed) {
   base::HistogramTester histogram_tester;
 
+  histogram_tester.ExpectUniqueSample(
+      "InputMethod.Assistive.Disabled.PersonalInfo",
+      DisabledReason::kUrlOrAppNotAllowed, 0);
+  histogram_tester.ExpectUniqueSample("InputMethod.Assistive.NotAllowed",
+                                      chromeos::AssistiveType::kPersonalName,
+                                      0);
+
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
   ui_test_utils::SendToOmniboxAndSubmit(browser(), "my name is ");
 
   histogram_tester.ExpectUniqueSample(
       "InputMethod.Assistive.Disabled.PersonalInfo",
       DisabledReason::kUrlOrAppNotAllowed, 1);
+  histogram_tester.ExpectUniqueSample("InputMethod.Assistive.NotAllowed",
+                                      chromeos::AssistiveType::kPersonalName,
+                                      1);
 }
 
 IN_PROC_BROWSER_TEST_F(NativeInputMethodEngineTest, SuggestEmoji) {

chrome/browser/chromeos/input_method/personal_info_suggester.cc

@@ -93,6 +93,10 @@ void RecordTimeToDismiss(base::TimeDelta delta) {
                           delta);
 }
 
+void RecordAssistiveInsufficientData(AssistiveType type) {
+  base::UmaHistogramEnumeration("InputMethod.Assistive.InsufficientData", type);
+}
+
 }  // namespace
 
 AssistiveType ProposePersonalInfoAssistiveAction(const base::string16& text) {
@@ -253,8 +257,12 @@ bool PersonalInfoSuggester::Suggest(const base::string16& text) {
     return matched;
   } else {
     suggestion_ = GetSuggestion(text);
-    if (!suggestion_.empty())
+    if (suggestion_.empty()) {
+      if (proposed_action_type_ != AssistiveType::kGenericAction)
+        RecordAssistiveInsufficientData(proposed_action_type_);
+    } else {
       ShowSuggestion(suggestion_, 0);
+    }
     return suggestion_shown_;
   }
 }

chrome/browser/chromeos/input_method/personal_info_suggester_unittest.cc

@@ -293,6 +293,26 @@ TEST_F(PersonalInfoSuggesterTest, SuggestNames) {
   suggestion_handler_->VerifySuggestion(full_name_, 0);
 }
 
+TEST_F(PersonalInfoSuggesterTest, SuggestNamesButInsufficientData) {
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitWithFeatures(
+      /*enabled_features=*/{chromeos::features::kAssistPersonalInfoName},
+      /*disabled_features=*/{});
+  autofill::AutofillProfile autofill_profile(base::GenerateGUID(),
+                                             autofill::test::kEmptyOrigin);
+  personal_data_->AddProfile(autofill_profile);
+
+  base::HistogramTester histogram_tester;
+  histogram_tester.ExpectUniqueSample("InputMethod.Assistive.InsufficientData",
+                                      chromeos::AssistiveType::kPersonalName,
+                                      0);
+
+  suggester_->Suggest(base::UTF8ToUTF16("my name is "));
+  histogram_tester.ExpectUniqueSample("InputMethod.Assistive.InsufficientData",
+                                      chromeos::AssistiveType::kPersonalName,
+                                      1);
+}
+
 TEST_F(PersonalInfoSuggesterTest, DoNotSuggestNamesWhenFlagIsDisabled) {
   base::test::ScopedFeatureList feature_list;
   feature_list.InitWithFeatures(

tools/metrics/histograms/histograms_xml/input/histograms.xml

@@ -121,6 +121,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
   </summary>
 </histogram>
 
+<histogram name="InputMethod.Assistive.InsufficientData"
+    enum="IMEAssistiveAction" expires_after="2021-05-16">
+  <owner>jiwan@google.com</owner>
+  <owner>essential-inputs-team@google.com</owner>
+  <summary>
+    The number of times each assistive action could be triggered but there is
+    insufficient data to generate the suggestion. Recorded when we failed to
+    generate suggestions because of insufficient data.
+  </summary>
+</histogram>
+
 <histogram name="InputMethod.Assistive.Match" enum="IMEAssistiveAction"
     expires_after="2021-05-16">
   <owner>jiwan@google.com</owner>
@@ -134,6 +145,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
   </summary>
 </histogram>
 
+<histogram name="InputMethod.Assistive.NotAllowed" enum="IMEAssistiveAction"
+    expires_after="2021-05-16">
+  <owner>jiwan@google.com</owner>
+  <owner>essential-inputs-team@google.com</owner>
+  <summary>
+    The number of times each assistive action could be triggered but is blocked
+    because the text is not in the allowed websites or apps. Recorded when the
+    assistive action is blocked because the text is not in the allowed websites
+    or apps.
+  </summary>
+</histogram>
+
 <histogram name="InputMethod.Assistive.Success" enum="IMEAssistiveAction"
     expires_after="2021-05-16">
   <owner>jiwan@google.com</owner>