Commit c788f0a7 authored by Melissa Zhang's avatar Melissa Zhang Committed by Commit Bot

Revert "[Sharesheet] Record ShareAction invocations."

This reverts commit a1ce46be.

Reason for revert: Need to add new enum to enums.xml.

Original change's description:
> [Sharesheet] Record ShareAction invocations.
>
> Bug: 1148694
> Change-Id: I2843e2c39c3ad5229b45b5889a76cb93b1795689
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537505
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Auto-Submit: Melissa Zhang <melzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827325}

TBR=avi@chromium.org,melzhang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1148694
Change-Id: I02b569aed30b452093cb3dc1e5020ec8f0282e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551899Reviewed-by: default avatarMelissa Zhang <melzhang@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830092}
parent 47bc7c65
...@@ -14,8 +14,7 @@ class SharesheetMetrics { ...@@ -14,8 +14,7 @@ class SharesheetMetrics {
enum class UserAction { enum class UserAction {
kCancelled = 0, // User cancelled sharesheet. kCancelled = 0, // User cancelled sharesheet.
kArc, // Opened an ARC app. kArc, // Opened an ARC app.
kAction, // User selected an action. kMaxValue = kArc,
kMaxValue = kAction,
}; };
SharesheetMetrics(); SharesheetMetrics();
......
...@@ -86,8 +86,6 @@ void SharesheetService::OnTargetSelected(uint32_t delegate_id, ...@@ -86,8 +86,6 @@ void SharesheetService::OnTargetSelected(uint32_t delegate_id,
sharesheet_action_cache_->GetActionFromName(target_name); sharesheet_action_cache_->GetActionFromName(target_name);
if (share_action == nullptr) if (share_action == nullptr)
return; return;
sharesheet::SharesheetMetrics::RecordSharesheetActionMetrics(
sharesheet::SharesheetMetrics::UserAction::kAction);
delegate->OnActionLaunched(); delegate->OnActionLaunched();
share_action->LaunchAction(delegate, share_action_view, std::move(intent)); share_action->LaunchAction(delegate, share_action_view, std::move(intent));
} else if (type == TargetType::kApp) { } else if (type == TargetType::kApp) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment