Commit c800a79f authored by Abhijeet Kandalkar's avatar Abhijeet Kandalkar Committed by Commit Bot

Use new downcast helper for blink::SVGLinearGradientElement

This CL has two goals,
  1. Use To<SVGLinearGradientElement> as new downcast helper
  2. Use IsA<SVGLinearGradientElement>(element) in place of
   IsSVGLinearGradientElement(element)

Bug: 891908
Change-Id: I3f775ab96a3fab152b797aa29d9f7db3ae962b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936609Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719595}
parent 5cf595c7
...@@ -36,7 +36,7 @@ LayoutSVGResourceLinearGradient::~LayoutSVGResourceLinearGradient() = default; ...@@ -36,7 +36,7 @@ LayoutSVGResourceLinearGradient::~LayoutSVGResourceLinearGradient() = default;
bool LayoutSVGResourceLinearGradient::CollectGradientAttributes() { bool LayoutSVGResourceLinearGradient::CollectGradientAttributes() {
DCHECK(GetElement()); DCHECK(GetElement());
attributes_wrapper_->Set(LinearGradientAttributes()); attributes_wrapper_->Set(LinearGradientAttributes());
return ToSVGLinearGradientElement(GetElement()) return To<SVGLinearGradientElement>(GetElement())
->CollectGradientAttributes(MutableAttributes()); ->CollectGradientAttributes(MutableAttributes());
} }
......
...@@ -614,7 +614,7 @@ void WriteSVGResourceContainer(WTF::TextStream& ts, ...@@ -614,7 +614,7 @@ void WriteSVGResourceContainer(WTF::TextStream& ts,
// gradients using xlink:href, we need to build the full inheritance chain, // gradients using xlink:href, we need to build the full inheritance chain,
// aka. collectGradientProperties() // aka. collectGradientProperties()
LinearGradientAttributes attributes; LinearGradientAttributes attributes;
ToSVGLinearGradientElement(gradient->GetElement()) To<SVGLinearGradientElement>(gradient->GetElement())
->CollectGradientAttributes(attributes); ->CollectGradientAttributes(attributes);
WriteCommonGradientProperties(ts, attributes); WriteCommonGradientProperties(ts, attributes);
......
...@@ -96,7 +96,7 @@ static void SetGradientAttributes(const SVGGradientElement& element, ...@@ -96,7 +96,7 @@ static void SetGradientAttributes(const SVGGradientElement& element,
if (!is_linear) if (!is_linear)
return; return;
const SVGLinearGradientElement& linear = ToSVGLinearGradientElement(element); const auto& linear = To<SVGLinearGradientElement>(element);
if (!attributes.HasX1() && linear.x1()->IsSpecified()) if (!attributes.HasX1() && linear.x1()->IsSpecified())
attributes.SetX1(linear.x1()->CurrentValue()); attributes.SetX1(linear.x1()->CurrentValue());
...@@ -120,7 +120,7 @@ bool SVGLinearGradientElement::CollectGradientAttributes( ...@@ -120,7 +120,7 @@ bool SVGLinearGradientElement::CollectGradientAttributes(
while (true) { while (true) {
SetGradientAttributes(*current, attributes, SetGradientAttributes(*current, attributes,
IsSVGLinearGradientElement(*current)); IsA<SVGLinearGradientElement>(*current));
visited.insert(current); visited.insert(current);
current = current->ReferencedElement(); current = current->ReferencedElement();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment