Commit c83497e1 authored by Lily Chen's avatar Lily Chen Committed by Commit Bot

Use CookieOptions::MakeAllInclusive in ChromeOS EnrollmentScreenHandler

This code was previously using a CookieOptions that would exclude
SameSite cookies. This could be a problem when cookies become SameSite
by default, so this change switches this to use a CookieOptions that
includes all cookies.

Bug: None
Change-Id: I29fdc5d05f0b6995e283104abb14729afc0a205a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849772Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705087}
parent 07192d53
...@@ -788,11 +788,10 @@ void EnrollmentScreenHandler::HandleCompleteLogin(const std::string& user) { ...@@ -788,11 +788,10 @@ void EnrollmentScreenHandler::HandleCompleteLogin(const std::string& user) {
Profile::FromWebUI(web_ui())); Profile::FromWebUI(web_ui()));
content::StoragePartition* partition = content::StoragePartition* partition =
signin_partition_manager->GetCurrentStoragePartition(); signin_partition_manager->GetCurrentStoragePartition();
net::CookieOptions cookie_options;
cookie_options.set_include_httponly();
partition->GetCookieManagerForBrowserProcess()->GetCookieList( partition->GetCookieManagerForBrowserProcess()->GetCookieList(
GaiaUrls::GetInstance()->gaia_url(), cookie_options, GaiaUrls::GetInstance()->gaia_url(),
net::CookieOptions::MakeAllInclusive(),
base::BindOnce(&EnrollmentScreenHandler::OnGetCookiesForCompleteLogin, base::BindOnce(&EnrollmentScreenHandler::OnGetCookiesForCompleteLogin,
weak_ptr_factory_.GetWeakPtr(), user)); weak_ptr_factory_.GetWeakPtr(), user));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment