Commit c8c3d8e8 authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

[LayoutNG] Not to fix line-height quirks for negative ascent/descent

This patch changes a test to non-quirks mode, that hits
not-defined, non-interoperable line-height quirks.

When all characters on a line is above baseline or below
baseline, by applying e.g., 'vertical-align: 1em' or
'line-height: 0':
* Blink/WebKit assumes the baseline is part of line-height,
  except for atomic inlines.
* Gecko does not include baseline to line-height.
* Edge always include baseline to line-height.
* This problem appears only in line-height quirks mode,
  because otherwise we have a strut that includes baseline.

It's not hard to fix this, but does not seem to worth. We can
revisit if webcompat proves this is necessary.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I46fa04beae3f216a9293d029520cff69e8e63656
Reviewed-on: https://chromium-review.googlesource.com/1065751
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567954}
parent 5c8a944c
......@@ -466,7 +466,6 @@ crbug.com/591099 fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html [ F
crbug.com/591099 fast/css/text-overflow-ellipsis-vertical-hittest.html [ Failure ]
crbug.com/591099 fast/css/text-overflow-ellipsis-vertical-select.html [ Failure ]
crbug.com/591099 fast/css/transform-inline-style-remove.html [ Failure ]
crbug.com/591099 fast/css/vertical-align-lengths.html [ Failure ]
crbug.com/591099 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html [ Failure ]
crbug.com/591099 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html [ Failure ]
crbug.com/591099 fast/css3-text/css3-text-indent/negative-text-indent-leading-out-of-flow-text-align-left-and-right.html [ Failure ]
......
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x196
LayoutNGBlockFlow {HTML} at (0,0) size 800x196
LayoutNGBlockFlow {BODY} at (8,8) size 784x180
LayoutInline {B} at (0,0) size 96x139
LayoutText {#text} at (0,40) size 24x19
text run at (0,40) width 24: "___"
LayoutInline {B} at (0,0) size 72x99
LayoutText {#text} at (24,80) size 24x19
text run at (24,80) width 24: "___"
LayoutInline {B} at (0,0) size 48x59
LayoutText {#text} at (48,120) size 24x19
text run at (48,120) width 24: "___"
LayoutInline {B} at (0,0) size 24x19
LayoutText {#text} at (72,160) size 24x19
text run at (72,160) width 24: "___"
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
LayoutBlockFlow {HTML} at (0,0) size 800x600
LayoutBlockFlow {BODY} at (8,8) size 784x584
layer at (0,0) size 800x194
LayoutBlockFlow {HTML} at (0,0) size 800x194
LayoutBlockFlow {BODY} at (8,8) size 784x178
LayoutInline {B} at (0,0) size 96x18
LayoutText {#text} at (0,26) size 24x18
text run at (0,26) width 24: "___"
LayoutText {#text} at (0,40) size 24x18
text run at (0,40) width 24: "___"
LayoutInline {B} at (0,0) size 72x18
LayoutText {#text} at (24,66) size 24x18
text run at (24,66) width 24: "___"
LayoutText {#text} at (24,80) size 24x18
text run at (24,80) width 24: "___"
LayoutInline {B} at (0,0) size 48x18
LayoutText {#text} at (48,106) size 24x18
text run at (48,106) width 24: "___"
LayoutText {#text} at (48,120) size 24x18
text run at (48,120) width 24: "___"
LayoutInline {B} at (0,0) size 24x18
LayoutText {#text} at (72,146) size 24x18
text run at (72,146) width 24: "___"
LayoutText {#text} at (72,160) size 24x18
text run at (72,160) width 24: "___"
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
LayoutBlockFlow {HTML} at (0,0) size 800x600
LayoutBlockFlow {BODY} at (8,8) size 784x584
layer at (0,0) size 800x196
LayoutBlockFlow {HTML} at (0,0) size 800x196
LayoutBlockFlow {BODY} at (8,8) size 784x180
LayoutInline {B} at (0,0) size 96x19
LayoutText {#text} at (0,25) size 24x19
text run at (0,25) width 24: "___"
LayoutText {#text} at (0,40) size 24x19
text run at (0,40) width 24: "___"
LayoutInline {B} at (0,0) size 72x19
LayoutText {#text} at (24,65) size 24x19
text run at (24,65) width 24: "___"
LayoutText {#text} at (24,80) size 24x19
text run at (24,80) width 24: "___"
LayoutInline {B} at (0,0) size 48x19
LayoutText {#text} at (48,105) size 24x19
text run at (48,105) width 24: "___"
LayoutText {#text} at (48,120) size 24x19
text run at (48,120) width 24: "___"
LayoutInline {B} at (0,0) size 24x19
LayoutText {#text} at (72,145) size 24x19
text run at (72,145) width 24: "___"
LayoutText {#text} at (72,160) size 24x19
text run at (72,160) width 24: "___"
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment