Fix use-after-move in //content/browser/background_fetch/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Ic193475f84e8f43193ad141477a5265ea81e458f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382077Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803470}

content/browser/background_fetch/background_fetch_data_manager_unittest.cc

@@ -2327,8 +2327,6 @@ TEST_F(BackgroundFetchDataManagerTest, CreateInParallel) {
   ASSERT_NE(blink::mojom::kInvalidServiceWorkerRegistrationId,
             service_worker_registration_id);
 
-  std::vector<blink::mojom::FetchAPIRequestPtr> requests =
-      CreateValidRequests(origin());
   auto options = blink::mojom::BackgroundFetchOptions::New();
 
   std::vector<blink::mojom::BackgroundFetchError> errors(5);
@@ -2343,6 +2341,8 @@ TEST_F(BackgroundFetchDataManagerTest, CreateInParallel) {
       base::BarrierClosure(num_parallel_creates, run_loop.QuitClosure());
 
   for (int i = 0; i < num_parallel_creates; i++) {
+    std::vector<blink::mojom::FetchAPIRequestPtr> requests =
+        CreateValidRequests(origin());
     // New |unique_id| per iteration, since each is a distinct registration.
     BackgroundFetchRegistrationId registration_id(
         service_worker_registration_id, origin(), kExampleDeveloperId,

content/browser/background_fetch/background_fetch_event_dispatcher.cc

@@ -113,7 +113,7 @@ void BackgroundFetchEventDispatcher::DispatchBackgroundFetchCompletionEvent(
   auto registration = blink::mojom::BackgroundFetchRegistration::New(
       std::move(registration_data),
       BackgroundFetchRegistrationServiceImpl::CreateInterfaceInfo(
-          std::move(registration_id), background_fetch_context_->GetWeakPtr()));
+          registration_id, background_fetch_context_->GetWeakPtr()));
 
   switch (registration->registration_data->failure_reason) {
     case blink::mojom::BackgroundFetchFailureReason::NONE:
@@ -184,7 +184,7 @@ void BackgroundFetchEventDispatcher::DispatchBackgroundFetchClickEvent(
   auto registration = blink::mojom::BackgroundFetchRegistration::New(
       std::move(registration_data),
       BackgroundFetchRegistrationServiceImpl::CreateInterfaceInfo(
-          std::move(registration_id), background_fetch_context_->GetWeakPtr()));
+          registration_id, background_fetch_context_->GetWeakPtr()));
 
   LoadServiceWorkerRegistrationForDispatch(
       registration_id, ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_CLICK,

content/browser/background_fetch/storage/mark_request_complete_task.cc

@@ -193,8 +193,9 @@ void MarkRequestCompleteTask::DidOpenCache(
 
   // TODO(crbug.com/774054): The request blob stored in the cache is being
   // overwritten here, it should be written back.
-  handle.value()->Put(
-      std::move(request), BackgroundFetchSettledFetch::CloneResponse(response_),
+  CacheStorageCache* handle_ptr = handle.value();
+  handle_ptr->Put(std::move(request),
+                  BackgroundFetchSettledFetch::CloneResponse(response_),
                   trace_id,
                   base::BindOnce(&MarkRequestCompleteTask::DidWriteToCache,
                                  weak_factory_.GetWeakPtr(), std::move(handle),