Move optional to dictionary instead of on transfer.

Mozilla has requested changes to the IDL and either format is identical
for Chrome (after we've shipped). They weren't when it was optional.

BUG=899734

Change-Id: I85dc7e27c4dc77f5f6443e6ba212f4835ba30e77
Reviewed-on: https://chromium-review.googlesource.com/c/1304615Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604280}

third_party/blink/renderer/core/frame/window.idl

@@ -96,7 +96,7 @@
 
     [CrossOrigin, CallWith=CurrentWindow, RaisesException] void postMessage(any message, USVString targetOrigin, optional sequence<object> transfer = []);
 
-    [CrossOrigin, CallWith=CurrentWindow, RaisesException, RuntimeEnabled=PostMessageOptions] void postMessage(any message, optional WindowPostMessageOptions options);
+    [CrossOrigin, CallWith=CurrentWindow, RaisesException] void postMessage(any message, optional WindowPostMessageOptions options);
 
     // WindowOrWorkerGlobalScope mixin
     // https://html.spec.whatwg.org/#windoworworkerglobalscope-mixin

third_party/blink/renderer/core/messaging/message_port.idl

@@ -32,8 +32,8 @@
     Exposed=(Window,Worker,AudioWorklet),
     Transferable
 ] interface MessagePort : EventTarget {
-    [CallWith=ScriptState, RaisesException, Measure] void postMessage(any message, optional sequence<object> transfer = []);
-    [RuntimeEnabled=PostMessageOptions, CallWith=ScriptState, RaisesException, Measure] void postMessage(any message, PostMessageOptions options);
+    [CallWith=ScriptState, RaisesException, Measure] void postMessage(any message, sequence<object> transfer);
+    [CallWith=ScriptState, RaisesException, Measure] void postMessage(any message, optional PostMessageOptions options);
     [Measure] void start();
     [Measure] void close();
 

third_party/blink/renderer/core/workers/dedicated_worker_global_scope.idl

@@ -36,8 +36,8 @@
 ] interface DedicatedWorkerGlobalScope : WorkerGlobalScope {
     [Replaceable] readonly attribute DOMString name;
 
-    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional sequence<object> transfer = []);
-    [RuntimeEnabled=PostMessageOptions, CallWith=ScriptState, RaisesException] void postMessage(any message, PostMessageOptions options);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, sequence<object> transfer);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional PostMessageOptions options);
 
     void close();
 

third_party/blink/renderer/core/workers/worker.idl

@@ -37,8 +37,8 @@
 ] interface Worker : EventTarget {
     void terminate();
 
-    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional sequence<object> transfer=[]);
-    [RuntimeEnabled=PostMessageOptions, CallWith=ScriptState, RaisesException] void postMessage(any message, PostMessageOptions options);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, sequence<object> transfer);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional PostMessageOptions options);
     attribute EventHandler onmessage;
 };
 

third_party/blink/renderer/modules/service_worker/client.idl

@@ -10,8 +10,8 @@
     readonly attribute USVString url;
     readonly attribute DOMString id;
     readonly attribute ClientType type;
-    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional sequence<object> transfer = []);
-    [RuntimeEnabled=PostMessageOptions, CallWith=ScriptState, RaisesException] void postMessage(any message, PostMessageOptions options);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, sequence<object> transfer);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional PostMessageOptions options);
 
     // FIXME: frameType is non-standard, see https://crbug.com/697110
     [CallWith=ScriptState] readonly attribute ContextFrameType frameType;

third_party/blink/renderer/modules/service_worker/service_worker.idl

@@ -43,8 +43,8 @@ enum ServiceWorkerState {
     SecureContext
 ] interface ServiceWorker : EventTarget {
 
-    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional sequence<object> transfer = []);
-    [RuntimeEnabled=PostMessageOptions, CallWith=ScriptState, RaisesException] void postMessage(any message, PostMessageOptions options);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, sequence<object> transfer);
+    [CallWith=ScriptState, RaisesException] void postMessage(any message, optional PostMessageOptions options);
 
     readonly attribute USVString scriptURL;
     readonly attribute ServiceWorkerState  state;

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -1002,10 +1002,6 @@
       name: "Portals",
       status: "test",
     },
-    {
-      name: "PostMessageOptions",
-      status: "stable",
-    },
     {
       name: "PreciseMemoryInfo",
     },