Commit ca0515b5 authored by Danyao Wang's avatar Danyao Wang Committed by Commit Bot

[Nav Experiment] Re-enable PasswordViewController egtests.

These test failures are not caused by SlimNav. Passing in the correct
flags allow them to pass with --enable-features=SlimNavigationManager.

Bug: 904885
Change-Id: I1d45cd4c68aedd478a04bf02830e2223424b92ba
Reviewed-on: https://chromium-review.googlesource.com/c/1336056Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608121}
parent e30b8321
......@@ -261,10 +261,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the passwords view controller appears on screen.
- (void)testPasswordsViewControllerIsPresented {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -281,10 +277,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the passwords view controller contains the "Manage Passwords..."
// action.
- (void)testPasswordsViewControllerContainsManagePasswordsAction {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -300,10 +292,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the "Manage Passwords..." action works.
- (void)testManagePasswordsActionOpensPasswordSettings {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -323,10 +311,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is not present when presenting UI.
- (void)testPasswordControllerPauses {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// For the search bar to appear in password settings at least one password is
// needed.
SaveExamplePasswordForm();
......@@ -356,10 +340,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after selecting other
// password.
- (void)testPasswordControllerResumes {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// For this test one password is needed.
SaveExamplePasswordForm();
......@@ -402,10 +382,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after dismissing "Other
// Passwords".
- (void)testPasswordControllerResumesWhenOtherPasswordsDismiss {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -440,10 +416,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the
// keyboard icon.
- (void)testKeyboardIconDismissPasswordController {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (IsIPadIdiom()) {
// The keyboard icon is never present in iPads.
return;
......@@ -475,10 +447,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the outside
// the popover on iPad.
- (void)testIPadTappingOutsidePopOverDismissPasswordController {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (!IsIPadIdiom()) {
return;
}
......@@ -511,10 +479,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the
// keyboard.
- (void)testTappingKeyboardDismissPasswordControllerPopOver {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (!IsIPadIdiom()) {
return;
}
......@@ -544,10 +508,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that after switching fields the content size of the table view didn't
// grow.
- (void)testPasswordControllerKeepsRightSize {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -575,10 +535,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller stays on rotation.
- (void)testPasswordControllerSupportsRotation {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -601,10 +557,6 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that content is injected in iframe messaging.
- (void)testPasswordControllerSupportsIFrameMessaging {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Iframe messaging is not supported on iOS < 11.3.
if (!base::ios::IsRunningOnOrLater(11, 3, 0)) {
EARL_GREY_TEST_SKIPPED(@"Skipped for iOS < 11.3");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment