Translate: browser test for Chrome Translate in an isolated world

An browser test which cover whole translate process was disabled tentatively.
This is because now Translate scripts runs inside a v8 isolated world and
it make impossible to run with local testing server.
This change introduce a flag to change the allowed server for XHR, and
make the test enabled again.
Note that this flag is warned by infobar when it is enabled.

BUG=268785
TEST=browser_tests --gtest_filter='Translate*.*'
TBR=hajimehoshi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14180010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215912 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/chrome_content_browser_client.cc

@@ -1473,6 +1473,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
       switches::kRecordMode,
       switches::kSilentDumpOnDCHECK,
       switches::kSpdyProxyAuthOrigin,
+      switches::kTranslateSecurityOrigin,
       switches::kWhitelistedExtensionID,
     };
 

chrome/browser/translate/translate_browsertest.cc

@@ -48,10 +48,16 @@ class TranslateBrowserTest : public InProcessBrowserTest {
   TranslateBrowserTest()
       : https_server_(net::SpawnedTestServer::TYPE_HTTPS,
                       SSLOptions(SSLOptions::CERT_OK),
-                      base::FilePath(kTranslateRoot)) {}
+                      base::FilePath(kTranslateRoot)),
+        infobar_service_(NULL) {}
 
-  virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     ASSERT_TRUE(https_server_.Start());
+    // Setup alternate security origin for testing in order to allow XHR against
+    // local test server. Note that this flag shows a confirm infobar in tests.
+    GURL base_url = GetSecureURL("");
+    command_line->AppendSwitchASCII(switches::kTranslateSecurityOrigin,
+                                    base_url.GetOrigin().spec());
   }
 
  protected:
@@ -65,41 +71,75 @@ class TranslateBrowserTest : public InProcessBrowserTest {
     return https_server_.GetURL(prefix + path);
   }
 
+  TranslateInfoBarDelegate* GetExistingTranslateInfoBarDelegate() {
+    if (!infobar_service_) {
+      content::WebContents* web_contents =
+          browser()->tab_strip_model()->GetActiveWebContents();
+      if (web_contents)
+        infobar_service_ = InfoBarService::FromWebContents(web_contents);
+    }
+    if (!infobar_service_) {
+      EXPECT_TRUE(false) << "infobar service is not available";
+      return NULL;
+    }
+
+    TranslateInfoBarDelegate* delegate = NULL;
+    for (size_t i = 0; i < infobar_service_->infobar_count(); ++i) {
+      // Check if the shown infobar is a confirm infobar coming from the
+      // |kTranslateSecurityOrigin| flag specified in SetUpCommandLine().
+      // This infobar appears in all tests of TranslateBrowserTest and can be
+      // ignored here.
+      ConfirmInfoBarDelegate* confirm =
+          infobar_service_->infobar_at(i)->AsConfirmInfoBarDelegate();
+      if (confirm)
+        continue;
+
+      TranslateInfoBarDelegate* translate =
+        infobar_service_->infobar_at(i)->AsTranslateInfoBarDelegate();
+      if (translate) {
+        EXPECT_FALSE(delegate) << "multiple infobars are shown unexpectedly";
+        delegate = translate;
+        continue;
+      }
+
+      // Other infobar should not be shown.
+      EXPECT_TRUE(delegate);
+    }
+    return delegate;
+  }
+
  private:
   net::SpawnedTestServer https_server_;
+  InfoBarService* infobar_service_;
 
   typedef net::SpawnedTestServer::SSLOptions SSLOptions;
 
   DISALLOW_COPY_AND_ASSIGN(TranslateBrowserTest);
 };
 
-// TODO(toyoshim): This test should be changed to work in an isolated world.
-// See also http://crbug.com/164547 .
-IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, DISABLED_Translate) {
+IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, TranslateInIsolatedWorld) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
+  net::TestURLFetcherFactory factory;
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
-  content::WebContents* web_contents =
-      browser()->tab_strip_model()->GetActiveWebContents();
-  ASSERT_TRUE(web_contents);
-
-  net::TestURLFetcherFactory factory;
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 
   // Setup infobar observer.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
   content::WindowedNotificationObserver infobar(
       chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
       content::NotificationService::AllSources());
 
   // Setup page title observer.
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  ASSERT_TRUE(web_contents);
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -110,9 +150,7 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, DISABLED_Translate) {
   infobar.Wait();
 
   // Perform Chrome Translate.
-  ASSERT_EQ(1U, infobar_service->infobar_count());
-  TranslateInfoBarDelegate* translate =
-      infobar_service->infobar_at(0)->AsTranslateInfoBarDelegate();
+  translate = GetExistingTranslateInfoBarDelegate();
   ASSERT_TRUE(translate);
   translate->Translate();
 
@@ -159,17 +197,14 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTag) {
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -182,8 +217,9 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTag) {
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest,
@@ -196,17 +232,14 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest,
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -219,8 +252,9 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest,
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTagAtOnload) {
@@ -232,17 +266,14 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTagAtOnload) {
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -255,8 +286,9 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTagAtOnload) {
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocation) {
@@ -268,17 +300,14 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocation) {
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -291,8 +320,9 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocation) {
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocationAtOnload) {
@@ -304,17 +334,14 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocationAtOnload) {
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
@@ -327,6 +354,7 @@ IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocationAtOnload) {
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }

chrome/browser/ui/startup/bad_flags_prompt.cc

@@ -36,6 +36,7 @@ void ShowBadFlagsPrompt(Browser* browser) {
     extensions::switches::kExtensionsOnChromeURLs,
     // This parameter should be used only for server side developments.
     switches::kTranslateScriptURL,
+    switches::kTranslateSecurityOrigin,
     NULL
   };
 

chrome/common/chrome_switches.cc

@@ -1398,6 +1398,9 @@ const char kTrackActiveVisitTime[]          = "track-active-visit-time";
 // Overrides the default server used for Google Translate.
 const char kTranslateScriptURL[]            = "translate-script-url";
 
+// Overrides security-origin with which Translate runs in an isolated world.
+const char kTranslateSecurityOrigin[]       = "translate-security-origin";
+
 // Disables same-origin check on HTTP resources pushed via a SPDY proxy.
 // The value is the host:port of the trusted proxy.
 const char kTrustedSpdyProxy[]              = "trusted-spdy-proxy";

chrome/common/chrome_switches.h

@@ -374,6 +374,7 @@ extern const char kTestType[];
 extern const char kTestingChannelID[];
 extern const char kTrackActiveVisitTime[];
 extern const char kTranslateScriptURL[];
+extern const char kTranslateSecurityOrigin[];
 extern const char kTrustedSpdyProxy[];
 extern const char kTryChromeAgain[];
 extern const char kUninstallExtension[];

chrome/renderer/translate/translate_helper.cc

@@ -357,9 +357,15 @@ void TranslateHelper::OnTranslatePage(int page_id,
         chrome::ISOLATED_WORLD_ID_TRANSLATE,
         WebString::fromUTF8(kContentSecurityPolicy));
 
+    std::string security_origin(kSecurityOrigin);
+    CommandLine* command_line = CommandLine::ForCurrentProcess();
+    if (command_line->HasSwitch(switches::kTranslateSecurityOrigin)) {
+      security_origin =
+          command_line->GetSwitchValueASCII(switches::kTranslateSecurityOrigin);
+    }
     frame->setIsolatedWorldSecurityOrigin(
         chrome::ISOLATED_WORLD_ID_TRANSLATE,
-        WebSecurityOrigin::create(GURL(kSecurityOrigin)));
+        WebSecurityOrigin::create(GURL(security_origin)));
   }
 
   if (!IsTranslateLibAvailable()) {

chrome/test/data/translate/fr_test.html

@@ -7,6 +7,9 @@ found in the LICENSE file.
 <head>
   <title>fr_test.html: check if Chrome Translate works</title>
   <meta http-equiv="content-language" content="fr">
+  <meta http-equiv="Content-Security-Policy" content="default-src 'self'">
+  <script>world='ng';</script> <!-- This line doesn't run because of CSP. -->
+  <script src="fr_test.js"></script>
 </head>
 <body>
   <div>bonjour Chrome Translate.</div>

chrome/test/data/translate/fr_test.js

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+if (typeof world != 'undefined') {
+  div_log('CSP doesn\'t work');
+  document.title = 'FAIL';
+  return;
+}
+world='main';