Commit cbdc6dcc authored by Natalie Chouinard's avatar Natalie Chouinard Committed by Commit Bot

[Android] Update java_files build docs

Use of java_files is being deprecated in favor of sources.
Update documentation that still references java_files.

TBR=aluo,bialpio,dpranke,pasko

Bug: 1035082
Change-Id: Ibcab73a9d90e010cdffd3018d3fd238662945f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980981Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727284}
parent 535aad60
...@@ -50,7 +50,7 @@ namespace android { ...@@ -50,7 +50,7 @@ namespace android {
// ] // ]
// } // }
// android_library("java") { // android_library("java") {
// java_files = [ // sources = [
// "java/src/org/chromium/example/jni_generator/SampleForTests.java", // "java/src/org/chromium/example/jni_generator/SampleForTests.java",
// "java/src/org/chromium/example/jni_generator/NonJniFile.java", // "java/src/org/chromium/example/jni_generator/NonJniFile.java",
// ] // ]
......
...@@ -169,9 +169,9 @@ parameterized class. The general things you will need to are: ...@@ -169,9 +169,9 @@ parameterized class. The general things you will need to are:
### Add The New File ### Add The New File
Add the new test class to [`//chrome/android/BUILD.gn`][build_gn]. If it is a VR Add the new test class to [`//chrome/android/BUILD.gn`][build_gn]. If it is a VR
test class, it should be added to the `java_files` list of the test class, it should be added to the `sources` list of the
`chrome_test_vr_java` `android_library` target. If it is an AR test class, it `chrome_test_vr_java` `android_library` target. If it is an AR test class, it
should be added to the `java_files` list of the `chrome_test_ar_java` should be added to the `sources` list of the `chrome_test_ar_java`
`android_library` target. `android_library` target.
## AR Playback Datasets ## AR Playback Datasets
......
...@@ -36,7 +36,7 @@ git checkout -b pagecontroller_codelab ...@@ -36,7 +36,7 @@ git checkout -b pagecontroller_codelab
... ...
android_library("chrome_java_test_pagecontroller") { android_library("chrome_java_test_pagecontroller") {
testonly = true testonly = true
java_files = [ sources = [
... ...
"javatests/src/org/chromium/chrome/test/pagecontroller/controllers/android/PermissionDialog.java", "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/android/PermissionDialog.java",
+ "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/codelab/SearchEngineSelectionControllerForCodelab.java", + "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/codelab/SearchEngineSelectionControllerForCodelab.java",
......
...@@ -256,7 +256,7 @@ public class ChromeMenu extends PageController { ...@@ -256,7 +256,7 @@ public class ChromeMenu extends PageController {
``` ```
android_library("chrome_java_test_pagecontroller") { android_library("chrome_java_test_pagecontroller") {
testonly = true testonly = true
java_files = [ sources = [
... ...
"javatests/src/org/chromium/chrome/test/pagecontroller/controllers/android/PermissionDialog.java", "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/android/PermissionDialog.java",
+ "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/codelab/SettingsControllerForCodelab.java", + "javatests/src/org/chromium/chrome/test/pagecontroller/controllers/codelab/SettingsControllerForCodelab.java",
......
...@@ -242,7 +242,7 @@ import("//chrome/android/features/foo/public/foo_public_java_sources.gni") ...@@ -242,7 +242,7 @@ import("//chrome/android/features/foo/public/foo_public_java_sources.gni")
... ...
android_library("chrome_java") { android_library("chrome_java") {
... ...
java_files += foo_public_java_sources sources += foo_public_java_sources
} }
... ...
``` ```
...@@ -256,7 +256,7 @@ import("//build/config/android/rules.gni") ...@@ -256,7 +256,7 @@ import("//build/config/android/rules.gni")
android_library("java") { android_library("java") {
# Define like ordinary Java Android library. # Define like ordinary Java Android library.
java_files = [ sources = [
"java/src/org/chromium/chrome/features/foo/FooImpl.java", "java/src/org/chromium/chrome/features/foo/FooImpl.java",
# Add other Java classes that should go into the Foo DFM here. # Add other Java classes that should go into the Foo DFM here.
] ]
......
...@@ -117,7 +117,7 @@ target. ...@@ -117,7 +117,7 @@ target.
``` python ``` python
android_library("my_test_service") { android_library("my_test_service") {
java_files = [ "src/org/chromium/chrome/test/MyTestService.java" ] sources = [ "src/org/chromium/chrome/test/MyTestService.java" ]
deps = [ ... ] deps = [ ... ]
} }
``` ```
......
...@@ -108,8 +108,9 @@ public class MyRobolectricJUnitTest { ...@@ -108,8 +108,9 @@ public class MyRobolectricJUnitTest {
```python ```python
junit_binary("my_robolectric_tests") { junit_binary("my_robolectric_tests") {
java_files = [ sources = [
"java/src/foo/bar/MyJUnitTest.java" "java/src/foo/bar/MyJUnitTest.java"
]
deps = [ deps = [
"//my/test:dependency", "//my/test:dependency",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment