Commit cbf81a4a authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Enable "gn check" for //third_party/blink/renderer/platform/scheduler

- Add missing dependencies
- Allow circular includes with renderer/platform:platform
- Expose renderer/platform/heap:heap to scheduler

Bug: 800764
Change-Id: I49a1182125023c65876294e0f4e848f41908b0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394901
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804810}
parent aff23965
...@@ -275,7 +275,6 @@ no_check_targets = [ ...@@ -275,7 +275,6 @@ no_check_targets = [
"//third_party/blink/renderer/platform/instrumentation:*", # 13 errors "//third_party/blink/renderer/platform/instrumentation:*", # 13 errors
"//third_party/blink/renderer/platform/loader:*", # 180 errors "//third_party/blink/renderer/platform/loader:*", # 180 errors
"//third_party/blink/renderer/platform/network:*", # 15 errors "//third_party/blink/renderer/platform/network:*", # 15 errors
"//third_party/blink/renderer/platform/scheduler:*", # 45 errors
"//third_party/blink/renderer/platform:*", # 72 errors "//third_party/blink/renderer/platform:*", # 72 errors
"//third_party/breakpad:*", # 34 errors "//third_party/breakpad:*", # 34 errors
......
...@@ -1559,8 +1559,10 @@ component("platform") { ...@@ -1559,8 +1559,10 @@ component("platform") {
include_dirs = [] include_dirs = []
allow_circular_includes_from = allow_circular_includes_from = [
[ "//third_party/blink/renderer/platform/blob" ] "//third_party/blink/renderer/platform/blob",
"//third_party/blink/renderer/platform/scheduler",
]
public_deps = [ public_deps = [
":blink_platform_public_deps", ":blink_platform_public_deps",
...@@ -1801,6 +1803,7 @@ static_library("test_support") { ...@@ -1801,6 +1803,7 @@ static_library("test_support") {
"//testing/gtest:gtest", "//testing/gtest:gtest",
"//testing/perf", "//testing/perf",
"//third_party/blink/renderer/platform/blob:test_support", "//third_party/blink/renderer/platform/blob:test_support",
"//third_party/blink/renderer/platform/scheduler:test_support",
] ]
deps = [ deps = [
...@@ -1814,7 +1817,6 @@ static_library("test_support") { ...@@ -1814,7 +1817,6 @@ static_library("test_support") {
"//third_party/blink/renderer/platform/heap:test_support", "//third_party/blink/renderer/platform/heap:test_support",
"//third_party/blink/renderer/platform/loader:test_support", "//third_party/blink/renderer/platform/loader:test_support",
"//third_party/blink/renderer/platform/network:test_support", "//third_party/blink/renderer/platform/network:test_support",
"//third_party/blink/renderer/platform/scheduler:test_support",
] ]
if (is_win) { if (is_win) {
......
...@@ -117,6 +117,11 @@ blink_platform_sources("heap") { ...@@ -117,6 +117,11 @@ blink_platform_sources("heap") {
configs -= [ "//build/config/compiler:default_optimization" ] configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ] configs += [ "//build/config/compiler:optimize_max" ]
} }
visibility = [
"//third_party/blink/renderer/platform:platform",
"//third_party/blink/renderer/platform/scheduler:scheduler",
]
} }
source_set("test_support") { source_set("test_support") {
......
...@@ -177,6 +177,7 @@ blink_platform_sources("scheduler") { ...@@ -177,6 +177,7 @@ blink_platform_sources("scheduler") {
"//services/metrics/public/cpp:ukm_builders", "//services/metrics/public/cpp:ukm_builders",
"//services/metrics/public/mojom", "//services/metrics/public/mojom",
"//third_party/blink/renderer/platform:make_platform_generated", "//third_party/blink/renderer/platform:make_platform_generated",
"//third_party/blink/renderer/platform/heap:heap",
"//third_party/blink/renderer/platform/instrumentation", "//third_party/blink/renderer/platform/instrumentation",
"//third_party/blink/renderer/platform/wtf", "//third_party/blink/renderer/platform/wtf",
"//v8", "//v8",
...@@ -205,7 +206,9 @@ source_set("test_support") { ...@@ -205,7 +206,9 @@ source_set("test_support") {
"//mojo/public/cpp/bindings", "//mojo/public/cpp/bindings",
"//skia", "//skia",
"//testing/gmock", "//testing/gmock",
"//third_party/blink/public:test_headers",
"//third_party/blink/public/mojom:mojom_platform_blink_headers", "//third_party/blink/public/mojom:mojom_platform_blink_headers",
"//third_party/blink/renderer/platform:platform",
] ]
configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ] configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ]
...@@ -249,9 +252,11 @@ source_set("unit_tests") { ...@@ -249,9 +252,11 @@ source_set("unit_tests") {
deps = [ deps = [
"//base", "//base",
"//base/test:test_support", "//base/test:test_support",
"//components/ukm:test_support",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/blink/public:test_support", "//third_party/blink/public:test_support",
"//third_party/googletest:gmock",
] ]
configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ] configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ]
...@@ -285,6 +290,7 @@ source_set("scheduler_fuzzer_tests") { ...@@ -285,6 +290,7 @@ source_set("scheduler_fuzzer_tests") {
deps += [ deps += [
":sequence_manager_test_description_proto", ":sequence_manager_test_description_proto",
"//third_party/blink/renderer/platform:platform",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
] ]
} }
...@@ -308,7 +314,9 @@ fuzzer_test("sequence_manager_fuzzer") { ...@@ -308,7 +314,9 @@ fuzzer_test("sequence_manager_fuzzer") {
deps = [ deps = [
":sequence_manager_test_description_proto", ":sequence_manager_test_description_proto",
"//base/test:test_support",
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
"//third_party/blink/renderer/platform:platform",
"//third_party/blink/renderer/platform:test_support", "//third_party/blink/renderer/platform:test_support",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment