Commit cc28e0dc authored by knn's avatar knn Committed by Commit bot

Enable depend on stamp by default for all GN based grit targets.

This is a cleanup change that removes support for the depfile based on
first grit output.

BUG=466315

Review URL: https://codereview.chromium.org/1030383003

Cr-Commit-Position: refs/heads/master@{#322584}
parent c7c6f860
...@@ -24,7 +24,7 @@ COLORAMA_ROOT = os.path.join(CHROMIUM_SRC, ...@@ -24,7 +24,7 @@ COLORAMA_ROOT = os.path.join(CHROMIUM_SRC,
'third_party', 'colorama', 'src') 'third_party', 'colorama', 'src')
# aapt should ignore OWNERS files in addition the default ignore pattern. # aapt should ignore OWNERS files in addition the default ignore pattern.
AAPT_IGNORE_PATTERN = ('!OWNERS:!.svn:!.git:!.ds_store:!*.scc:.*:<dir>_*:' + AAPT_IGNORE_PATTERN = ('!OWNERS:!.svn:!.git:!.ds_store:!*.scc:.*:<dir>_*:' +
'!CVS:!thumbs.db:!picasa.ini:!*~') '!CVS:!thumbs.db:!picasa.ini:!*~:!*.d.stamp')
@contextlib.contextmanager @contextlib.contextmanager
......
...@@ -372,20 +372,8 @@ template("grit") { ...@@ -372,20 +372,8 @@ template("grit") {
script = "//tools/grit/grit.py" script = "//tools/grit/grit.py"
inputs = grit_inputs inputs = grit_inputs
# TODO(knn): Remove this once grit has rolled to recognize the flag.
depend_on_stamp =
defined(invoker.depend_on_stamp) && invoker.depend_on_stamp
if (depend_on_stamp) {
# Need this for migrating existing targets without clobbering.
depfile = "$output_dir/${grit_output_name}_stamp.d" depfile = "$output_dir/${grit_output_name}_stamp.d"
outputs = [ outputs = [ "${depfile}.stamp" ] + grit_outputs
"${depfile}.stamp",
]
} else {
depfile = "$output_dir/${grit_output_name}.d"
outputs = []
}
outputs += grit_outputs
args = [ args = [
"-i", "-i",
...@@ -406,11 +394,8 @@ template("grit") { ...@@ -406,11 +394,8 @@ template("grit") {
"--depfile", "--depfile",
rebase_path(depfile, root_build_dir), rebase_path(depfile, root_build_dir),
"--write-only-new=1", "--write-only-new=1",
] "--depend-on-stamp",
if (depend_on_stamp) { ] + grit_defines
args += [ "--depend-on-stamp" ]
}
args += grit_defines
# Add extra defines with -D flags. # Add extra defines with -D flags.
if (defined(invoker.defines)) { if (defined(invoker.defines)) {
......
...@@ -109,7 +109,6 @@ if (enable_configuration_policy) { ...@@ -109,7 +109,6 @@ if (enable_configuration_policy) {
import("resources/policy_templates.gni") import("resources/policy_templates.gni")
source = "resources/policy_templates.grd" source = "resources/policy_templates.grd"
use_qualified_include = true use_qualified_include = true
depend_on_stamp = true
output_dir = "$root_gen_dir/chrome" output_dir = "$root_gen_dir/chrome"
outputs = policy_templates_doc_outputs outputs = policy_templates_doc_outputs
if (is_android) { if (is_android) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment