Prevents RAF crash with invalid Workers

If BeginFrameProvider is invalid, we should not pass RAF calls.

Bug: 860102
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4bf971316bf93c19d4613f38c413575a0c2be17a
Reviewed-on: https://chromium-review.googlesource.com/1147429Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579046}

third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc

@@ -22,6 +22,10 @@ WorkerAnimationFrameProvider::WorkerAnimationFrameProvider(
 
 int WorkerAnimationFrameProvider::RegisterCallback(
     FrameRequestCallbackCollection::FrameCallback* callback) {
+  if (!begin_frame_provider_->IsValidFrameProvider()) {
+    return WorkerAnimationFrameProvider::kInvalidCallbackId;
+  }
+
   FrameRequestCallbackCollection::CallbackId id =
       callback_collection_.RegisterCallback(callback);
   begin_frame_provider_->RequestBeginFrame();

third_party/blink/renderer/core/workers/worker_animation_frame_provider.h

@@ -48,6 +48,8 @@ class CORE_EXPORT WorkerAnimationFrameProvider
   void RegisterOffscreenCanvas(OffscreenCanvas*);
   void DeregisterOffscreenCanvas(OffscreenCanvas*);
 
+  static const int kInvalidCallbackId = -1;
+
  protected:
   WorkerAnimationFrameProvider(
       ExecutionContext* context,

third_party/blink/renderer/core/workers/worker_global_scope.cc

@@ -405,12 +405,21 @@ void WorkerGlobalScope::RemoveURLFromMemoryCache(const KURL& url) {
                       CrossThreadBind(&RemoveURLFromMemoryCacheInternal, url));
 }
 
-int WorkerGlobalScope::requestAnimationFrame(V8FrameRequestCallback* callback) {
+int WorkerGlobalScope::requestAnimationFrame(V8FrameRequestCallback* callback,
+                                             ExceptionState& exception_state) {
   FrameRequestCallbackCollection::V8FrameCallback* frame_callback =
       FrameRequestCallbackCollection::V8FrameCallback::Create(callback);
   frame_callback->SetUseLegacyTimeBase(true);
 
-  return animation_frame_provider_->RegisterCallback(frame_callback);
+  int ret = animation_frame_provider_->RegisterCallback(frame_callback);
+
+  if (ret == WorkerAnimationFrameProvider::kInvalidCallbackId) {
+    exception_state.ThrowDOMException(
+        DOMExceptionCode::kNotSupportedError,
+        "requestAnimationFrame not supported in this Worker.");
+  }
+
+  return ret;
 }
 
 void WorkerGlobalScope::cancelAnimationFrame(int id) {

third_party/blink/renderer/core/workers/worker_global_scope.h

@@ -150,7 +150,7 @@ class CORE_EXPORT WorkerGlobalScope
   // FontFaceSource on the IDL.
   FontFaceSet* fonts();
 
-  int requestAnimationFrame(V8FrameRequestCallback* callback);
+  int requestAnimationFrame(V8FrameRequestCallback* callback, ExceptionState&);
   void cancelAnimationFrame(int id);
 
   WorkerAnimationFrameProvider* GetAnimationFrameProvider() {

third_party/blink/renderer/core/workers/worker_global_scope.idl

@@ -69,7 +69,7 @@
     // TODO(fserb): temporarly until we can enable the interface below.
     [RuntimeEnabled=OffscreenCanvasText] readonly attribute FontFaceSet fonts;
 
-    [RuntimeEnabled=OffscreenCanvas] long requestAnimationFrame(FrameRequestCallback callback);
+    [RuntimeEnabled=OffscreenCanvas, RaisesException] long requestAnimationFrame(FrameRequestCallback callback);
     [RuntimeEnabled=OffscreenCanvas] void cancelAnimationFrame(long handle);
 };
 

third_party/blink/renderer/platform/graphics/begin_frame_provider.cc

@@ -42,6 +42,14 @@ void BeginFrameProvider::OnMojoConnectionError(uint32_t custom_reason,
   ResetCompositorFrameSink();
 }
 
+bool BeginFrameProvider::IsValidFrameProvider() {
+  if (!parent_frame_sink_id_.is_valid() || !frame_sink_id_.is_valid()) {
+    return false;
+  }
+
+  return true;
+}
+
 void BeginFrameProvider::CreateCompositorFrameSinkIfNeeded() {
   if (!parent_frame_sink_id_.is_valid() || !frame_sink_id_.is_valid()) {
     return;

third_party/blink/renderer/platform/graphics/begin_frame_provider.h

@@ -60,6 +60,8 @@ class PLATFORM_EXPORT BeginFrameProvider
 
   void ResetCompositorFrameSink();
 
+  bool IsValidFrameProvider();
+
   ~BeginFrameProvider() override = default;
 
  private: