Commit ccee000d authored by Paula Vidas's avatar Paula Vidas Committed by Commit Bot

[Sync] Replace about:sync with chrome://sync-internals.

This CL replaces all occurrences of "about:sync" with
"chrome://sync-internals", so the URL is the same everywhere.

Bug: 1137739
Change-Id: I461582da8aa9d809ffe72715d09456fc7818652c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470077Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Paula Vidas <paulavidas@google.com>
Cr-Commit-Position: refs/heads/master@{#817002}
parent efca165a
...@@ -80,8 +80,9 @@ namespace { ...@@ -80,8 +80,9 @@ namespace {
const char kUninitialized[] = "Uninitialized"; const char kUninitialized[] = "Uninitialized";
// This class represents one field in about:sync. It gets serialized into a // This class represents one field in chrome://sync-internals. It gets
// dictionary with entries for 'stat_name', 'stat_value' and 'is_valid'. // serialized into a dictionary with entries for 'stat_name', 'stat_value' and
// 'is_valid'.
class StatBase { class StatBase {
public: public:
base::Value ToValue() const { base::Value ToValue() const {
...@@ -116,8 +117,8 @@ class Stat : public StatBase { ...@@ -116,8 +117,8 @@ class Stat : public StatBase {
void Set(const T& value) { SetFromValue(base::Value(value)); } void Set(const T& value) { SetFromValue(base::Value(value)); }
}; };
// A section for display on about:sync, consisting of a title and a list of // A section for display on chrome://sync-internals, consisting of a title and a
// fields. // list of fields.
class Section { class Section {
public: public:
Section(const std::string& title, bool is_sensitive) Section(const std::string& title, bool is_sensitive)
...@@ -301,9 +302,9 @@ std::string GetConnectionStatus(const SyncTokenStatus& status) { ...@@ -301,9 +302,9 @@ std::string GetConnectionStatus(const SyncTokenStatus& status) {
} // namespace } // namespace
// This function both defines the structure of the message to be returned and // This function both defines the structure of the message to be returned and
// its contents. Most of the message consists of simple fields in about:sync // its contents. Most of the message consists of simple fields in
// which are grouped into sections and populated with the help of the SyncStat // chrome://sync-internals which are grouped into sections and populated with
// classes defined above. // the help of the SyncStat classes defined above.
std::unique_ptr<base::DictionaryValue> ConstructAboutInformation( std::unique_ptr<base::DictionaryValue> ConstructAboutInformation(
IncludeSensitiveData include_sensitive_data, IncludeSensitiveData include_sensitive_data,
SyncService* service, SyncService* service,
......
...@@ -70,7 +70,7 @@ extern const char kTypes[]; ...@@ -70,7 +70,7 @@ extern const char kTypes[];
using IncludeSensitiveData = using IncludeSensitiveData =
util::StrongAlias<class IncludeSensitiveDataTag, bool>; util::StrongAlias<class IncludeSensitiveDataTag, bool>;
// This function returns a DictionaryValue which contains all the information // This function returns a DictionaryValue which contains all the information
// required to populate the 'About' tab of about:sync. // required to populate the 'About' tab of chrome://sync-internals.
// Note that |service| may be null. // Note that |service| may be null.
// If |include_sensitive_data| is false, Personally Identifiable Information // If |include_sensitive_data| is false, Personally Identifiable Information
// won't be included in the return value. // won't be included in the return value.
......
...@@ -419,9 +419,10 @@ class SyncService : public KeyedService { ...@@ -419,9 +419,10 @@ class SyncService : public KeyedService {
// the type's status, and <status> is one of "error", "warning" or "ok" // the type's status, and <status> is one of "error", "warning" or "ok"
// depending on the type's current status. // depending on the type's current status.
// //
// This function is used by about_sync_util.cc to help populate the about:sync // This function is used by about_sync_util.cc to help populate the
// page. It returns a ListValue rather than a DictionaryValue in part to make // chrome://sync-internals page. It returns a ListValue rather than a
// it easier to iterate over its elements when constructing that page. // DictionaryValue in part to make it easier to iterate over its elements when
// constructing that page.
virtual std::unique_ptr<base::Value> GetTypeStatusMapForDebugging() = 0; virtual std::unique_ptr<base::Value> GetTypeStatusMapForDebugging() = 0;
virtual const GURL& GetSyncServiceUrlForDebugging() const = 0; virtual const GURL& GetSyncServiceUrlForDebugging() const = 0;
......
...@@ -20,8 +20,8 @@ namespace syncer { ...@@ -20,8 +20,8 @@ namespace syncer {
// are modelled by {GetUpdates, Commit}x{Request,Response} objects. // are modelled by {GetUpdates, Commit}x{Request,Response} objects.
// //
// These objects are intended to be used for displaying information on // These objects are intended to be used for displaying information on
// about:sync. They should be considered to be immutable and opaque. No // chrome://sync-internals. They should be considered to be immutable and
// program behavior should depend on their contents. // opaque. No program behavior should depend on their contents.
// //
// Each type of request can maintain its own set of additional metadata and have // Each type of request can maintain its own set of additional metadata and have
// its own custom serialization routines. For example, the "configure" // its own custom serialization routines. For example, the "configure"
......
...@@ -31,8 +31,8 @@ class SyncEngineHost { ...@@ -31,8 +31,8 @@ class SyncEngineHost {
// process changes. If success is false, initialization wasn't able to be // process changes. If success is false, initialization wasn't able to be
// completed and should be retried. // completed and should be retried.
// //
// |js_backend| is what about:sync interacts with. It is initialized only if // |js_backend| is what chrome://sync-internals interacts with. It is
// |success| is true. // initialized only if |success| is true.
virtual void OnEngineInitialized( virtual void OnEngineInitialized(
ModelTypeSet initial_types, ModelTypeSet initial_types,
......
...@@ -21,7 +21,7 @@ namespace syncer { ...@@ -21,7 +21,7 @@ namespace syncer {
// This struct is closely tied to the AllStatus object which uses instances of // This struct is closely tied to the AllStatus object which uses instances of
// it to track and report on the sync engine's internal state, and the functions // it to track and report on the sync engine's internal state, and the functions
// in sync_ui_util.cc which convert the contents of this struct into a // in sync_ui_util.cc which convert the contents of this struct into a
// DictionaryValue used to populate the about:sync summary tab. // DictionaryValue used to populate the chrome://sync-internals summary tab.
struct SyncStatus { struct SyncStatus {
SyncStatus(); SyncStatus();
SyncStatus(const SyncStatus& other); SyncStatus(const SyncStatus& other);
......
...@@ -26,12 +26,12 @@ struct SyncCycleEvent; ...@@ -26,12 +26,12 @@ struct SyncCycleEvent;
// state upon change. It can send to observers a snapshot of this state as a // state upon change. It can send to observers a snapshot of this state as a
// SyncStatus object, aggregating all this data into one place. // SyncStatus object, aggregating all this data into one place.
// //
// Most of this data ends up on the about:sync page. But the page is only // Most of this data ends up on the chrome://sync-internals page. But the page
// 'pinged' to update itself at the end of a sync cycle. A user could refresh // is only 'pinged' to update itself at the end of a sync cycle. A user could
// manually, but unless their timing is excellent it's unlikely that a user will // refresh manually, but unless their timing is excellent it's unlikely that a
// see any state in mid-sync cycle. We have no plans to change this. However, // user will see any state in mid-sync cycle. We have no plans to change this.
// we will continue to collect data and update state mid-sync-cycle in case we // However, we will continue to collect data and update state mid-sync-cycle in
// need to debug slow or stuck sync cycles. // case we need to debug slow or stuck sync cycles.
class AllStatus : public SyncEngineEventListener { class AllStatus : public SyncEngineEventListener {
public: public:
AllStatus(); AllStatus();
......
...@@ -186,7 +186,7 @@ class SyncManagerImpl ...@@ -186,7 +186,7 @@ class SyncManagerImpl
bool observing_network_connectivity_changes_; bool observing_network_connectivity_changes_;
// Map used to store the notification info to be displayed in // Map used to store the notification info to be displayed in
// about:sync page. // chrome://sync-internals page.
NotificationInfoMap notification_info_map_; NotificationInfoMap notification_info_map_;
// These are for interacting with chrome://sync-internals. // These are for interacting with chrome://sync-internals.
......
...@@ -8,7 +8,7 @@ Much of it has been removed in favor of an ad-hoc system that allows us to ...@@ -8,7 +8,7 @@ Much of it has been removed in favor of an ad-hoc system that allows us to
offer better safety guarantees, and to dispatch requests to different threads. offer better safety guarantees, and to dispatch requests to different threads.
All that remains are some WeakHandles that allow us to send JsEvents from the All that remains are some WeakHandles that allow us to send JsEvents from the
sync backend to about:sync. The SyncInternalsUI implements JsEventHandler in sync backend to chrome://sync-internals. The SyncInternalsUI implements JsEventHandler in
order to receive these events. The SyncManager implements JsBackend in order order to receive these events. The SyncManager implements JsBackend in order
to send them. The SyncJsController acts as an intermediary between them. to send them. The SyncJsController acts as an intermediary between them.
......
...@@ -18,7 +18,7 @@ class Location; ...@@ -18,7 +18,7 @@ class Location;
namespace syncer { namespace syncer {
// Sync errors are used for debug purposes and handled internally and/or // Sync errors are used for debug purposes and handled internally and/or
// exposed through Chrome's "about:sync" internal page. // exposed through Chrome's "chrome://sync-internals" internal page.
// This class is copy-friendly and thread-safe. // This class is copy-friendly and thread-safe.
class SyncError { class SyncError {
public: public:
......
...@@ -134,7 +134,7 @@ SyncSetupService::SyncServiceState SyncSetupService::GetSyncServiceState() { ...@@ -134,7 +134,7 @@ SyncSetupService::SyncServiceState SyncSetupService::GetSyncServiceState() {
case GoogleServiceAuthError::NONE: case GoogleServiceAuthError::NONE:
// Connection failed is not shown to the user, as this will happen if the // Connection failed is not shown to the user, as this will happen if the
// service retuned a 500 error. A more detail error can always be checked // service retuned a 500 error. A more detail error can always be checked
// on about:sync. // on chrome://sync-internals.
case GoogleServiceAuthError::CONNECTION_FAILED: case GoogleServiceAuthError::CONNECTION_FAILED:
case GoogleServiceAuthError::USER_NOT_SIGNED_UP: case GoogleServiceAuthError::USER_NOT_SIGNED_UP:
case GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE: case GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment