Skip to content

GitLab

T
tangled
Commit cd235dd9 authored by Boris Sazonov's avatar Boris Sazonov Committed by Commit Bot
Browse files
Options

[Unity][Android] Remove valueType="floatType" from objectAnimators 

This CL removes XML attribute that sets objectAnimator valueType to
floatType. Both Android Framework and Support Library specify floatType
as the default valueType for objectAnimator, so removing explicit
attributes doesn't change the behavior, while improving readability and
reducing resources size.

Bug: 814728
Change-Id: Iea356ca491d23fae3ed9a54339fb746a5259f33e
Reviewed-on: https://chromium-review.googlesource.com/1027812Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553951}
parent 430b4497
Show whitespace changes
Inline Side-by-side
Showing with 16 additions and 32 deletions
chrome/android/java/res/drawable/signin_header_animation.xml
View file @ cd235dd9
......@@ -143,14 +143,12 @@
android:duration="3900"
android:propertyName="translateX"
android:valueFrom="0"
android:valueTo="-3.24"
android:valueType="floatType"/>
android:valueTo="-3.24"/>
<objectAnimator
android:duration="6550"
android:propertyName="translateX"
android:valueFrom="-3.24"
android:valueTo="0"
android:valueType="floatType"/>
android:valueTo="0"/>
</set>
</aapt:attr>
</target>
......@@ -161,14 +159,12 @@
android:duration="4650"
android:propertyName="translateX"
android:valueFrom="0"
android:valueTo="-2.16"
android:valueType="floatType"/>
android:valueTo="-2.16"/>
<objectAnimator
android:duration="5800"
android:propertyName="translateX"
android:valueFrom="-2.16"
android:valueTo="0"
android:valueType="floatType"/>
android:valueTo="0"/>
</set>
</aapt:attr>
</target>
......@@ -179,14 +175,12 @@
android:duration="6150"
android:propertyName="translateX"
android:valueFrom="0"
android:valueTo="-5.04"
android:valueType="floatType"/>
android:valueTo="-5.04"/>
<objectAnimator
android:duration="4300"
android:propertyName="translateX"
android:valueFrom="-5.04"
android:valueTo="0"
android:valueType="floatType"/>
android:valueTo="0"/>
</set>
</aapt:attr>
</target>
......@@ -197,14 +191,12 @@
android:duration="5550"
android:propertyName="translateX"
android:valueFrom="0"
android:valueTo="5.04"
android:valueType="floatType"/>
android:valueTo="5.04"/>
<objectAnimator
android:duration="4900"
android:propertyName="translateX"
android:valueFrom="5.04"
android:valueTo="0"
android:valueType="floatType"/>
android:valueTo="0"/>
</set>
</aapt:attr>
</target>
......@@ -215,29 +207,25 @@
android:duration="700"
android:propertyName="rotation"
android:valueFrom="0"
android:valueTo="-360"
android:valueType="floatType"/>
android:valueTo="-360"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="0"
android:valueTo="-360"
android:valueType="floatType"/>
android:valueTo="-360"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="0"
android:valueTo="-360"
android:valueType="floatType"/>
android:valueTo="-360"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="0"
android:valueTo="-360"
android:valueType="floatType"/>
android:valueTo="-360"/>
</set>
</aapt:attr>
</target>
......@@ -248,29 +236,25 @@
android:duration="700"
android:propertyName="rotation"
android:valueFrom="-120"
android:valueTo="120"
android:valueType="floatType"/>
android:valueTo="120"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="120"
android:valueTo="-120"
android:valueType="floatType"/>
android:valueTo="-120"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="-120"
android:valueTo="120"
android:valueType="floatType"/>
android:valueTo="120"/>
<objectAnimator
android:duration="700"
android:propertyName="rotation"
android:startOffset="1900"
android:valueFrom="120"
android:valueTo="-120"
android:valueType="floatType"/>
android:valueTo="-120"/>
</set>
</aapt:attr>
</target>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment