Commit cefd306c authored by Eyor Alemayehu's avatar Eyor Alemayehu Committed by Commit Bot

Send a dogfood server-side experiment ID to Assistant

Sending the experiment is controlled by a Finch experiment.

Bug: b:117847982
Test: Manual
Change-Id: I542a131d931254d610c8acaf5bc0f116b4d19b60
Reviewed-on: https://chromium-review.googlesource.com/c/1291355Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Eyor Alemayehu <eyor@google.com>
Cr-Commit-Position: refs/heads/master@{#603541}
parent f6e3f59d
......@@ -57,6 +57,9 @@ constexpr char kTimerFireNotificationGroupId[] = "assistant/timer_fire";
constexpr char kQueryDeeplinkPrefix[] = "googleassistant://send-query?q=";
constexpr base::Feature kAssistantTimerNotificationFeature{
"ChromeOSAssistantTimerNotification", base::FEATURE_ENABLED_BY_DEFAULT};
constexpr base::Feature kChromeOSAssistantDogfood{
"ChromeOSAssistantDogfood", base::FEATURE_DISABLED_BY_DEFAULT};
constexpr char kServersideDogfoodExperimentId[] = "20347368";
constexpr float kDefaultSliderStep = 0.1f;
} // namespace
......@@ -777,6 +780,12 @@ void AssistantManagerServiceImpl::StartAssistantInternal(
assistant_manager_->AddConversationStateListener(this);
assistant_manager_->AddDeviceStateListener(this);
std::vector<std::string> server_experiment_ids;
FillServerExperimentIds(server_experiment_ids);
if (server_experiment_ids.size() > 0)
assistant_manager_internal_->AddExtraExperimentIds(server_experiment_ids);
SetAccessToken(access_token);
assistant_manager_->Start();
......@@ -1162,5 +1171,13 @@ std::string AssistantManagerServiceImpl::GetLastSearchSource() {
last_search_source_ = std::string();
return search_source;
}
void AssistantManagerServiceImpl::FillServerExperimentIds(
std::vector<std::string>& server_experiment_ids) {
if (base::FeatureList::IsEnabled(kChromeOSAssistantDogfood)) {
server_experiment_ids.emplace_back(kServersideDogfoodExperimentId);
}
}
} // namespace assistant
} // namespace chromeos
......@@ -210,6 +210,8 @@ class AssistantManagerServiceImpl
std::unique_ptr<ui::AssistantTree> assistant_tree,
const std::vector<uint8_t>& assistant_screenshot);
void FillServerExperimentIds(std::vector<std::string>& server_experiment_ids);
State state_ = State::STOPPED;
std::unique_ptr<PlatformApiImpl> platform_api_;
bool enable_hotword_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment