Skip to content

GitLab

T
tangled
Commit cf3a7e72 authored by Andrey Zaytsev's avatar Andrey Zaytsev Committed by Commit Bot
Browse files
Options

Safety check for Android: updated strings to match the UI deck 

UI deck: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit?ts=5ef0c30f#slide=id.g8a1bab3ac0_6_25

Bug: 1070620
Change-Id: Ie8a660e5cb29c40009320e71b4347c4e7b95b9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339134
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#795497}
parent 3829283e
Show whitespace changes
Inline Side-by-side
Showing with 33 additions and 5 deletions
chrome/browser/safety_check/android/java/src/org/chromium/chrome/browser/safety_check/SafetyCheckViewBinder.java
View file @ cf3a7e72
...@@ -32,11 +32,15 @@ class SafetyCheckViewBinder { ...@@ -32,11 +32,15 @@ class SafetyCheckViewBinder {
case PasswordsState.NO_PASSWORDS: case PasswordsState.NO_PASSWORDS:
return R.string.safety_check_passwords_no_passwords; return R.string.safety_check_passwords_no_passwords;
case PasswordsState.SIGNED_OUT: case PasswordsState.SIGNED_OUT:
return R.string.safety_check_passwords_error_signed_out;
case PasswordsState.QUOTA_LIMIT: case PasswordsState.QUOTA_LIMIT:
return R.string.safety_check_passwords_error_quota_limit;
case PasswordsState.OFFLINE: case PasswordsState.OFFLINE:
return R.string.safety_check_passwords_error_offline;
case PasswordsState.ERROR: case PasswordsState.ERROR:
return R.string.safety_check_error; return R.string.safety_check_passwords_error;
case PasswordsState.SAFE: case PasswordsState.SAFE:
return R.string.safety_check_passwords_safe;
case PasswordsState.COMPROMISED_EXIST: case PasswordsState.COMPROMISED_EXIST:
// TODO(crbug.com/1070620): update the strings for all states once available. // TODO(crbug.com/1070620): update the strings for all states once available.
return 0; return 0;
......
chrome/browser/ui/android/strings/android_chrome_strings.grd
View file @ cf3a7e72
...@@ -910,19 +910,34 @@ Your Google account may have other forms of browsing history like searches and a ...@@ -910,19 +910,34 @@ Your Google account may have other forms of browsing history like searches and a
Enhanced Protection is on Enhanced Protection is on
</message> </message>
<message name="IDS_SAFETY_CHECK_SAFE_BROWSING_DISABLED_BY_ADMIN" desc="Text to display when Safe Browsing is disabled by admin."> <message name="IDS_SAFETY_CHECK_SAFE_BROWSING_DISABLED_BY_ADMIN" desc="Text to display when Safe Browsing is disabled by admin.">
Your administrator has turned off Safe Browsing Turned off by your administrator
</message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_SAFE" desc="Text to display when no passwords are compromised.">
No compromised passwords found
</message> </message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_NO_PASSWORDS" desc="Text to display when no passwords are saved."> <message name="IDS_SAFETY_CHECK_PASSWORDS_NO_PASSWORDS" desc="Text to display when no passwords are saved.">
No saved passwords No saved passwords
</message> </message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_ERROR" desc="Text to display when the password check has an unknown error.">
Chrome can’t check your passwords
</message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_ERROR_OFFLINE" desc="Text to display when the password check has an unknown error.">
Offline. Chrome can’t check your passwords.
</message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_ERROR_SIGNED_OUT" desc="Text to display when the password check is unable to run because the usere is signed out.">
Sign in to your Google account to check your passwords
</message>
<message name="IDS_SAFETY_CHECK_PASSWORDS_ERROR_QUOTA_LIMIT" desc="Text to display when the password check hits the daily quota limit.">
Chrome couldn’t check all passwords
</message>
<message name="IDS_SAFETY_CHECK_UPDATES_UPDATED" desc="Text to display when the updates check confirms that the latest version is already installed."> <message name="IDS_SAFETY_CHECK_UPDATES_UPDATED" desc="Text to display when the updates check confirms that the latest version is already installed.">
You are running the latest version of Chrome Chrome is up to date
</message> </message>
<message name="IDS_SAFETY_CHECK_UPDATES_OUTDATED" desc="Text to display when the updates check detects a new version."> <message name="IDS_SAFETY_CHECK_UPDATES_OUTDATED" desc="Text to display when the updates check detects a new version.">
A newer version of Chrome is available. Tap this element to go to the Play Store. Chrome is out of date
</message> </message>
<message name="IDS_SAFETY_CHECK_UPDATES_OFFLINE" desc="Text to display when the updates check failed because of no connectivity."> <message name="IDS_SAFETY_CHECK_UPDATES_OFFLINE" desc="Text to display when the updates check failed because of no connectivity.">
Chrome can't check for updates. Try checking your internet connection. Offline. Chrome can’t check for updates.
</message> </message>
<message name="IDS_SAFETY_CHECK_UPDATES_ERROR" desc="Text to display when the updates check failed for some reason."> <message name="IDS_SAFETY_CHECK_UPDATES_ERROR" desc="Text to display when the updates check failed for some reason.">
Chrome can’t check for updates Chrome can’t check for updates
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment