Commit cf4e7dcb authored by Nohemi Fernandez's avatar Nohemi Fernandez Committed by Commit Bot

[iOS] Fix broken tests due to missing completion in fake ViewController.

AddAccountSigninManagerTests were failing due to a missing run
completion. Remove intermediary method that causes this failure.

Bug: 1078815
Change-Id: I1766e593927cd40be318cf66bb67d11f5ed47006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264057
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782928}
parent 1164003e
......@@ -496,8 +496,7 @@ void ChooseImportOrKeepDataSepareteDialog(id<GREYMatcher> choiceButtonMatcher) {
[SigninEarlGreyUtils
waitForMatcher:grey_accessibilityID(kFakeAddAccountViewIdentifier)];
// Close the SSO view controller.
id<GREYMatcher> matcher =
grey_allOf(chrome_test_util::ButtonWithAccessibilityLabel(@"Cancel"),
id<GREYMatcher> matcher = grey_allOf(ButtonWithAccessibilityLabel(@"Cancel"),
grey_sufficientlyVisible(), nil);
[[EarlGrey selectElementWithMatcher:matcher] performAction:grey_tap()];
// Make sure the SSO view controller is fully removed before ending the test.
......@@ -515,11 +514,14 @@ void ChooseImportOrKeepDataSepareteDialog(id<GREYMatcher> choiceButtonMatcher) {
[SigninEarlGreyUI tapAddAccountButton];
[self assertFakeSSOScreenIsVisible];
// Close sign-in screen and Settings.
[[EarlGrey selectElementWithMatcher:
ButtonWithAccessibilityLabelId(
IDS_IOS_ACCOUNT_CONSISTENCY_SETUP_SKIP_BUTTON)]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:SettingsDoneButton()]
performAction:grey_tap()];
[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
}
......
......@@ -174,7 +174,7 @@
[self runCompletionCallbackWithError:error];
return;
}
[self.delegate interactionManager:self
[_viewController
dismissViewControllerAnimated:animated
completion:^{
[self runCompletionCallbackWithError:error];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment