Remove a few more unnecessary std::move() calls.

-Wpessimizing-move missed a few calls for a while. Now it finds them again,
so clean them up.

Bug: 1010458
Change-Id: Ifc7a9d354657a863b22324c3eae40787a1064718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834905
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702084}

android_webview/renderer/js_java_interaction/js_java_configurator.cc

@@ -38,8 +38,8 @@ void JsJavaConfigurator::SetJsObjects(
     JsObjectInfo* js_object_info = js_object_info_pair.first->second.get();
     js_object_info->allowed_origin_rules = js_object->allowed_origin_rules;
     js_object_info->js_to_java_messaging =
-        std::move(mojo::AssociatedRemote<mojom::JsToJavaMessaging>(
-            std::move(js_object->js_to_java_messaging)));
+        mojo::AssociatedRemote<mojom::JsToJavaMessaging>(
+            std::move(js_object->js_to_java_messaging));
   }
   js_objects_.swap(js_objects);
 }

chrome/browser/performance_manager/decorators/process_metrics_decorator_unittest.cc

@@ -165,9 +165,9 @@ TEST_F(ProcessMetricsDecoratorTest, RefreshTimer) {
 
 TEST_F(ProcessMetricsDecoratorTest, PartialRefresh) {
   // Only contains the data for one of the two processes.
-  auto partial_memory_dump = base::make_optional(std::move(
+  auto partial_memory_dump = base::make_optional(
       GenerateMemoryDump({{mock_graph()->process->process_id(),
-                           kFakeResidentSetKb, kFakePrivateFootprintKb}})));
+                           kFakeResidentSetKb, kFakePrivateFootprintKb}}));
 
   EXPECT_CALL(*decorator(), GetMemoryDump())
       .WillOnce(
@@ -181,9 +181,9 @@ TEST_F(ProcessMetricsDecoratorTest, PartialRefresh) {
 
   // Do another partial refresh but this time for the other process. The data
   // attached to |mock_graph()->process| shouldn't change.
-  auto partial_memory_dump2 = base::make_optional(std::move(GenerateMemoryDump(
+  auto partial_memory_dump2 = base::make_optional(GenerateMemoryDump(
       {{mock_graph()->other_process->process_id(), kFakeResidentSetKb * 2,
-        kFakePrivateFootprintKb * 2}})));
+        kFakePrivateFootprintKb * 2}}));
   EXPECT_CALL(*decorator(), GetMemoryDump())
       .WillOnce(
           testing::Return(testing::ByMove(std::move(partial_memory_dump2))));

chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc

@@ -317,8 +317,8 @@ TEST_F(ChromeOmniboxNavigationObserverTest, AlternateNavInfoBar) {
       net_status = network::URLLoaderCompletionStatus(net::ERR_FAILED);
     } else {
       net_status = network::URLLoaderCompletionStatus(net::OK);
-      http_head = std::move(network::CreateURLResponseHead(
-          static_cast<net::HttpStatusCode>(response.http_response_code)));
+      http_head = network::CreateURLResponseHead(
+          static_cast<net::HttpStatusCode>(response.http_response_code));
     }
 
     test_url_loader_factory.AddResponse(GURL(response.urls[0]),

components/autofill_assistant/browser/controller_unittest.cc

@@ -81,11 +81,11 @@ struct MockCollectUserDataOptions : public CollectUserDataOptions {
   MockCollectUserDataOptions() {
     base::MockOnceCallback<void(std::unique_ptr<UserData>)>
         mock_confirm_callback;
-    confirm_callback = std::move(mock_confirm_callback.Get());
+    confirm_callback = mock_confirm_callback.Get();
     base::MockOnceCallback<void(int)> mock_actions_callback;
-    additional_actions_callback = std::move(mock_actions_callback.Get());
+    additional_actions_callback = mock_actions_callback.Get();
     base::MockOnceCallback<void(int)> mock_terms_callback;
-    terms_link_callback = std::move(mock_terms_callback.Get());
+    terms_link_callback = mock_terms_callback.Get();
   }
 };