Commit d084e49b authored by Fred Mello's avatar Fred Mello Committed by Commit Bot

Fix histogram logging when native code hasn't been initialized

Calling cached version instead.

Related to:
https://chromium-review.googlesource.com/c/chromium/src/+/1813520

Bug: 1010895, 1005802
Change-Id: I0dd35b3204da1712e92dba0ac1c711a8b522bd68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837408Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702445}
parent 33522bd4
...@@ -6,7 +6,7 @@ package org.chromium.components.module_installer.logger; ...@@ -6,7 +6,7 @@ package org.chromium.components.module_installer.logger;
import com.google.android.play.core.splitinstall.model.SplitInstallErrorCode; import com.google.android.play.core.splitinstall.model.SplitInstallErrorCode;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.CachedMetrics.EnumeratedHistogramSample;
class SplitInstallFailureLogger { class SplitInstallFailureLogger {
// FeatureModuleInstallStatus defined in //tools/metrics/histograms/enums.xml. // FeatureModuleInstallStatus defined in //tools/metrics/histograms/enums.xml.
...@@ -99,6 +99,7 @@ class SplitInstallFailureLogger { ...@@ -99,6 +99,7 @@ class SplitInstallFailureLogger {
private void log(String moduleName, int code) { private void log(String moduleName, int code) {
String name = "Android.FeatureModules.InstallStatus." + moduleName; String name = "Android.FeatureModules.InstallStatus." + moduleName;
RecordHistogram.recordEnumeratedHistogram(name, code, COUNT); EnumeratedHistogramSample sample = new EnumeratedHistogramSample(name, COUNT);
sample.record(code);
} }
} }
...@@ -6,7 +6,7 @@ package org.chromium.components.module_installer.logger; ...@@ -6,7 +6,7 @@ package org.chromium.components.module_installer.logger;
import com.google.android.play.core.splitinstall.model.SplitInstallSessionStatus; import com.google.android.play.core.splitinstall.model.SplitInstallSessionStatus;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.CachedMetrics.EnumeratedHistogramSample;
class SplitInstallStatusLogger { class SplitInstallStatusLogger {
// FeatureModuleInstallingStatus defined in //tools/metrics/histograms/enums.xml. // FeatureModuleInstallingStatus defined in //tools/metrics/histograms/enums.xml.
...@@ -67,6 +67,7 @@ class SplitInstallStatusLogger { ...@@ -67,6 +67,7 @@ class SplitInstallStatusLogger {
private void recordInstallStatus(String moduleName, int status) { private void recordInstallStatus(String moduleName, int status) {
String name = "Android.FeatureModules.InstallingStatus." + moduleName; String name = "Android.FeatureModules.InstallingStatus." + moduleName;
RecordHistogram.recordEnumeratedHistogram(name, status, COUNT); EnumeratedHistogramSample sample = new EnumeratedHistogramSample(name, COUNT);
sample.record(status);
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment