Commit d0e7d3bb authored by Wei Li's avatar Wei Li Committed by Commit Bot

Use PdfCompositor for printing by default

Turn on using pdf compositor service for printing by default. Still keep
the feature flag as a kill switch for now.

BUG=824867

Change-Id: I5b7751c5ce453a7ffcda1bf38b5f141135f850f6
Reviewed-on: https://chromium-review.googlesource.com/1087872Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565018}
parent 5f7e34af
...@@ -525,21 +525,13 @@ IN_PROC_BROWSER_TEST_F(IsolateOriginsPrintBrowserTest, PrintIsolatedSubframe) { ...@@ -525,21 +525,13 @@ IN_PROC_BROWSER_TEST_F(IsolateOriginsPrintBrowserTest, PrintIsolatedSubframe) {
} }
// Printing preview a webpage. // Printing preview a webpage.
// Test that we won't use oopif printing by default, unless the // Test that we use oopif printing by default.
// test is run with site-per-process flag enabled.
IN_PROC_BROWSER_TEST_F(PrintBrowserTest, RegularPrinting) { IN_PROC_BROWSER_TEST_F(PrintBrowserTest, RegularPrinting) {
ASSERT_TRUE(embedded_test_server()->Started()); ASSERT_TRUE(embedded_test_server()->Started());
GURL url(embedded_test_server()->GetURL("/printing/test1.html")); GURL url(embedded_test_server()->GetURL("/printing/test1.html"));
ui_test_utils::NavigateToURL(browser(), url); ui_test_utils::NavigateToURL(browser(), url);
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess) ||
base::FeatureList::IsEnabled(
printing::features::kUsePdfCompositorServiceForPrint)) {
EXPECT_TRUE(IsOopifEnabled()); EXPECT_TRUE(IsOopifEnabled());
} else {
EXPECT_FALSE(IsOopifEnabled());
}
} }
// Printing preview a webpage with isolate-origins enabled. // Printing preview a webpage with isolate-origins enabled.
......
...@@ -8,7 +8,7 @@ namespace printing { ...@@ -8,7 +8,7 @@ namespace printing {
namespace features { namespace features {
const base::Feature kUsePdfCompositorServiceForPrint{ const base::Feature kUsePdfCompositorServiceForPrint{
"UsePdfCompositorServiceForPrint", base::FEATURE_DISABLED_BY_DEFAULT}; "UsePdfCompositorServiceForPrint", base::FEATURE_ENABLED_BY_DEFAULT};
} // namespace features } // namespace features
} // namespace printing } // namespace printing
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment