Commit d117efce authored by kjellander's avatar kjellander Committed by Commit bot

Move third_party/libjingle/overrides to third_party/webrtc_overrides

Remove non-existing include path references to the old libjingle
source dir as well.

Don't update any targets to reduce complexity in landing
the switch in https://codereview.chromium.org/2022833002 first.
After that's done the target should be moved into third_party/webrtc_overrides.

BUG=webrtc:4256

Review-Url: https://codereview.chromium.org/2082473002
Cr-Commit-Position: refs/heads/master@{#400755}
parent 7ddd5ccd
...@@ -66,6 +66,7 @@ include_rules = [ ...@@ -66,6 +66,7 @@ include_rules = [
"+third_party/sqlite", "+third_party/sqlite",
"+third_party/khronos", "+third_party/khronos",
"+third_party/webrtc", "+third_party/webrtc",
"+third_party/webrtc_overrides",
"+third_party/zlib/google", "+third_party/zlib/google",
"+third_party/WebKit/public/platform", "+third_party/WebKit/public/platform",
"+third_party/WebKit/public/web", "+third_party/WebKit/public/web",
......
...@@ -52,7 +52,7 @@ ...@@ -52,7 +52,7 @@
#endif #endif
#if defined(ENABLE_WEBRTC) #if defined(ENABLE_WEBRTC)
#include "third_party/libjingle/overrides/init_webrtc.h" #include "third_party/webrtc_overrides/init_webrtc.h"
#endif #endif
#if defined(USE_OZONE) #if defined(USE_OZONE)
......
...@@ -64,7 +64,7 @@ ...@@ -64,7 +64,7 @@
#endif #endif
#if defined(ENABLE_WEBRTC) #if defined(ENABLE_WEBRTC)
#include "third_party/libjingle/overrides/init_webrtc.h" #include "third_party/webrtc_overrides/init_webrtc.h"
#endif #endif
#if defined(SANITIZER_COVERAGE) #if defined(SANITIZER_COVERAGE)
......
# Needed by logging_unittest.cc since it tests the overrides. # Needed by logging_unittest.cc since it tests the overrides.
include_rules = [ include_rules = [
"+third_party/libjingle/overrides",
"+third_party/webrtc", "+third_party/webrtc",
'+third_party/webrtc_overrides', '+third_party/webrtc_overrides',
] ]
...@@ -26,9 +26,7 @@ config("jingle_unexported_configs") { ...@@ -26,9 +26,7 @@ config("jingle_unexported_configs") {
] ]
include_dirs = [ include_dirs = [
"overrides",
"../../third_party/webrtc_overrides", "../../third_party/webrtc_overrides",
"source",
"../../testing/gtest/include", "../../testing/gtest/include",
"../../third_party", "../../third_party",
"../../third_party/libyuv/include", "../../third_party/libyuv/include",
...@@ -40,8 +38,6 @@ config("jingle_unexported_configs") { ...@@ -40,8 +38,6 @@ config("jingle_unexported_configs") {
config("jingle_public_configs") { config("jingle_public_configs") {
include_dirs = [ include_dirs = [
"../../third_party/webrtc_overrides", "../../third_party/webrtc_overrides",
"overrides",
"source",
"../../testing/gtest/include", "../../testing/gtest/include",
"../../third_party", "../../third_party",
] ]
...@@ -225,7 +221,7 @@ static_library("libjingle") { ...@@ -225,7 +221,7 @@ static_library("libjingle") {
] ]
} else { } else {
# Otherwise, we just add the field_trial which redirects to base. # Otherwise, we just add the field_trial which redirects to base.
sources += [ "overrides/field_trial.cc" ] sources += [ "../webrtc_overrides/field_trial.cc" ]
} }
configs += [ ":jingle_unexported_configs" ] configs += [ ":jingle_unexported_configs" ]
...@@ -233,10 +229,13 @@ static_library("libjingle") { ...@@ -233,10 +229,13 @@ static_library("libjingle") {
} }
if (enable_webrtc) { if (enable_webrtc) {
# TODO(kjellander): Move this target into //third_party/webrtc_overrides as
# soon as the work in bugs.webrtc.org/4256 has gotten rid of the duplicated
# source listings above.
source_set("libjingle_webrtc") { source_set("libjingle_webrtc") {
sources = [ sources = [
"overrides/init_webrtc.cc", "../webrtc_overrides/init_webrtc.cc",
"overrides/init_webrtc.h", "../webrtc_overrides/init_webrtc.h",
] ]
configs += [ ":jingle_unexported_configs" ] configs += [ ":jingle_unexported_configs" ]
public_configs = [ ":jingle_public_configs" ] public_configs = [ ":jingle_public_configs" ]
......
...@@ -28,9 +28,7 @@ ...@@ -28,9 +28,7 @@
'WEBRTC_CHROMIUM_BUILD', 'WEBRTC_CHROMIUM_BUILD',
], ],
'include_dirs': [ 'include_dirs': [
'./overrides',
'../../third_party/webrtc_overrides', '../../third_party/webrtc_overrides',
'./source',
'../..', '../..',
'../../testing/gtest/include', '../../testing/gtest/include',
'../../third_party', '../../third_party',
...@@ -50,8 +48,6 @@ ...@@ -50,8 +48,6 @@
'direct_dependent_settings': { 'direct_dependent_settings': {
'include_dirs': [ 'include_dirs': [
'../../third_party/webrtc_overrides', '../../third_party/webrtc_overrides',
'./overrides',
'./source',
'../..', '../..',
'../../testing/gtest/include', '../../testing/gtest/include',
'../../third_party', '../../third_party',
...@@ -363,12 +359,16 @@ ...@@ -363,12 +359,16 @@
], ],
}, # target libjingle_webrtc_common }, # target libjingle_webrtc_common
{ {
# TODO(kjellander): Move this target into
# //third_party/webrtc_overrides as soon as the work in
# bugs.webrtc.org/4256 has gotten rid of the duplicated source
# listings above.
# GN version: //third_party/libjingle:libjingle_webrtc # GN version: //third_party/libjingle:libjingle_webrtc
'target_name': 'libjingle_webrtc', 'target_name': 'libjingle_webrtc',
'type': 'static_library', 'type': 'static_library',
'sources': [ 'sources': [
'overrides/init_webrtc.cc', '../webrtc_overrides/init_webrtc.cc',
'overrides/init_webrtc.h', '../webrtc_overrides/init_webrtc.h',
], ],
'dependencies': [ 'dependencies': [
'<(DEPTH)/third_party/webrtc/modules/modules.gyp:audio_processing', '<(DEPTH)/third_party/webrtc/modules/modules.gyp:audio_processing',
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
'webrtc_xmpp': "../webrtc/libjingle/xmpp", 'webrtc_xmpp': "../webrtc/libjingle/xmpp",
}, },
'sources': [ 'sources': [
'overrides/field_trial.cc', '../webrtc_overrides/field_trial.cc',
'<(webrtc_p2p)/base/asyncstuntcpsocket.cc', '<(webrtc_p2p)/base/asyncstuntcpsocket.cc',
'<(webrtc_p2p)/base/asyncstuntcpsocket.h', '<(webrtc_p2p)/base/asyncstuntcpsocket.h',
'<(webrtc_p2p)/base/basicpacketsocketfactory.cc', '<(webrtc_p2p)/base/basicpacketsocketfactory.cc',
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
{ {
'variables': { 'variables': {
'libjingle_source': "source",
'webrtc_base': "../webrtc/base", 'webrtc_base': "../webrtc/base",
'webrtc_xmllite': "../webrtc/libjingle/xmllite", 'webrtc_xmllite': "../webrtc/libjingle/xmllite",
'webrtc_p2p': "../webrtc/p2p", 'webrtc_p2p': "../webrtc/p2p",
...@@ -44,7 +43,6 @@ ...@@ -44,7 +43,6 @@
'timezone=_timezone', 'timezone=_timezone',
], ],
'include_dirs': [ 'include_dirs': [
'./<(libjingle_source)',
'../', '../',
], ],
'includes': ['libjingle_common.gypi', ], 'includes': ['libjingle_common.gypi', ],
...@@ -254,7 +252,7 @@ ...@@ -254,7 +252,7 @@
'sources!': [ 'sources!': [
# For NACL, we have the field_trial_default and don't need the # For NACL, we have the field_trial_default and don't need the
# field_trail.cc. # field_trail.cc.
'overrides/field_trial.cc', '../webrtc_overrides/field_trial.cc',
], ],
'sources/': [ 'sources/': [
['exclude', '/mac[a-z]+\\.(h|cc)$'], ['exclude', '/mac[a-z]+\\.(h|cc)$'],
...@@ -269,8 +267,6 @@ ...@@ -269,8 +267,6 @@
], ],
'direct_dependent_settings': { 'direct_dependent_settings': {
'include_dirs': [ 'include_dirs': [
'./overrides',
'./<(libjingle_source)',
'../../third_party/webrtc_overrides', '../../third_party/webrtc_overrides',
'../../third_party', '../../third_party',
'../../third_party/webrtc', '../../third_party/webrtc',
......
include_rules = [
'+base',
'+third_party/webrtc',
'+third_party/webrtc_overrides',
]
...@@ -2,12 +2,12 @@ ...@@ -2,12 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef THIRD_PARTY_LIBJINGLE_OVERRIDES_INIT_WEBRTC_H_ #ifndef THIRD_PARTY_WEBRTC_OVERRIDES_INIT_WEBRTC_H_
#define THIRD_PARTY_LIBJINGLE_OVERRIDES_INIT_WEBRTC_H_ #define THIRD_PARTY_WEBRTC_OVERRIDES_INIT_WEBRTC_H_
// Initialize WebRTC. Call this explicitly to initialize WebRTC module // Initialize WebRTC. Call this explicitly to initialize WebRTC module
// (before initializing the sandbox in Chrome) and hook up Chrome+WebRTC // (before initializing the sandbox in Chrome) and hook up Chrome+WebRTC
// integration such as common logging and tracing. // integration such as common logging and tracing.
bool InitializeWebRtcModule(); bool InitializeWebRtcModule();
#endif // THIRD_PARTY_LIBJINGLE_OVERRIDES_INIT_WEBRTC_H_ #endif // THIRD_PARTY_WEBRTC_OVERRIDES_INIT_WEBRTC_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment