Commit d1ad4fcf authored by Chan Li's avatar Chan Li Committed by Commit Bot

Enable "chromium.resultdb.result_sink" experiment on chromium try builders at 10%

Bug: 1108016
Change-Id: Ia739b0a0f8c7607155ac40dcb6d1c9493265039a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488386Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819084}
parent e8af7273
This diff is collapsed.
...@@ -120,6 +120,7 @@ def try_builder( ...@@ -120,6 +120,7 @@ def try_builder(
main_list_view = args.DEFAULT, main_list_view = args.DEFAULT,
subproject_list_view = args.DEFAULT, subproject_list_view = args.DEFAULT,
tryjob = None, tryjob = None,
experiments = None,
**kwargs): **kwargs):
"""Define a try builder. """Define a try builder.
...@@ -148,10 +149,16 @@ def try_builder( ...@@ -148,10 +149,16 @@ def try_builder(
no effect on adding an entry to the subproject list view. no effect on adding an entry to the subproject list view.
tryjob - A struct containing the details of the tryjob verifier for the tryjob - A struct containing the details of the tryjob verifier for the
builder, obtained by calling the `tryjob` function. builder, obtained by calling the `tryjob` function.
experiments - a dict of experiment name to the percentage chance (0-100)
that it will apply to builds generated from this builder.
""" """
if not branches.matches(branch_selector): if not branches.matches(branch_selector):
return return
# Enable "chromium.resultdb.result_sink" on all try builders for 10% by default.
experiments = experiments or {}
experiments.setdefault("chromium.resultdb.result_sink", 10)
# Define the builder first so that any validation of luci.builder arguments # Define the builder first so that any validation of luci.builder arguments
# (e.g. bucket) occurs before we try to use it # (e.g. bucket) occurs before we try to use it
builders.builder( builders.builder(
...@@ -160,6 +167,7 @@ def try_builder( ...@@ -160,6 +167,7 @@ def try_builder(
resultdb_bigquery_exports = [resultdb.export_test_results( resultdb_bigquery_exports = [resultdb.export_test_results(
bq_table = "luci-resultdb.chromium.try_test_results", bq_table = "luci-resultdb.chromium.try_test_results",
)], )],
experiments = experiments,
**kwargs **kwargs
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment